On Mon, 24 Apr 2023 11:59:03 GMT, Adam Sotona wrote:
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every pr
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Fri, 28 Apr 2023 19:34:40 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use $(JVM_LIBS), which includes -lrt on Linux currently.
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 228
On Fri, 28 Apr 2023 19:32:40 GMT, Erik Joelsson wrote:
> This is the same list as the LIBJLI_EXTRA_FILES above. Would be good to avoid
> the duplication.
@erikj79 Addressed in the extracted https://github.com/openjdk/jdk/pull/13768,
which contains .a related changes only (without linking 'java
This PR is branched from the makefile changes for
https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
handling the JDK/VM static libraries:
- Create libjvm.a together with other JDK static libraries when building
'static-libs-image' (or 'static-libs-bundles') target, incl
On Thu, 27 Apr 2023 09:40:46 GMT, Aleksey Shipilev wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-83050920-thread-sleep-subms
>> - Merge branch 'mast
Refactor the Platform class in jdk.jpackage to use the internal
OperatingSystem, Architecture, and Version classes.
The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
comparisons in the Platform class.
The checks of the os.version are replaced but may not be needed if OpenJDK no
On Thu, 9 Mar 2023 19:49:29 GMT, Eamonn McManus wrote:
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already i
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote:
> Textual specification clarifications.
This pull request has now been integrated.
Changeset: 05b9b582
Author:Stuart Marks
URL:
https://git.openjdk.org/jdk/commit/05b9b5821db0e0d5d998a1bd8574aa6021878c9e
Stats: 32 lines in 2
On Tue, 2 May 2023 19:54:14 GMT, Eamonn McManus wrote:
>> Instant.ofEpochMilli says this:
>>
>>
>> @throws DateTimeException if the instant exceeds the maximum or minimum
>> instant
>>
>>
>> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
>> does not throw. That's
On Tue, 2 May 2023 18:59:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add distinction between legacy and grandfathered to spec
>
> src/java.base/share/classes/java/util/Locale.java line 1809:
>
> Please review this PR which adds the method `caseFoldLanguageTag(String
> languageTag)` to java.util.Locale.
>
> This method case folds a language tag to adhere to _[section 2.1.1.
> Formatting of Language Tags of
> RFC5646](https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1)_. This
> f
On Tue, 2 May 2023 21:22:16 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1] abstrac
On Mon, 1 May 2023 14:56:27 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
On Tue, 2 May 2023 18:34:11 GMT, Justin Lu wrote:
>> Please review this PR which adds the method `caseFoldLanguageTag(String
>> languageTag)` to java.util.Locale.
>>
>> This method case folds a language tag to adhere to _[section 2.1.1.
>> Formatting of Language Tags of
>> RFC5646](https://ww
On Sun, 30 Apr 2023 07:37:07 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> sinc
> Add a system property, jdk.xml.config.file, to return the path to a custom
> JAXP configuration file. The current configuration file, jaxp.properties,
> that the JDK supports will become the default configuration file.
>
> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>
> Tests: XML SQE an
> Instant.ofEpochMilli says this:
>
>
> @throws DateTimeException if the instant exceeds the maximum or minimum
> instant
>
>
> But that can't happen. Even given `Long.MIN_VALUE` or `Long.MAX_VALUE` it
> does not throw. That's already implicitly tested in
> [`TestInstant`](https://github.com
On Sun, 30 Apr 2023 07:40:22 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> sinc
On Mon, 1 May 2023 18:25:13 GMT, Naoto Sato wrote:
> Regarding the new unit tests, it looks like there are a lot of boilerplate
> codes. Can they be shared?
Multiple tests per a processor, and separate test per each processor, if that's
what you meant, they unfortunately can not be run within
On Sun, 30 Apr 2023 07:27:12 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains ten additional commits
>> sinc
On Sun, 30 Apr 2023 07:53:06 GMT, Alan Bateman wrote:
>> src/java.xml/share/classes/module-info.java line 33:
>>
>>> 31: * JAXP supports the use of a configuration file for the
>>> 32: * Factory Lookup Mechanism and
>>> 33: * setting properties that have defined corresponding system propertie
On Mon, 1 May 2023 22:23:11 GMT, Chen Liang wrote:
> It had an invocation performance of 2ns/op as opposed to Proxy's 6ns/op, but
> the condy implementation has 0.41ns/op.
Good, so let’s take the win relative to 6ns/op metric.
The condy implementation devotes a whole class to a single MH, so i
On Tue, 2 May 2023 06:04:17 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Runtime.halt.
>
> Updated version, and the wording of halt's description, looks okay.
@AlanBateman Great. Can yo
> Add a system property, jdk.xml.config.file, to return the path to a custom
> JAXP configuration file. The current configuration file, jaxp.properties,
> that the JDK supports will become the default configuration file.
>
> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>
> Tests: XML SQE an
> Please review this PR which adds the method `caseFoldLanguageTag(String
> languageTag)` to java.util.Locale.
>
> This method case folds a language tag to adhere to _[section 2.1.1.
> Formatting of Language Tags of
> RFC5646](https://www.rfc-editor.org/rfc/rfc5646.html#section-2.1)_. This
> f
On Tue, 2 May 2023 16:59:00 GMT, Aleksey Shipilev wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Throw StreamCorruptedException instead of InvalidClassException and handle
>> negative array size in checkArray()
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream. Instead it calls
> `j.l.r.Array::newInstance(..)` with the
On Tue, 2 May 2023 16:06:50 GMT, Aleksey Shipilev wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Throw StreamCorruptedException instead of InvalidClassException and handle
>> negative array size in checkArray()
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream. Instead it calls
> `j.l.r.Array::newInstance(..)` with the
On Tue, 2 May 2023 13:26:31 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization strea
On Tue, 2 May 2023 15:52:03 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Throw StreamCorruptedException instead of InvalidClassException and handle
>> negative array size in checkArray() as w
On Tue, 2 May 2023 14:05:03 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>>
>>> 83:
>>> 84: // Generates the Java Pseudo code for base64 encoded string
>>> that can be cut & pasted into the test
>>> 85: final StringBuil
On Tue, 2 May 2023 13:26:31 GMT, Volker Simonis wrote:
>> This issue was reported by: Yakov Shafranovich
>> ([yako...@amazon.com](mailto:yako...@amazon.com))
>>
>> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
>> negative array length in the deserialization strea
On Tue, 2 May 2023 14:24:39 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
> The `default` method `nextDouble(double origin, double bound)` in
> `java.util.random.RandomGenerator` aims at generating a uniformly and
> spatially equidistributed random `double` in the left-closed and right-open
> range [`origin`, `bound`). It does so by applying the affine transform
> `o
On Tue, 2 May 2023 14:35:22 GMT, Martin Doerr wrote:
> Do you have for more changes to wait for or would you prefer to have this PR
> integrated soon?
I don't have anything else in the pipeline at the moment.
> Off topic: I have read parts of the Big Endian ABI and we will need a
> solution f
On Tue, 2 May 2023 14:01:57 GMT, Jorn Vernee wrote:
> On another note, how are you coming along with finding another reviewer? I
> (still) think it would be good to get someone that is familiar with PPC
> (particularly the ABI) as a second reviewer.
Second Review is in progress. I have merged
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
1. Added JDK version in Data files.
2. Updated copyright year.
-
Changes:
- all: https://git.open
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Fri, 28 Apr 2023 18:43:32 GMT, Joe Wang wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 2:
>
>> 1: /*
On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>
>
On Tue, 2 May 2023 09:51:47 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
On Thu, 27 Apr 2023 12:59:33 GMT, Martin Doerr wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert unintended formatting changes. Fix comment.
>
> Adapted for JDK21, now. All tests have passed. My IDE had change
On Tue, 17 Jan 2023 15:55:40 GMT, Jan Lahoda wrote:
>> The pattern matching switches are using a bootstrap method
>> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch.
>> Basically, for a switch like:
>>
>> switch (obj) {
>> case String s when s.isEmpty() -> {}
>> case
On Tue, 11 Apr 2023 17:28:06 GMT, Jorn Vernee wrote:
> This patch adds a dedicated jtreg property to check which CABI is being used
> by the JDK, which can be used both to check whether the foreign linker is
> supported, and whether the fallback linker is being used. (and, possibly it
> can al
On Tue, 2 May 2023 13:07:37 GMT, Jorn Vernee wrote:
> I went with the `jdk.CABI -> jdk.foreign.linker` name change. Re-tested. Will
> integrate soon.
Looks good (if we wanted to be 100% explicit, then it would have been
jdk.foreign.system.linker/jdk.foreign.native.linker - but what you picked
Thanks both for responding! Re: DelayQueue peek() being special: you're right,
I missed that.
So my original proposal would not solve my problem.
I really want to "block until poll() would return non-null"
Let's pretend that's what blockingPeek() would do, though maybe the name is no
longer suit
On Tue, 2 May 2023 13:19:55 GMT, ExE Boss wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>> commits since th
On Thu, 27 Apr 2023 21:24:04 GMT, Roger Riggs wrote:
>> Volker Simonis has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commit
> This issue was reported by: Yakov Shafranovich
> ([yako...@amazon.com](mailto:yako...@amazon.com))
>
> Currently, `ObjectInputStream::readObject()` doesn't explicitly checks for a
> negative array length in the deserialization stream. Instead it calls
> `j.l.r.Array::newInstance(..)` with the
On Mon, 1 May 2023 14:56:27 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
> This patch adds a dedicated jtreg property to check which CABI is being used
> by the JDK, which can be used both to check whether the foreign linker is
> supported, and whether the fallback linker is being used. (and, possibly it
> can also be use to check for a particular ABI in case we want
On Mon, 1 May 2023 16:48:30 GMT, Jorn Vernee wrote:
>> This patch adds a dedicated jtreg property to check which CABI is being used
>> by the JDK, which can be used both to check whether the foreign linker is
>> supported, and whether the fallback linker is being used. (and, possibly it
>> can
On Tue, 18 Apr 2023 05:08:35 GMT, Yoshiki Sato wrote:
> Please review this PR.
> With this minor change, the javazic compiler (Main.java) can produce the HTML
> files that display given time zone data correctly.
This pull request has now been integrated.
Changeset: 544bd260
Author:Yoshik
On Mon, 1 May 2023 16:25:23 GMT, Julian Waters wrote:
> Windows no longer uses I64d anywhere in their newer compilers, instead using
> the conforming lld specifiers. Minor cleanup here in JLI code to reflect that
Is the globalDefinitions declaration what you're referring to? In any case, the
M
> Windows no longer uses I64d anywhere in their newer compilers, instead using
> the conforming lld specifiers. Minor cleanup here in JLI code to reflect that
Julian Waters has updated the pull request incrementally with one additional
commit since the last revision:
HotSpot should also use l
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
Agree; we should remove this validsince. I change PermittedSubclasses for
Record uses its release major version than its previ
On Fri, 28 Apr 2023 19:30:43 GMT, Neal Gafter wrote:
> Building a map or hash table will be faster than sequential search.
I agree it there will be usecases (and maybe even a majority of usecases) where
using some kind of hash-based structure would work better than this patch.
However, as Remi
On Tue, 2 May 2023 10:16:17 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 46 commits:
>>
>> - UNKNOWN -> UNSUPPORTED + fix TestLinker on FALLBACK
>> - Merge branch 'master' into
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
BootstrapMethods is a good catch, however I would rather recommend to remove
the `AttributeMapper::validSince` from the API co
On Wed, 15 Feb 2023 20:31:14 GMT, Brian Goetz wrote:
>> Strahinja Stanojevic has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove address from lambda class names in test on the 32-bit architecture
>> too
>
> David Llloyd's proposed so
On Mon, 1 May 2023 17:02:11 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/827
This pull request has now been integrated.
Changeset: 1532a1b0
Author:Jorn Vernee
URL:
https://git.openjdk.org/jdk/commit/1532a1b0bd72f37b77540af51368271ef80e17d2
Stats:
On Mon, 1 May 2023 16:48:30 GMT, Jorn Vernee wrote:
>> This patch adds a dedicated jtreg property to check which CABI is being used
>> by the JDK, which can be used both to check whether the foreign linker is
>> supported, and whether the fallback linker is being used. (and, possibly it
>> can
On Mon, 1 May 2023 16:48:30 GMT, Jorn Vernee wrote:
>> This patch adds a dedicated jtreg property to check which CABI is being used
>> by the JDK, which can be used both to check whether the foreign linker is
>> supported, and whether the fallback linker is being used. (and, possibly it
>> can
On Mon, 1 May 2023 17:02:11 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/827
Looks good (already reviewed on panama repo)
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13741#pullrequestreview-140881
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Mon, 1 May 2023 16:25:23 GMT, Julian Waters wrote:
> Windows no longer uses I64d anywhere in their newer compilers, instead using
> the conforming lld specifiers. Minor cleanup here in JLI code to reflect that
The VM still uses PRId64.
-
PR Review: https://git.openjdk.org/jdk/p
On Mon, 1 May 2023 14:56:27 GMT, Chen Liang wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
>> 2.
Hi,
I think the conversation also becomes a bit more difficult since the topic
seems to be around DelayQueue—which has slightly different semantics than
typical BlockingQueue implementations.
For instance, peek() returns the element with the lowest expiry (possibly in
the future)—so you cannot
On Tue, 2 May 2023 05:48:47 GMT, Jaikiran Pai wrote:
> The test was problem listed only in `-Xcomp` but it wasn't clear why this
> issue would affect only `-Xcomp`, but then reading through the JBS issue, I
> can see that this failure was reproduced even without `-Xcomp` after the
> problem li
On Sun, 30 Apr 2023 18:18:09 GMT, Alan Bateman wrote:
> HoldsLock.java#id0 has been failing intermittently recently due to threads
> left over from previous tests terminating. HoldsLock.java#id1 doesn't fail as
> it runs in /othervm mode. The test uses ThreadMXBean::getAllThreadIds to get
> th
74 matches
Mail list logo
