Re: RFR: 8304986: Upcall stubs should support capureCallState

2023-04-23 Thread ExE Boss
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be written.

Re: RFR: 8304986: Upcall stubs should support capureCallState

2023-04-23 Thread Jorn Vernee
On Fri, 21 Apr 2023 18:25:32 GMT, Jorn Vernee wrote: > Implement captureCallState support for upcall stubs. > > The method handle of an upcall stub linked with this linker option has an > additional leading memory segment parameter into which the capture state > (e.g. errno) should be written.

RFR: 8304986: Upcall stubs should support capureCallState

2023-04-23 Thread Jorn Vernee
Implement captureCallState support for upcall stubs. The method handle of an upcall stub linked with this linker option has an additional leading memory segment parameter into which the capture state (e.g. errno) should be written. After returning from Java, this value is then actually written

RFR: 8305201: Improve error message for GroupLayouts that are too large on SysV

2023-04-23 Thread Jorn Vernee
Using for instance a struct layout that contains an unbounded array will produce the exception from the JBS issue. This patch checks for the case where a GroupLayout is too large more explicitly, and reports the issue using a more informative exception. - Depends on: https://git.op

Re: RFR: 8306008: Several Vector API tests fail for client VM after JDK-8304450

2023-04-23 Thread Gui Cao
On Tue, 18 Apr 2023 12:21:11 GMT, Quan Anh Mai wrote: > Hi, > > Please review this patch which fixes the errors on machines where > TypeMaxVector has a length of 64 bits. I take an extra cautious approach and > fall back to putting elements one by one if the length is an unexpected value. > >

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of [v2]

2023-04-23 Thread Chen Liang
> Please review this patch adding two new convenience methods that allows > easier access to MethodTypeDesc instances and its associated CSR as well. > This is a necessity to allow #13186 to reduce array copies in a few > scenarios; the implementation of the two methods will be updated there. >

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-23 Thread Chen Liang
On Sun, 23 Apr 2023 21:09:32 GMT, ExE Boss wrote: >> Alternatively, we can switch to SequencedCollection when it's integrated. > > [`MethodType.methodType(…)`] also doesn’t allow plain `Collection`s for the  > same reason, even though `List.copyOf` supports creation from a `Collection`. > > [`Me

RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

2023-04-23 Thread Leonid Mesnik
ProcessTools.startProcess() creates process and read it's output error streams. So the any other using of corresponding Process.getInputStream() and Process.getErrorStream() doesn't get process streams. This fix preserve process streams content and allow to read reuse the date. The ByteArrayOut

RFR: JDK-8304423: Refactor FdLibm.java

2023-04-23 Thread Joe Darcy
Minor refactoring of FdLibm.java; will consider future refactorings with more substantive code changes in the future. - Commit messages: - JDK-8304423: Refactor Fdlibm.java Changes: https://git.openjdk.org/jdk/pull/13604/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13604

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-23 Thread ExE Boss
On Sun, 23 Apr 2023 16:33:46 GMT, Chen Liang wrote: >> No, this is what List.copyOf supports. > > Alternatively, we can switch to SequencedCollection when it's integrated. [`MethodType.methodType(…)`] also doesn’t allow plain `Collection`s for the  same reason, even though `List.copyOf` supports

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v6]

2023-04-23 Thread Laurent Bourgès
> * Optimized mixed insertion sort > * Optimized insertion sort > * Optimized Radix sort > * Updated microbenchmark > > I am going on previous PR by Vladimir Yaroslavskyi: > https://github.com/openjdk/jdk/pull/3938 Laurent Bourgès has updated the pull request with a new target base d

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-23 Thread Chen Liang
On Sun, 23 Apr 2023 13:13:55 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unify ofInternalName and internalName, document about CONSTANT_Class_info, >> remove misleading JVMS 4.4.1 links > > src/jav

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-23 Thread Chen Liang
On Sun, 23 Apr 2023 16:31:52 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/constant/MethodTypeDesc.java line 85: >> >>> 83: * @since 21 >>> 84: */ >>> 85: static MethodTypeDesc of(ClassDesc returnDesc, >>> Collection paramDescs) { >> >> This needs to be: >> Sugg

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-23 Thread Chen Liang
On Sun, 23 Apr 2023 13:06:34 GMT, ExE Boss wrote: >> Please review this patch adding two new convenience methods that allows >> easier access to MethodTypeDesc instances and its associated CSR as well. >> This is a necessity to allow #13186 to reduce array copies in a few >> scenarios; the imp

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v5]

2023-04-23 Thread Laurent Bourgès
> * Optimized mixed insertion sort > * Optimized insertion sort > * Optimized Radix sort > * Updated microbenchmark > > I am going on previous PR by Vladimir Yaroslavskyi: > https://github.com/openjdk/jdk/pull/3938 Laurent Bourgès has updated the pull request incrementally with one a

Re: RFR: 8306697: Add method to obtain String for CONSTANT_Class_info in ClassDesc [v2]

2023-04-23 Thread ExE Boss
On Sat, 22 Apr 2023 18:40:45 GMT, Chen Liang wrote: >> Add a method `internalName` to `ClassDesc`, and unifies handling of string >> representation of a class constant in CONSTANT_Class_info via >> `ofInternalName` and `internalName` APIs, documented in `ClassDesc` itself. >> In particular, `o

Re: RFR: 8306698: Add overloads to MethodTypeDesc::of

2023-04-23 Thread ExE Boss
On Sat, 22 Apr 2023 16:31:31 GMT, Chen Liang wrote: > Please review this patch adding two new convenience methods that allows > easier access to MethodTypeDesc instances and its associated CSR as well. > This is a necessity to allow #13186 to reduce array copies in a few > scenarios; the imple