Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread David Holmes
On Sun, 19 Mar 2023 15:20:33 GMT, Eirik Bjorsnos wrote: > > The discussion is also a reminder that -Djava.compiler=NONE is the > > equivalent of -Xint, I thought that system property was dropped a long time > > ago. > > https://bugs.openjdk.org/browse/JDK-8041676 suggests to deprecate it, but

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]

2023-03-19 Thread Leonid Mesnik
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote: >> `ModuleInfoWriter` is not used by the runtime. Move it to the test library >> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the >> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >>

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v2]

2023-03-19 Thread Quan Anh Mai
> Hi, > > This patch reimplements `VectorShuffle` implementations to be a vector of the > bit type. Currently, VectorShuffle is stored as a byte array, and would be > expanded upon usage. This poses several drawbacks: > > 1. Inefficient conversions between a shuffle and its corresponding vector

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. A search of 3M classes in 130k art

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v3]

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 14:38:46 GMT, Eirik Bjorsnos wrote: >> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 208: >> >>> 206: * >>> 207: * This ensures strict compliance with the ZIP specification and >>> 208: * allows optimal performance when processing director

Re: RFR: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics [v4]

2023-03-19 Thread Leonid Mesnik
On Fri, 17 Mar 2023 10:31:46 GMT, Serguei Spitsyn wrote: >> This is needed for future performance/scalability improvements in JVMTI >> support of virtual threads. >> The update includes the following: >> >> 1. Refactored the `VirtualThread` native methods: >> `notifyJvmtiMountBegin` and

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 15:08:58 GMT, Eirik Bjorsnos wrote: > The discussion is also a reminder that -Djava.compiler=NONE is the equivalent > of -Xint, I thought that system property was dropped a long time ago. https://bugs.openjdk.org/browse/JDK-8041676 suggests to deprecate it, but from the las

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 14:38:55 GMT, Alan Bateman wrote: > For reference, here's the discussion from 2016 when it was proposed to > deprecate j.l.Compiler, for removal. Tim Ellison from IBM engaged in that > discussion as one of the replies asked about applications running on the J9 > VM using th

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v3]

2023-03-19 Thread Eirik Bjorsnos
> ZipOutputStream currently writes directory entries using the DEFLATED > compression method. This does not strictly comply with the APPNOTE.TXT > specification and is also about 10x slower than using the STORED compression > method. > > Because of these concerns, `ZipOutputStream.putNextEntry`

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v2]

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 14:19:10 GMT, Eirik Bjorsnos wrote: >> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 198: >> >>> 196: * >>> 197: * {@snippet lang="java" : >>> 198: * ZipEntry e = ...; >> >> Please make this an actual value as the snippet should be va

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v2]

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 14:02:18 GMT, Lance Andersen wrote: > Also the copyright should be changed to 2023 with your next update. Imagine if jcheck could remind people of this, reviewers would be out of a job :-) > src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 208: > >> 206:

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v2]

2023-03-19 Thread Eirik Bjorsnos
> ZipOutputStream currently writes directory entries using the DEFLATED > compression method. This does not strictly comply with the APPNOTE.TXT > specification and is also about 10x slower than using the STORED compression > method. > > Because of these concerns, `ZipOutputStream.putNextEntry`

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. For reference, here's the discussi

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 13:50:40 GMT, Lance Andersen wrote: >> ZipOutputStream currently writes directory entries using the DEFLATED >> compression method. This does not strictly comply with the APPNOTE.TXT >> specification and is also about 10x slower than using the STORED compression >> method.

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

2023-03-19 Thread Lance Andersen
On Tue, 7 Mar 2023 07:46:25 GMT, Eirik Bjorsnos wrote: > ZipOutputStream currently writes directory entries using the DEFLATED > compression method. This does not strictly comply with the APPNOTE.TXT > specification and is also about 10x slower than using the STORED compression > method. > >

RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation

2023-03-19 Thread Quan Anh Mai
Hi, This patch reimplements `VectorShuffle` implementations to be a vector of the bit type. Currently, VectorShuffle is stored as a byte array, and would be expanded upon usage. This poses several drawbacks: 1. Inefficient conversions between a shuffle and its corresponding vector. This hinder

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The actual change in this PR seems

Re: RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

2023-03-19 Thread Eirik Bjorsnos
On Tue, 7 Mar 2023 07:46:25 GMT, Eirik Bjorsnos wrote: > ZipOutputStream currently writes directory entries using the DEFLATED > compression method. This does not strictly comply with the APPNOTE.TXT > specification and is also about 10x slower than using the STORED compression > method. > >

RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries

2023-03-19 Thread Eirik Bjorsnos
ZipOutputStream currently writes directory entries using the DEFLATED compression method. This does not strictly comply with the APPNOTE.TXT specification and is also about 10x slower than using the STORED compression method. Because of these concerns, `ZipOutputStream.putNextEntry` should be u

RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
Please help review this PR which suggests we remove the class `java.lang.Compiler`. The class seems non-functional for a decade, and was terminally deprecated in Java 9. Time has come to let it go. - Commit messages: - Remove the deprecated class java.lang.Compiler Changes: https:

Re: RFR: JDK-8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally [v6]

2023-03-19 Thread Alan Bateman
On Fri, 17 Mar 2023 09:52:51 GMT, Viktor Klang wrote: >> Addresses the situation where exceptional completion of `orTimeout`:ed >> CompletableFutures wouldn't cancel the timeout task which could lead to >> memory leaks if done frequently enough with long enough timeout durations. >> >> Fix dis

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v8]

2023-03-19 Thread Alan Bateman
On Sat, 18 Mar 2023 13:28:52 GMT, Jaikiran Pai wrote: >>> `Platform::parsePlatform` is the utility method to parse `ModuleTarget`. It >>> can be updated to include additional architectures. >> >> Alternatively, don't parse it. If we go with Jim's suggestion of a resource >> file then it is jus

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]

2023-03-19 Thread Alan Bateman
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote: >> `ModuleInfoWriter` is not used by the runtime. Move it to the test library >> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the >> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >>