Re: RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v4]

2023-03-11 Thread liach
On Fri, 10 Mar 2023 16:46:35 GMT, Glavo wrote: > The Classfile API looks great. I want to ask if you have any plans to > completely replace all uses of `jdk.internal.org.objectweb.asm` and delete > its source code from OpenJDK in a short time? I guess yes. https://bugs.openjdk.org/browse/JDK-8

Integrated: 8303922: build-test-lib target is broken

2023-03-11 Thread Eirik Bjorsnos
On Thu, 9 Mar 2023 20:09:46 GMT, Eirik Bjorsnos wrote: > The Make target 'build-test-lib-target' is broken in a few ways: > > - make/test/BuildTestLib.gmk references the directory > $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by > removing the reference. > - Some

Re: RFR: 8303922: build-test-lib target is broken

2023-03-11 Thread Julian Waters
On Thu, 9 Mar 2023 20:09:46 GMT, Eirik Bjorsnos wrote: > The Make target 'build-test-lib-target' is broken in a few ways: > > - make/test/BuildTestLib.gmk references the directory > $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by > removing the reference. > - Some

Re: RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v4]

2023-03-11 Thread Alan Bateman
On Fri, 10 Mar 2023 19:30:45 GMT, Mandy Chung wrote: >> The ModulePackages attribute is optional and an optimization to avoid >> scanning the module contents to get the full set of packages. Tooling that >> creates packaged modules (jar and jmod for now) will want the ModulePackages >> attribu

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2023-03-11 Thread liach
On Fri, 10 Mar 2023 08:48:14 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes and this patch converts it to use Classfile API. >> >> Please review. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request with a new target

Re: RFR: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline) [v2]

2023-03-11 Thread Jorn Vernee
> Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the > sharing mechanism for upcall stubs to AbstractLinker. > > This also speeds up upcall stub linking: Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Remov

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v4]

2023-03-11 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launche

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v3]

2023-03-11 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launche

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v2]

2023-03-11 Thread Jaikiran Pai
On Sat, 11 Mar 2023 10:40:19 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated imag

Re: RFR: 8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture

2023-03-11 Thread Jaikiran Pai
On Fri, 20 Jan 2023 14:23:13 GMT, Jaikiran Pai wrote: > Right now the ModuleTarget class file attribute is not enough but a short > term fix might be for jlink to have a simple mapping of known ModuleTarget > values to endianness. Overall, it's probably low priority as the most likely > users

Re: RFR: 8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture [v2]

2023-03-11 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launche

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v6]

2023-03-11 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl

Re: RFR: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

2023-03-11 Thread Andrey Turbanov
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the > sharing mechanism for upcall stubs to AbstractLinker. > > This also speeds up upcall stub linking: src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/w