Re: RFR: 8303530: Add system property for custom JAXP configuration file [v2]

2023-03-10 Thread Joe Wang
> Add a system property, jdk.xml.config.file, to return the path to a custom > JAXP configuration file. The current configuration file, jaxp.properties, > that the JDK supports will become the default configuration file. > > CSR: https://bugs.openjdk.org/browse/JDK-8303531 > > Tests: XML SQE an

RFR: 8284871: Use covariant overrides for the resolveConstantDesc(Lookup) method in sub‑interfaces of java.lang.constant.ConstantDesc

2023-03-10 Thread liach
Also remove redundant casts to avoid javac warnings. - Commit messages: - Move MethodTypeDesc api notes to MethodTypeDesc - Merge branch 'master' of https://git.openjdk.java.net/jdk into constdesc-override - Remove redundant casts - Covariant override of resolveConstantDesc for

Integrated: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-10 Thread Feilong Jiang
On Thu, 9 Mar 2023 14:39:55 GMT, Feilong Jiang wrote: > [JDK-8303604](https://bugs.openjdk.org/browse/JDK-8303604) fixes an issue > with passing structs whose size is not a power of two on SysV and AArch64 > platforms. The same issue happens on RISC-V. > > Modifications are unnecessary for `ST

RFR: 8303530: Add system property for custom JAXP configuration file

2023-03-10 Thread Joe Wang
Add a system property, jdk.xml.config.file, to return the path to a custom JAXP configuration file. The current configuration file, jaxp.properties, that the JDK supports will become the default configuration file. CSR: https://bugs.openjdk.org/browse/JDK-8303531 Tests: XML SQE and JCK tests pa

RFR: 8288730: Lookup::accessClass(Class) should be generic on the type of `targetClass`

2023-03-10 Thread liach
Parameterizes `Lookup::accessClass` and `Lookup::ensureInitialized`. Updated an applicable use-site within JDK to benefit from this patch. - Commit messages: - update use sites - 8288730: `Lookup::accessClass(Class)` should be generic on the type of `targetClass` Changes: https:/

Re: RFR: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-10 Thread Feilong Jiang
On Thu, 9 Mar 2023 15:07:55 GMT, Jorn Vernee wrote: >> [JDK-8303604](https://bugs.openjdk.org/browse/JDK-8303604) fixes an issue >> with passing structs whose size is not a power of two on SysV and AArch64 >> platforms. The same issue happens on RISC-V. >> >> Modifications are unnecessary for

Re: RFR: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-10 Thread Fei Yang
On Thu, 9 Mar 2023 14:39:55 GMT, Feilong Jiang wrote: > [JDK-8303604](https://bugs.openjdk.org/browse/JDK-8303604) fixes an issue > with passing structs whose size is not a power of two on SysV and AArch64 > platforms. The same issue happens on RISC-V. > > Modifications are unnecessary for `ST

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-10 Thread Jorn Vernee
On Thu, 9 Mar 2023 17:40:02 GMT, Martin Doerr wrote: >> @TheRealMDoerr I've moved the support for structs/unions that are not a >> power of 2 in size to this repo, so you should be able to merge the master >> branch to get it now. > > @JornVernee: Thanks! I've merged in your changes. TestArrayS

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-03-10 Thread Jorn Vernee
On Fri, 3 Mar 2023 10:59:32 GMT, Martin Doerr wrote: >> Thanks! I need to find extra time for this. Sounds like a good idea and I >> may be able to get rid of some nasty code. > > Done by > https://github.com/openjdk/jdk/pull/12708/commits/98e242c24c07ea977b7709b9f8d0c10ce87e84c0 > (using a re

Integrated: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

2023-03-10 Thread Alexander Matveev
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote: > - Fixed by increasing test timeout. Fix verified on host which reproduced > issue. This pull request has now been integrated. Changeset: 0a4d54f7 Author:Alexander Matveev URL: https://git.openjdk.org/jdk/commit/0a4d54f7ce2

Re: RFR: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

2023-03-10 Thread Alexey Semenyuk
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote: > - Fixed by increasing test timeout. Fix verified on host which reproduced > issue. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12896

Re: RFR: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

2023-03-10 Thread Alexey Semenyuk
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote: > - Fixed by increasing test timeout. Fix verified on host which reproduced > issue. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12896

Re: RFR: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle [v3]

2023-03-10 Thread Vladimir Kozlov
On Fri, 10 Mar 2023 14:14:55 GMT, Jorn Vernee wrote: >> The issue is that the size of the code buffer is not large enough to hold >> the whole stub. >> >> Proposed solution is to scale the size of the stub with the number of >> arguments. I've adjusted sizes for both downcall and upcall stubs.

Re: RFR: 8303917: Update ISO 639 language codes table

2023-03-10 Thread Naoto Sato
On Fri, 10 Mar 2023 17:27:11 GMT, Justin Lu wrote: > This PR modifies `java.util.LocaleISOData.isoLanguageTable` to include (name > only) changes from up-to-date [ISO 639 > data](http://www.loc.gov/standards/iso639-2/php/code_list.php.). > > In addition, this PR updates the ISO 639 data (gener

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 12:45:05 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target base due to a > merge or a rebas

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Roger Riggs
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 12:45:05 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target base due to a > merge or a rebas

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v6]

2023-03-10 Thread Roger Riggs
> Runtime.exec and ProcessBuilder.start methods create a new operating system > process with the program and arguments. Many applications configure a logging > subsystem to monitor application events. Logging a process start message with > the program, arguments, and stack trace can identify the

Re: RFR: 8303485: Replacing os.name for operating system customization [v2]

2023-03-10 Thread Roger Riggs
> Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - Simple API to replace adhoc comparisons with `os.name`

Re: RFR: 8303648: Add String.indexOf(String str, int beginIndex, int endIndex) [v2]

2023-03-10 Thread Roger Riggs
On Fri, 10 Mar 2023 13:35:27 GMT, Raffaello Giulietti wrote: >> As a followup of [JDK-8302590](https://bugs.openjdk.org/browse/JDK-8302590), >> this issue covers the analogous case for a search of a string rather than a >> character. > > Raffaello Giulietti has updated the pull request increme

Re: RFR: 8303891: Zip64SizeTest could use a sparse file [v4]

2023-03-10 Thread Eirik Bjorsnos
> This PR suggests we use a sparse file when the Zip64SizeTest writes a ZIP > file with a 5GB entry. > > The size requirement of this test is known to cause problems in some builds, > see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866) > > Using a sparse file reduces the disk space r

Re: RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 17:59:20 GMT, Alan Bateman wrote: >> It'd be helpful to add a comment that `ModulePackages` attribute is only >> emitted if there are packages that aren't exported or open. > > The ModulePackages attribute is optional and an optimization to avoid > scanning the module conten

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v4]

2023-03-10 Thread Alan Bateman
On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote: >> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incremen

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 14:01:04 GMT, Alan Bateman wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS)

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v4]

2023-03-10 Thread Alan Bateman
On Thu, 9 Mar 2023 17:59:55 GMT, Mandy Chung wrote: >> Yes, `Classfile::buildModule` contains logic determining if emission of >> `ModulePackages` is required or not. > > It'd be helpful to add a comment that `ModulePackages` attribute is only > emitted if there are packages that aren't exporte

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v5]

2023-03-10 Thread Sean Mullan
On Fri, 10 Mar 2023 15:27:54 GMT, Roger Riggs wrote: >> Runtime.exec and ProcessBuilder.start methods create a new operating system >> process with the program and arguments. Many applications configure a >> logging subsystem to monitor application events. Logging a process start >> message wi

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 07:51:55 GMT, Adam Sotona wrote: >> make/modules/jdk.jartool/Java.gmk line 28: >> >>> 26: DISABLED_WARNINGS_java += missing-explicit-ctor >>> 27: JAVAC_FLAGS += -XDstringConcat=inline >>> 28: JAVAC_FLAGS += --enable-preview >> >> This change is no longer needed. It's not a

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 12:31:22 GMT, Adam Sotona wrote: >> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar >> entries >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target ba

Integrated: 8303853: Update ISO 3166 country codes table

2023-03-10 Thread Justin Lu
On Thu, 9 Mar 2023 17:50:32 GMT, Justin Lu wrote: > This PR incorporates all of the missing updates to ensure that > `java.util.LocaleISOData.isoCountryTable` is on par with the official [ISO > 3166 data](https://www.iso.org/obp/ui/#search/code/). This pull request has now been integrated. Ch

Integrated: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF

2023-03-10 Thread Justin Lu
On Wed, 8 Mar 2023 22:02:22 GMT, Justin Lu wrote: > This PR removes the JNI Exception pending defect groups in ClassLoader.c. > > `getUTF()` throws an exception and subsequently returns `null`; the exception > should either be cleared, or control returned to the JVM. > `JNU_ThrowOutOfMemoryEr

RFR: 8303917: Update ISO 639 language codes table

2023-03-10 Thread Justin Lu
This PR modifies `java.util.LocaleISOData.isoLanguageTable` to include (name only) changes from up-to-date [ISO 639 data](http://www.loc.gov/standards/iso639-2/php/code_list.php.). In addition, this PR updates the ISO 639 data (generated in 1999) in `Bug4175998Test.java`. This includes modifyin

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v4]

2023-03-10 Thread Glavo
On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote: >> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incremen

Integrated: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask

2023-03-10 Thread Viktor Klang
On Tue, 31 Jan 2023 10:57:58 GMT, Viktor Klang wrote: > I noticed when looking at the code that there was no real need to use a CHM > to perform the tracking of activation in an ordered fashion on > ForEachOrderedTask, but instead a VarHandle can be used, reducing allocations > and indirection

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v5]

2023-03-10 Thread Roger Riggs
> Runtime.exec and ProcessBuilder.start methods create a new operating system > process with the program and arguments. Many applications configure a logging > subsystem to monitor application events. Logging a process start message with > the program, arguments, and stack trace can identify the

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v3]

2023-03-10 Thread Thomas Stuefe
On Fri, 10 Mar 2023 15:11:50 GMT, Roger Riggs wrote: >> test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java line 81: >> >>> 79: File nullDirectory = null; >>> 80: File thisDirectory = new File("."); >>> 81: >> >> I started to heavily use different `@test` sections wi

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v3]

2023-03-10 Thread Roger Riggs
On Thu, 9 Mar 2023 20:24:11 GMT, Thomas Stuefe wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revise logging of ProcessBuilder.start to support DEBUG and TRACE logging. >> Revise the implNote to include a warning

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Fri, 10 Mar 2023 14:28:09 GMT, liach wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into JDK-8

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v4]

2023-03-10 Thread Adam Sotona
> 8294962: java.base jdk.internal.module package uses ASM to modify and write > module-info.class. > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: Mod

Set thread names for threads created sun.nio.ch.AsynchronousChannelGroupImpl#startInternalThread

2023-03-10 Thread Andrey Turbanov
Hello. I've noticed that in the method sun.nio.ch.AsynchronousChannelGroupImpl#startInternalThread JDK code creates threads with default names (Thread-1, Thread-2, etc). It's a good practice to set meaning thread names instead of default ones to simplify debugging and troubleshooting. I wonder if c

Integrated: 8303001: Add test for re-entrant upcalls

2023-03-10 Thread Jorn Vernee
On Wed, 8 Mar 2023 15:51:05 GMT, Jorn Vernee wrote: > Add a test that tests re-entrant upcalls, which is a use-case that is > uncovered by testing until now. This pull request has now been integrated. Changeset: 6d30bbe6 Author:Jorn Vernee URL: https://git.openjdk.org/jdk/commit/6d

Re: RFR: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

2023-03-10 Thread Feilong Jiang
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the > sharing mechanism for upcall stubs to AbstractLinker. > > This also speeds up upcall stub linking: I'll submit a test on RISC-V board to see the results. It may

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread liach
On Fri, 10 Mar 2023 08:46:16 GMT, Adam Sotona wrote: >> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a n

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Justin King
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - S

Re: RFR: 8303891: Zip64SizeTest could use a sparse file [v3]

2023-03-10 Thread Eirik Bjorsnos
> This PR suggests we use a sparse file when the Zip64SizeTest writes a ZIP > file with a 5GB entry. > > The size requirement of this test is known to cause problems in some builds, > see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866) > > Using a sparse file reduces the disk space r

Re: RFR: 8303922: build-test-lib target is broken

2023-03-10 Thread Erik Joelsson
On Thu, 9 Mar 2023 20:09:46 GMT, Eirik Bjorsnos wrote: > The Make target 'build-test-lib-target' is broken in a few ways: > > - make/test/BuildTestLib.gmk references the directory > $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by > removing the reference. > - Some

Re: RFR: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle [v2]

2023-03-10 Thread Jorn Vernee
On Thu, 9 Mar 2023 06:39:47 GMT, Feilong Jiang wrote: >> @vnkozlov Yes, this is true. The only other existing port of this code is >> RISCV. However, to fix that port properly, someone needs to repeat the >> experiment on RISCV in order to figure out what the base size and the size >> per argu

Re: RFR: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

2023-03-10 Thread Jorn Vernee
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the > sharing mechanism for upcall stubs to AbstractLinker. > > This also speeds up upcall stub linking: @feilongjiang since this contains changes to the RISCV code as

Re: RFR: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle [v3]

2023-03-10 Thread Jorn Vernee
> The issue is that the size of the code buffer is not large enough to hold the > whole stub. > > Proposed solution is to scale the size of the stub with the number of > arguments. I've adjusted sizes for both downcall and upcall stubs. I've also > dropped the number of relocations, since we're

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Alan Bateman
On Fri, 10 Mar 2023 02:43:15 GMT, David Holmes wrote: >> Names and branding have changed over the years. >> It may be prudent to remove the name entirely and stick to a 'generic' >> identification of the OS as the Enum name. > > The current branding is "macOS" and we made a lot of changes in va

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Alan Bateman
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote: > Improvements to support OS specific customization for JDK internal use: > - To select values and code; allowing elimination of unused code and values > - Optionally evaluated by build processes, compilation, or archiving (i.e. > CDS) > - S

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Alan Bateman
On Fri, 10 Mar 2023 00:08:57 GMT, Justin King wrote: > Has this totally killed of BSD support on the JDK side? I thought building > non-macOS BSD was still viable, but perhaps not - certainly not after this > change. The macOS port in 7u4 was based on a BSD port and there was a time when it wa

Re: RFR: 8303648: Add String.indexOf(String str, int beginIndex, int endIndex) [v2]

2023-03-10 Thread Raffaello Giulietti
On Fri, 10 Mar 2023 12:52:21 GMT, Alan Bateman wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8303648: Add String.indexOf(String str, int beginIndex, int endIndex) >> >> Moved @apiNote on indexOf(Strin

Re: RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v44]

2023-03-10 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation a

Re: RFR: 8303648: Add String.indexOf(String str, int beginIndex, int endIndex) [v2]

2023-03-10 Thread Raffaello Giulietti
> As a followup of [JDK-8302590](https://bugs.openjdk.org/browse/JDK-8302590), > this issue covers the analogous case for a search of a string rather than a > character. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8303648

Re: RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v2]

2023-03-10 Thread Adam Sotona
On Fri, 10 Mar 2023 12:58:25 GMT, Jan Lahoda wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 193 commits: >> >> - Merge branch 'master' into JDK-8294974-jshell >> - Merge branch 'master' into JDK-8294974-js

Re: RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v4]

2023-03-10 Thread Adam Sotona
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to > instrument classes > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixe

Re: RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v3]

2023-03-10 Thread Jan Lahoda
On Fri, 10 Mar 2023 12:35:31 GMT, Adam Sotona wrote: >> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to >> instrument classes >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a ne

Re: RFR: 8303648: Add String.indexOf(String str, int beginIndex, int endIndex)

2023-03-10 Thread Alan Bateman
On Tue, 7 Mar 2023 14:44:32 GMT, Raffaello Giulietti wrote: > As a followup of [JDK-8302590](https://bugs.openjdk.org/browse/JDK-8302590), > this issue covers the analogous case for a search of a string rather than a > character. src/java.base/share/classes/java/lang/String.java line 2626: >

Re: RFR: 8294972: jdk.jlink internal plugins are heavily using ASM [v4]

2023-03-10 Thread Adam Sotona
> jdk.jlink internal plugins are heavily using ASM > > This patch converts ASM calls to Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 208 commits: - Merge branch 'mas

Re: RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v3]

2023-03-10 Thread Adam Sotona
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to > instrument classes > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now c

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v4]

2023-03-10 Thread Adam Sotona
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar > entries > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 199

Re: ZIP entry copy without recompression

2023-03-10 Thread Lance Andersen
Morning Eirik, Thank you Sean for creating the CR. As of this week, Eirik has author status so he can now create JBS issues 😊 I believe Jai is going to follow up with you has he started down a similar path earlier this week looking into a jarsigner issue. So please coordinate to avoid duplica

Re: ZIP entry copy without recompression

2023-03-10 Thread Seán Coffey
I think that's a fine idea Eirik. Definitely has its use cases like you mention. Some jarsigner operations would also benefit from this. I've created https://bugs.openjdk.org/browse/JDK-8303960 to track it. regards, Sean. On 31/01/2023 23:41, Lance Andersen wrote: I have not add a chance to

Re: RFR: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask [v6]

2023-03-10 Thread Viktor Klang
On Thu, 9 Mar 2023 16:05:32 GMT, Paul Sandoz wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary cast of argument to VarHandle getAndSet > > Marked as reviewed by psandoz (Reviewer). @PaulSandoz P

Integrated: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 11:33:13 GMT, Adam Sotona wrote: > jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes > > This patch converts ASM calls to Classfile API. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: b1d89f30 Author:Adam

Re: RFR: 8294959: java.base java.lang.Module uses ASM to load module-info.class

2023-03-10 Thread Eirik Bjorsnos
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote: > java.base java.lang.Module uses ASM to load module-info.class and this patch > converts it to use Classfile API. > It has been fixed by #12957 🤦 - PR: https://git.openjdk.org/jdk/pull/11367

Re: RFR: 8294959: java.base java.lang.Module uses ASM to load module-info.class

2023-03-10 Thread Adam Sotona
On Fri, 10 Mar 2023 09:16:03 GMT, Eirik Bjorsnos wrote: > This PR seems to have broken `make docs` It has been fixed by https://github.com/openjdk/jdk/pull/12957 - PR: https://git.openjdk.org/jdk/pull/11367

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 09:15:30 GMT, Jaikiran Pai wrote: > This now looks good to me. Thanks for taking time to do this thorough review and especially for running the regressing case. Much appreciated! I'll wait for a second review before integrating. - PR: https://git.openjdk.org/j

Re: RFR: 8294959: java.base java.lang.Module uses ASM to load module-info.class

2023-03-10 Thread Eirik Bjorsnos
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote: > java.base java.lang.Module uses ASM to load module-info.class and this patch > converts it to use Classfile API. This PR seems to have broken `make docs`: Generating JDK_API javadoc for 60 modules src/java.base/share/classes/java/lang/Mod

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Jaikiran Pai
On Fri, 10 Mar 2023 08:48:00 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 18:19:17 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> FingerPrint.maybeNestedClass set final > > src/jdk.jartool/share/classes/sun/tools/jar/FingerPrint.java line 252: > >> 25

Re: RFR: 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar entries [v3]

2023-03-10 Thread Adam Sotona
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar > entries > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: FingerPrint.may

Re: RFR: 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to instrument classes [v2]

2023-03-10 Thread Adam Sotona
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to > instrument classes > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now c

Re: RFR: 8294961: java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes [v6]

2023-03-10 Thread Adam Sotona
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes > and this patch converts it to use Classfile API. > > Please review. > > Thank you, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v4]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 08:28:37 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 22:05:55 GMT, Uwe Schindler wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' int

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v2]

2023-03-10 Thread Alan Bateman
On Fri, 10 Mar 2023 07:10:11 GMT, Adam Sotona wrote: >> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incremen

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
> 8294962: java.base jdk.internal.module package uses ASM to modify and write > module-info.class. > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 18:36:05 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 19:41:28 GMT, liach wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into JDK-82

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 08:14:56 GMT, Jaikiran Pai wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use "Signatureless" consistently > > test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 2: > >> 1: /* >

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v4]

2023-03-10 Thread Jaikiran Pai
On Fri, 10 Mar 2023 08:28:37 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v4]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Jaikiran Pai
On Fri, 10 Mar 2023 08:06:58 GMT, Eirik Bjorsnos wrote: >> Please review this PR which brings the DataDescriptorSignatureMissing test >> back to life. >> >> This test currently calls out to Python to create a test vector ZIP with a >> Data Descriptor without the recommended but optional signa

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v4]

2023-03-10 Thread Alan Bateman
On Fri, 10 Mar 2023 00:01:51 GMT, Roger Riggs wrote: >> Runtime.exec and ProcessBuilder.start methods create a new operating system >> process with the program and arguments. Many applications configure a >> logging subsystem to monitor application events. Logging a process start >> message wi

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Daniel Jeliński
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 9 Mar 2023 00:17:42 GMT, Naoto Sato wrote:

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2]

2023-03-10 Thread Eirik Bjorsnos
> Please review this PR which brings the DataDescriptorSignatureMissing test > back to life. > > This test currently calls out to Python to create a test vector ZIP with a > Data Descriptor without the recommended but optional signature. The Python > dependency has turned out to be very brittl

Re: RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v2]

2023-03-10 Thread Eirik Bjorsnos
On Fri, 10 Mar 2023 07:47:05 GMT, Jaikiran Pai wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove reference to python in the @summary of >> DataDescriptorSignatureMissing > > test/jdk/java/util/zip/DataDescr