Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-04 Thread Joe Darcy
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I > thought I'd get out for the review the next phase of the FDLIBM port: > removing the FDLIBM C sources from the repo. > > A repo with the changes for JDK-8302027 and this PR successful build on the > default set of

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

2023-03-04 Thread Thomas Stuefe
On Sat, 4 Mar 2023 14:22:33 GMT, Roger Riggs wrote: >> Runtime.exec and ProcessBuilder.start methods create a new operating system >> process with the program and arguments. Many applications configure a >> logging subsystem to monitor application events. Logging a process start >> message wit

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v6]

2023-03-04 Thread Joe Darcy
> Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is being used rather than a > different one. However, I w

Integrated: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-04 Thread Joe Darcy
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is bei

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v4]

2023-03-04 Thread Raffaello Giulietti
On Sat, 4 Mar 2023 05:14:54 GMT, Joe Darcy wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more tests. > >> > > Added tests cases where the different implementation of trig function T > differ in at least one i

Re: RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

2023-03-04 Thread Roger Riggs
> Runtime.exec and ProcessBuilder.start methods create a new operating system > process with the program and arguments. Many applications configure a logging > subsystem to monitor application events. Logging a process start message with > the program, arguments, and stack trace can identify the

Re: Testing no memory leak occurs via references

2023-03-04 Thread Thomas Schatzl
Hi, On 03.03.23 19:02, Aleksei Ivanov wrote: > Hello, > > In clientlibs, there's occasionally a need to verify an object isn't > leaked. For this purpose, WeakReference or PhantomReference is used. > > Then, we need to make the reference object be cleared, so a GC cycle > need to be triggered. Th

Re: RFR: 8302987: Add uniform and spatially equidistributed bounded float/double streams to RandomGenerator [v5]

2023-03-04 Thread Raffaello Giulietti
> The `default` method `nextDouble(double origin, double bound)` in > `java.util.random.RandomGenerator` aims at generating a uniformly and > spatially equidistributed random `double` in the left-closed and right-open > range [`origin`, `bound`). It does so by applying the affine transform > `o