On Sun, 19 Feb 2023 08:28:37 GMT, Ravali Yatham wrote:
> Added specific class loader object to proxy IllegalArgumentException from
> which the class was not visible
>
> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
src/java.base/share/classes/java/lang/reflect/Proxy.
On Wed, 22 Feb 2023 00:50:39 GMT, Martin Buchholz wrote:
>> More history: IIRC I originally used 'ASCII trick' when I was truly only
>> cared about ASCII, not Latin1 (e.g. ZipFile.isMetaName) and it's a slight
>> misnomer to use "ASCII" here. But Latin1 followed the precedent of ASCII.
>
>> Do
> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
> 'the oldest ASCII trick in the book'.
>
> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
> latin1 bytes for equality ignoring case. `StringLatin1.regionMatchesCI` is
> updated to use `equa
Description will get added soon.
-
Commit messages:
- Initial Panama implementation.
Changes: https://git.openjdk.org/jdk/pull/12708/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12708&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8303040
Stats: 1973 lines in 58
On Fri, 17 Feb 2023 09:01:23 GMT, Alan Bateman wrote:
>maybe change the loop to only test levels 0-9 and see if it passes?
`initial size: 525312`
error I'm facing is on level 1 not on -1.
level:1, strategy: 0, dowrap: false
required size: 553018 <- there is an issue
required size: 283432
On Wed, 22 Feb 2023 04:03:02 GMT, David Holmes wrote:
> I'm also a bit concerned that we are rushing in to "fix" this. IIUC we have
> three mechanisms for implementing this functionality:
>
> 1. The interpreted Java code
>
> 2. The compiled non-intrinisc sharedRuntime code
>
> 3.
On Wed, 22 Feb 2023 02:08:27 GMT, Sandhya Viswanathan
wrote:
> Change the java/lang/float.java and the corresponding shared runtime constant
> expression evaluation to generate QNaN.
> The HW instructions generate QNaNs and not SNaNs for floating point
> instructions. This happens across doubl
On Wed, 22 Feb 2023 03:46:42 GMT, Joe Darcy wrote:
> I'd like to see a more informative description of the problem:
>
> "float16 NaN values handled differently with and without intrinsification"
>
> If that is issue reported, it may not be a problem as opposed to
>
> "incorrect value returned
On Wed, 22 Feb 2023 02:08:27 GMT, Sandhya Viswanathan
wrote:
> Change the java/lang/float.java and the corresponding shared runtime constant
> expression evaluation to generate QNaN.
> The HW instructions generate QNaNs and not SNaNs for floating point
> instructions. This happens across doubl
On Wed, 22 Feb 2023 02:08:27 GMT, Sandhya Viswanathan
wrote:
> Change the java/lang/float.java and the corresponding shared runtime constant
> expression evaluation to generate QNaN.
> The HW instructions generate QNaNs and not SNaNs for floating point
> instructions. This happens across doubl
Change the java/lang/float.java and the corresponding shared runtime constant
expression evaluation to generate QNaN.
The HW instructions generate QNaNs and not SNaNs for floating point
instructions. This happens across double, float, and float16 data types. The
most significant bit of mantissa
On Wed, 22 Feb 2023 00:45:52 GMT, Martin Buchholz wrote:
>> There are still some books on this :) but from wikipedia:
>>> during May 1963 the CCITT Working Party on the New Telegraph Alphabet
>>> proposed to assign lowercase characters to
>>> sticks[[a]](https://en.wikipedia.org/wiki/ASCII#cite
On Wed, 22 Feb 2023 00:06:51 GMT, David Holmes wrote:
>> Thanks Martin, I will from now on envision a stack of dusty punch cards with
>> carefully scribbled notes on the back, barely held together with a dry and
>> cracked rubber band.
>>
>> More to the point: Do you have an opinion on the app
On Tue, 21 Feb 2023 23:28:52 GMT, Eirik Bjorsnos wrote:
>> More to the point, ASCII was obviously **designed** to allow you to
>> uppercase a lower case letter with a single instruction, so "the book" might
>> have been a draft standard before they scrubbed out the interesting history!
>
> Than
On Thu, 9 Feb 2023 18:11:18 GMT, Volker Simonis wrote:
>> Prior to
>> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
>> LambdaMetaFactory has created VM-anonymous classes which could easily be
>> unloaded once they were not
On Sun, 19 Feb 2023 16:12:39 GMT, liach wrote:
>> Added specific class loader object to proxy IllegalArgumentException from
>> which the class was not visible
>>
>> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
>
> src/java.base/share/classes/java/lang/reflect/Proxy.j
On Sun, 19 Feb 2023 08:28:37 GMT, Ravali Yatham wrote:
> Added specific class loader object to proxy IllegalArgumentException from
> which the class was not visible
>
> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
src/java.base/share/classes/java/lang/reflect/Proxy.
On Sun, 19 Feb 2023 08:28:37 GMT, Ravali Yatham wrote:
> Added specific class loader object to proxy IllegalArgumentException from
> which the class was not visible
>
> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
This contribution is on behalf of my employer, IBM,
Added specific class loader object to proxy IllegalArgumentException from which
the class was not visible
The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791
-
Commit messages:
- Added specific ClassLoader object to Proxy IllegalArgumentException
Changes: http
On Tue, 21 Feb 2023 23:20:03 GMT, Martin Buchholz wrote:
>> "oldest trick in the book" is a phrase that does not necessarily imply
>> existence of an actual book!
>>
>> Let this evoke an image of a **personal** book of tricks that programmers in
>> the 1960s might have recorded such techniques
On Tue, 21 Feb 2023 20:48:04 GMT, Martin Buchholz wrote:
>> Perhaps @Martin-Buchholz could chime in and also tell us which book he found
>> his ASCII trick in :)
>
> "oldest trick in the book" is a phrase that does not necessarily imply
> existence of an actual book!
>
> Let this evoke an imag
On Fri, 17 Feb 2023 19:33:07 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/FdLibm.java line 458:
>>
>>> 456: case 0, 1 -> y; // atan(+/-0, +anything)
>>> = +/-0
>>> 457: case 2-> Math.PI + tiny; // atan(+0, -anything)
>>>
On Fri, 17 Feb 2023 14:18:25 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commi
> Working down the porting list, next stop, atan2.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12608/files
- new: https://git.openjdk.or
> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
> 'the oldest ASCII trick in the book'.
>
> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
> latin1 bytes for equality ignoring case. `StringLatin1.regionMatchesCI` is
> updated to use `equa
> This is an approach to adding a flag to jlink that will allow --compress to
> take the same types of arguments as jmod, thus bringing the two into
> alignment. This likely requires a CSR and a discussion on whether we should
> deprecate or simply remove the original numeric compression argumen
On Tue, 21 Feb 2023 18:39:31 GMT, Volker Simonis wrote:
>> Volker Simonis has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove assertions which insist on Lambda proxy classes being strongly
>> linked to their class loader
>> - Remo
On Tue, 21 Feb 2023 14:22:30 GMT, Alan Bateman wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove whitespace following '('
>
> src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line
> 1
> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
> 'the oldest ASCII trick in the book'.
>
> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
> latin1 bytes for equality ignoring case. `StringLatin1.regionMatchesCI` is
> updated to use `equa
On Tue, 21 Feb 2023 21:41:29 GMT, Eirik Bjorsnos wrote:
> Thanks for the quick turnaround Naoto. I'll find a suitable way to punish
> myself for this one!
Thanks for the quick fix 🙂
-
PR: https://git.openjdk.org/jdk/pull/12701
On Tue, 21 Feb 2023 21:27:08 GMT, Eirik Bjorsnos wrote:
> The last commit to #12623 introduced a compilation error caused by an extra
> semicolon. This PR fixes this.
This pull request has now been integrated.
Changeset: e950b954
Author:Eirik Bjorsnos
Committer: Naoto Sato
URL:
ht
On Tue, 21 Feb 2023 21:27:08 GMT, Eirik Bjorsnos wrote:
> The last commit to #12623 introduced a compilation error caused by an extra
> semicolon. This PR fixes this.
Thanks for the quick turnaround Naoto. I'll find a suitable way to punish
myself for this one!
-
PR: https://git.
On Tue, 21 Feb 2023 21:27:08 GMT, Eirik Bjorsnos wrote:
> The last commit to #12623 introduced a compilation error caused by an extra
> semicolon. This PR fixes this.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12701
The last commit to #12623 introduced a compilation error caused by an extra
semicolon. This PR fixes this.
-
Commit messages:
- Fix complication error caused by extra semicolon
Changes: https://git.openjdk.org/jdk/pull/12701/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Tue, 21 Feb 2023 21:15:33 GMT, David Holmes wrote:
> The testcase change is failing to compile:
>
> ```
> open/test/micro/org/openjdk/bench/java/lang/Characters.java:115: error: case,
> default, or '}' expected
> ```
Darn, this was rather embarrassing!
Since this was just integrated, I gue
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Thu, 16 Feb 2023 22:50:25 GMT, Mandy Chung wrote:
>> I think, there's also a typo in the next line:
>>
>> checkCompress(classes, compressPlugin,
>>
>> should have been:
>>
>> checkCompress(classes, compressPluginZip0,
>>
>> I haven't yet looked at the existing test code in `checkCompress`
On Fri, 17 Feb 2023 17:31:09 GMT, Eirik Bjorsnos wrote:
> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>
> This takes advantage of the fact that latin1 uppercase code points are always
>
On Tue, 21 Feb 2023 20:33:41 GMT, Eirik Bjorsnos wrote:
>> Hi Alan,
>>
>> I thought I was clever by encoding the 'uppercaseness' in the variable name,
>> but yeah I'll find a better name :)
>>
>> There is some precedent for using the 'ASCII trick' comment in the JDK. I
>> found it in ZipFile
On Sun, 19 Feb 2023 08:54:56 GMT, Alan Bateman wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert changes in JrtPath, as it seems to be compiled with bootstrap JDK
>
>> Revert changes in JrtPath, as it seems
> For cleanup and dogfooding the new method, it would be nice to use Math.clamp
> where possible in java.base. See PR #12428.
>
> As Math.clamp performs an additional check that min is not greater than max,
> I conservatively replaced only those occurrences where I can see that this
> invariant
On Tue, 21 Feb 2023 20:23:11 GMT, Eirik Bjorsnos wrote:
>> src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line
>> 175:
>>
>>> 173: }
>>> 174: // uppercase b1 using 'the oldest ASCII trick in the book'
>>> 175: int U = b1 & 0xDF;
>>
>> I'm sur
On Tue, 21 Feb 2023 20:08:41 GMT, Justin Lu wrote:
>> Incorporate the latest IANA language subtag registry definition (2023-02-14).
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Copyright + correct date format
Marked as rev
On Tue, 21 Feb 2023 16:36:26 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/Executors/AutoShutdown.java line 133:
>>
>>> 131: while (!terminated) {
>>> 132: System.gc();
>>> 133: terminated = executor.awaitTermination(100,
>>> TimeUnit.MILLISECONDS);
>
On Tue, 21 Feb 2023 14:27:03 GMT, Alan Bateman wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove whitespace following '('
>
> src/java.base/share/classes/java/lang/CharacterDataLatin1.java.template line
> 1
On Tue, 21 Feb 2023 18:24:05 GMT, Alan Bateman wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalize
On Tue, 21 Feb 2023 19:56:59 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Copyright + correct date format
>
> test/jdk/java/util/Locale/LanguageSubtagRegistryTest.java line 29:
>
>> 27: * 825
> Incorporate the latest IANA language subtag registry definition (2023-02-14).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Copyright + correct date format
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12699/file
On Tue, 21 Feb 2023 19:26:46 GMT, Justin Lu wrote:
> Incorporate the latest IANA language subtag registry definition (2023-02-14).
Looks good. Please update the copyright year for the test changes.
test/jdk/java/util/Locale/LanguageSubtagRegistryTest.java line 29:
> 27: * 8258795 8267038
On Thu, 9 Feb 2023 18:11:18 GMT, Volker Simonis wrote:
>> Prior to
>> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
>> LambdaMetaFactory has created VM-anonymous classes which could easily be
>> unloaded once they were not
Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since
this is not a compatible upgrade to the existing mapping, a new system property
`jdk.charset.GB18030` is introduced. If it is set to "2000", the mapping falls
back to the existing mapping based on the 2000 standard, othe
On Tue, 21 Feb 2023 18:24:05 GMT, Alan Bateman wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalize
Incorporate the latest IANA language subtag registry definition (2023-02-14).
-
Commit messages:
- Add missing JBS #s to test header
- IANA update 2/14/23
Changes: https://git.openjdk.org/jdk/pull/12699/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12699&range=00
Issue:
On Fri, 17 Feb 2023 20:41:16 GMT, Matthew Donovan wrote:
>> Removed SSLSocketParametersTest.sh script (which just called a Java file)
>> and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase.
> Working down the porting list, next stop, atan2.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains six additional commits since the
last revi
On Fri, 17 Feb 2023 19:37:59 GMT, David M. Lloyd wrote:
>> The class generated for lambda proxies is now defined as a hidden class.
>> This means that the counter, which was used to ensure a unique class name
>> and avoid clashes, is now redundant. In addition to performing redundant
>> work,
On Fri, 17 Feb 2023 20:41:16 GMT, Matthew Donovan wrote:
>> Removed SSLSocketParametersTest.sh script (which just called a Java file)
>> and configured the java code to run directly with jtreg
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase.
On Fri, 17 Feb 2023 20:32:20 GMT, Matthew Donovan wrote:
>> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 163:
>>
>>> 161: }
>>> 162: }
>>> 163: }
>>
>> It looks like this finally-block is intended to unexport any exported RMI
>> service, which wi
On Thu, 9 Feb 2023 18:11:18 GMT, Volker Simonis wrote:
>> Prior to
>> [JDK-8239384](https://bugs.openjdk.org/browse/JDK-8239384)/[JDK-8238358](https://bugs.openjdk.org/browse/JDK-8238358)
>> LambdaMetaFactory has created VM-anonymous classes which could easily be
>> unloaded once they were not
> Augment NaN-handling tests to include exotic NaN bit patterns. Assuming this
> changeset goes back first, I'll update
> https://github.com/openjdk/jdk/pull/12608 to follow the same convention
> afterward.
Joe Darcy has updated the pull request incrementally with one additional commit
since t
On Sun, 19 Feb 2023 21:30:19 GMT, Joe Darcy wrote:
> Augment NaN-handling tests to include exotic NaN bit patterns. Assuming this
> changeset goes back first, I'll update
> https://github.com/openjdk/jdk/pull/12608 to follow the same convention
> afterward.
This pull request has now been inte
> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
> has finalizer to shutdown the underlying TPE when the wrapper is finalizable.
> It goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer
> in java.base. Removing it will likely lead to bug reports/
Fixes JDK-8302983 (and duplicate JDK-8302898)
-
Commit messages:
- 8302983: ZoneRulesProvider.registerProvider() twice will remove provider
Changes: https://git.openjdk.org/jdk/pull/12690/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12690&range=00
Issue: https://bugs.op
The Rational class provides operations for arithmetic, rounding,
comparison, hashing, and format conversion. The toString method provides a
canonical representation of a Rational. All the calculations performed have
an exact result, except for the square and nth roots, in which the user can
specify
On Sun, 19 Feb 2023 21:30:19 GMT, Joe Darcy wrote:
> Augment NaN-handling tests to include exotic NaN bit patterns. Assuming this
> changeset goes back first, I'll update
> https://github.com/openjdk/jdk/pull/12608 to follow the same convention
> afterward.
Marked as reviewed by bpb (Reviewer
> This enum is not used in the JDK and did not appear in external source code
> searches.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8302806: Remove test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/126
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Fri, 17 Feb 2023 14:08:34 GMT, Julian Waters wrote:
>> DLL_ERROR4 is a macro expanding to an error message when a failure to load a
>> generic item (shared libraries or an exported symbol from said libraries for
>> example) occurs. "Error: loading:" is not a very pretty message, so this
>>
> DLL_ERROR4 is a macro expanding to an error message when a failure to load a
> generic item (shared libraries or an exported symbol from said libraries for
> example) occurs. "Error: loading:" is not a very pretty message, so this
> small change results in "Error: Failed to load %s" instead, w
On Mon, 20 Feb 2023 18:34:17 GMT, Alan Bateman wrote:
> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
> has finalizer to shutdown the underlying TPE when the wrapper is finalizable.
> It goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer
> in
On Fri, 17 Feb 2023 14:08:34 GMT, Julian Waters wrote:
>> DLL_ERROR4 is a macro expanding to an error message when a failure to load a
>> generic item (shared libraries or an exported symbol from said libraries for
>> example) occurs. "Error: loading:" is not a very pretty message, so this
>>
On Tue, 21 Feb 2023 15:45:17 GMT, Viktor Klang wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalize
On Mon, 20 Feb 2023 18:34:17 GMT, Alan Bateman wrote:
> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
> has finalizer to shutdown the underlying TPE when the wrapper is finalizable.
> It goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer
> in
On Fri, 10 Feb 2023 20:33:39 GMT, Roger Riggs wrote:
> It can be difficult to find the cause of calls to
> `java.lang.System.exit(status)` and `Runtime.exit(status)` because the Java
> runtime exits.
> The status value and stack trace are logged using the System Logger named
> `java.lang.Runti
On Mon, 20 Feb 2023 18:34:17 GMT, Alan Bateman wrote:
> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
> has finalizer to shutdown the underlying TPE when the wrapper is finalizable.
> It goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer
> in
On Mon, 20 Feb 2023 22:26:21 GMT, David Holmes wrote:
> I would also be concerned about the guarantee of idempotency from the factory
> method - I hope its requirements in that area are clearly documented.
The spec for the getGenericXXX methods are "Return a" rather than "Return the"
so there
On Tue, 21 Feb 2023 11:14:13 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
>> 'the oldest ASCII trick in the book'.
>>
>> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
>> latin1 bytes for equality ignoring
Executors.newSingleThreadExecutor returns a delegating ExecutorService that has
finalizer to shutdown the underlying TPE when the wrapper is finalizable. It
goes back to JDK 6 and JDK-6399443. This is the last non-empty finalizer in
java.base. Removing it will likely lead to bug reports/complain
On Sat, 18 Feb 2023 23:26:08 GMT, Claes Redestad wrote:
> When encoding Strings to US-ASCII we can speed up the happy path
> significantly by using `StringCoding.countPositives` as a speculative check
> for whether there are any chars that needs to be replaced by `'?'`. Once a
> non-ASCII char
On Mon, 20 Feb 2023 21:40:41 GMT, Brett Okken wrote:
>> When encoding Strings to US-ASCII we can speed up the happy path
>> significantly by using `StringCoding.countPositives` as a speculative check
>> for whether there are any chars that needs to be replaced by `'?'`. Once a
>> non-ASCII cha
On Tue, 21 Feb 2023 12:09:51 GMT, Pavel Rappo wrote:
> Please review this trivial fix.
This pull request has now been integrated.
Changeset: 8b20aa91
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/8b20aa919b810fc5b3856b392bd0d8b1f882c895
Stats: 2 lines in 1 file chan
On Tue, 21 Feb 2023 12:09:51 GMT, Pavel Rappo wrote:
> Please review this trivial fix.
Marked as reviewed by jpai (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12689
Please review this trivial fix.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/12689/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12689&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8302981
Stats: 2 lines in 1 file changed: 0 ins;
On Tue, 11 Oct 2022 17:00:53 GMT, Smita Kamath wrote:
>> I started new testing.
>
> @vnkozlov Thank you for reviewing the patch.
There is an issue with the `_floatToFloat16` intrinsic, leading to incorrect
results: [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976).
@smita-kamath, coul
On Tue, 21 Feb 2023 11:14:13 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
>> 'the oldest ASCII trick in the book'.
>>
>> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
>> latin1 bytes for equality ignoring
On Tue, 21 Feb 2023 11:12:18 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
> This PR suggests we can speed up `StringLatin1.regionMatchesCI` by applying
> 'the oldest ASCII trick in the book'.
>
> The new static method `CharacterDataLatin1.equalsIgnoreCase` compares two
> latin1 bytes for equality ignoring case. `StringLatin1.regionMatchesCI` is
> updated to use `equa
On Tue, 21 Feb 2023 10:29:24 GMT, Claes Redestad wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Spell fix for 'exhaustive' in comments in sun/text/resources
>
> src/java.base/share/classes/java/lang/CharacterDat
> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>
> This takes advantage of the fact that latin1 uppercase code points are always
> 0x20 lower than their lowercase (with the exception of two
On Tue, 21 Feb 2023 06:59:47 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Tue, 21 Feb 2023 09:33:07 GMT, Eirik Bjorsnos wrote:
> I have the feeling that most case-insensitive comparisons are pretty short,
> so not sure how useful this is IRL.
There seems to be a win from strings of size 32 bytes upwards. (That's probably
longer than most keys in TreeMaps using St
On Tue, 21 Feb 2023 06:59:47 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we speed up Character.toUpperCase and Character.toLowerCase
>> for latin1 code points by applying the 'oldest ASCII trick in the book'.
>>
>> This takes advantage of the fact that latin1 uppercase code points are
>> al
On Tue, 21 Feb 2023 00:14:20 GMT, Naoto Sato wrote:
>> I did an 'exchaustive' search for 'exchaustive' across the code base and
>> found two comments in `LocaleData` and `LocaleData.cldr` in
>> `jdk/test/jdk/sun/text/resources`.
>>
>> Would you like me to update these as well while we're here
96 matches
Mail list logo
