On Wed, 4 Jan 2023 21:32:17 GMT, Stuart Marks wrote:
>> A gentle ping: please review the change and the CSR. Thanks.
>
> @amaembo a couple comments on the test.
>
> The test should probably have `@key randomness` added to it.
>
> On 2022-10-28, @bplb wrote:
>> jdk.test.lib.RandomFactory can be
> Java 17 added RandomGenerator interface. However, existing method
> Collections.shuffle accepts old java.util.Random class. While since Java 19,
> it's possible to use Random.from(RandomGenerator) wrapper, it would be more
> convenient to provide direct overload shuffle(List list, RandomGenera
On Sat, 14 Jan 2023 15:03:42 GMT, Kevin Rushforth wrote:
> Normally, such changes in third-party libraries need to be done upstream, and
> not locally. @prrace can confirm.
Thanks @kevinrushforth for your review.
Yes, it had been fixed in the upstream and I just follow it.
Please see https://g
On Sat, 14 Jan 2023 13:30:05 GMT, altrisi wrote:
> I'd say in there it makes more sense given the method is used when you want a
> wrapper, and therefore explicitly converting it helps documentation, but here
> it's just setting a property, where I don't think it helps anything, just
> decreas
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2) src/hotspot/share/runtime/notificationThre
Hi all,
Please review the fix for the build failure with clang-15.
1. -Wbitwise-instead-of-logical
1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the warning
2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code and
disable warnings
3) src/hotspot/s
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> in _javax.xml.stream.XMLOutputFactory_
>>
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> Justin Lu has updated the pull request increme
On Fri, 13 Jan 2023 22:36:47 GMT, Weijun Wang wrote:
>> Eirik Bjorsnos has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits
> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that
> files reside in META-INF directly, and not in a subdirectory of META-INF.
>
> The mentioned call sites needs updates to check and ignore such files.
>
> A new test VerifyUnrelatedSignatureFiles is added which verifies t
On Fri, 13 Jan 2023 22:36:01 GMT, Weijun Wang wrote:
>> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that
>> files reside in META-INF directly, and not in a subdirectory of META-INF.
>>
>> The mentioned call sites needs updates to check and ignore such files.
>>
>> A new
On Fri, 13 Jan 2023 22:31:28 GMT, Weijun Wang wrote:
>> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that
>> files reside in META-INF directly, and not in a subdirectory of META-INF.
>>
>> The mentioned call sites needs updates to check and ignore such files.
>>
>> A new
On Tue, 10 Jan 2023 15:15:23 GMT, Feilong Jiang wrote:
>> Add experimental Foreign Function & Memory API support for RISC-V.
>>
>> For details of the FFM API RISC-V port please refer to [JBS
>> issue](https://bugs.openjdk.org/browse/JDK-8293841)
>>
>> Testing:
>>
>> - [x] jdk_foreign with rel
On Sat, 14 Jan 2023 03:56:33 GMT, Stuart Marks wrote:
>> Also additional verbiage regarding Map.Entry objects in general and their
>> possible connection to an underlying Map.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 13 Jan 2023 19:18:46 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to
>> [JDK-8298971](https://bugs.openjdk.org/browse/JDK-8298971). The previous fix
>> lacked the native part change on Windows.
>
> Naoto Sato has updated the pull request incrementally with one additio
14 matches
Mail list logo
