Re: RFR: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports

2023-01-08 Thread Iris Clark
On Wed, 4 Jan 2023 21:49:18 GMT, Justin Lu wrote: > Within _test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java_ > > GregorianCalendar alone handles all the necessary imports, Calendar is not > needed Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jd

Re: RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

2023-01-08 Thread David Holmes
On Tue, 16 Aug 2022 15:06:50 GMT, Aleksey Shipilev wrote: > I noticed that current VarHandle/Unsafe test cases do not test the > always-failing cases. Strong CASes do test both always-success and > always-failing scenarios, while weak CASes only test spurious-failure tests. > We should be also

Re: RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

2023-01-08 Thread Aleksey Shipilev
On Sun, 8 Jan 2023 23:25:36 GMT, David Holmes wrote: > Committing unchanged files, other than a copyright year change, looks very > odd here. Why was the SunMisUnsafe template updated but none of the tests > actually changed? `X-UnsafeAccessTest.java.template` generates both `SunMisc*` and `J

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-08 Thread David Holmes
On Sat, 7 Jan 2023 21:08:07 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gener

Re: jpackageapplauncher linker arguments for osx

2023-01-08 Thread David Holmes
On 8/01/2023 8:39 pm, David Schumann wrote: Hello, I'm not 100% sure if this list is the correct one for this topic, feel free to redirect me. core-libs-dev - cc'd Cheers, David Currently the jpackageapplauncher binary gets linked without the "-headerpad_max_install_names" argument on osx.

Re: [jdk20] RFR: 8299689: Make use of JLine for Console as "opt-in"

2023-01-08 Thread Jaikiran Pai
On Fri, 6 Jan 2023 17:57:47 GMT, Naoto Sato wrote: > Due to the fact that JLine spawns native processes to obtain terminal > information on macOS/Linux, we decided to disable the JLine by default for > performance degradation reasons. It is still possible to enable it by > specifying it on the

Re: RFR: 8297306: Incorrect brackets in Javadoc for a constructor of IteratorSpliterator [v2]

2023-01-08 Thread Jaikiran Pai
On Mon, 9 Jan 2023 01:09:04 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes an issue in the javadoc >> text of the internal class IteratorSpliterator? This addresses the issue >> reported at https://bugs.openjdk.org/browse/JDK-8297306. > > Jaikiran Pai has upda

Re: RFR: 8297306: Incorrect brackets in Javadoc for a constructor of IteratorSpliterator [v2]

2023-01-08 Thread Jaikiran Pai
> Can I please get a review of this change which fixes an issue in the javadoc > text of the internal class IteratorSpliterator? This addresses the issue > reported at https://bugs.openjdk.org/browse/JDK-8297306. Jaikiran Pai has updated the pull request incrementally with one additional commi

Re: RFR: 8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

2023-01-08 Thread David Holmes
On Tue, 16 Aug 2022 15:06:50 GMT, Aleksey Shipilev wrote: > I noticed that current VarHandle/Unsafe test cases do not test the > always-failing cases. Strong CASes do test both always-success and > always-failing scenarios, while weak CASes only test spurious-failure tests. > We should be also