Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v9]

2022-12-16 Thread Justin King
On Sat, 17 Dec 2022 06:33:43 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Justin King
On Fri, 16 Dec 2022 15:56:44 GMT, Magnus Ihse Bursie wrote: > However, I do think the included source files should be treated like the > autoheaders, and reside in data rather than in `src`. The latter is intended > for buildtools, even though they are a bit scattered at the moment (there is >

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v10]

2022-12-16 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v9]

2022-12-16 Thread Justin King
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior or suppress errors which are intentional. The goal is t

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-16 Thread Sandhya Viswanathan
On Sun, 13 Nov 2022 20:57:44 GMT, Claes Redestad wrote: >> src/hotspot/cpu/x86/x86_64.ad line 12073: >> >>> 12071: legRegD tmp_vec13, rRegI tmp1, rRegI tmp2, >>> rRegI tmp3, rFlagsReg cr) >>> 12072: %{ >>> 12073: predicate(UseAVX >= 2 && ((VectorizedHashCodeNode*)n)->

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-16 Thread Sandhya Viswanathan
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote: >> Continuing the work initiated by @luhenry to unroll and then intrinsify >> polynomial hash loops. >> >> I've rewired the library changes to route via a single `@IntrinsicCandidate` >> method. To make this work I've harmonized how they

Re: JEP-198 - Lets start talking about JSON

2022-12-16 Thread Ethan McCue
Sidenote about "Project Galahad" - I know Graal uses json for a few things including a reflection-config.json. Food for thought. > the java.util.log experiment shows that trying to ‘core-librarize’ needs that the community at large already fulfills with third party deps isn’t a good move, I, pers

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-16 Thread Sandhya Viswanathan
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote: >> Continuing the work initiated by @luhenry to unroll and then intrinsify >> polynomial hash loops. >> >> I've rewired the library changes to route via a single `@IntrinsicCandidate` >> method. To make this work I've harmonized how they

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:16:38 GMT, Iris Clark wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/browse

[jdk20] Integrated: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:13:56 GMT, Kim Barrett wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/brows

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Iris Clark
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Kim Barrett
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs.openjdk.org/

[jdk20] Integrated: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-16 Thread Damon Nguyen
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed This pull request has now been integrated. Changeset: c997b5bf Author:Damon Nguyen Committer: Naoto Sato URL: https://git.openjdk.org/jdk20/commit/c997b5bffd0ebbd6d68332572639c8cea05ccdb1 Stat

[jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
A batch a trivial fixes to ProblemList tests: [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList vmTestbase/nsk/stress/strace/strace002.

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v7]

2022-12-16 Thread Adam Sotona
On Mon, 7 Nov 2022 16:28:19 GMT, Adam Sotona wrote: >> So this will be removed later on in one of the follow up "chicken" PRs? > > It will be removed in this PR later, this specific workaround is not intended > to fall into JDK. > The CompileInterimLangtools patch represents a way how to make th

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v7]

2022-12-16 Thread Adam Sotona
> **This pull request is not intended for immediate integration to JDK > mainline.** > > This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-16 Thread Weijun Wang
On Fri, 16 Dec 2022 17:41:42 GMT, Damon Nguyen wrote: >> Yes, you can replace all "存在安全风险" (that is not after ""被视为") to "被视为存在安全风险". >> >> There are also similar usages in >> `src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java`. > > Hi @wangweij , I believe I fixed the o

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 17:26:18 GMT, Phil Race wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert old translation. Fix lang codes > > src/demo/share/jfc/SwingSet2/resources/swingset_zh_CN.properties line 430: > >

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v8]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Swingset newline - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/fe

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 15:02:42 GMT, Weijun Wang wrote: >> I didn't do the translation myself so I'm not sure the best approach to >> resolve this. I can manually replace these translations with one or the >> other. However, it's determine which parts of the code translate to >> 被视为存在安全风险" or "存在

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v7]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert swingset. Consistency in CN - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk2

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v6]

2022-12-16 Thread Phil Race
On Fri, 16 Dec 2022 17:02:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix missing dash src/demo/share/jfc/SwingSet2/resources/swingset_zh_CN.properties

Integrated: 8298808: Check `script` code on detecting the base locales

2022-12-16 Thread Naoto Sato
On Wed, 14 Dec 2022 23:08:16 GMT, Naoto Sato wrote: > Fixing `CLDRConverter` build tool to not regard [new > locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) > introduced in CLDR 43 as one of the base locales. Ot

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 09:46:14 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/sun/launcher/resources/launcher_de.properties >> line 34: >> >>> 32: # Translators please note do not translate the options themselves >>> 33: java.launcher.opt.footer = \-cp >> und ZIP-/JAR-Dateien>\n-

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v6]

2022-12-16 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix missing dash - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/29

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v5]

2022-12-16 Thread Brian Burkhalter
On Fri, 16 Dec 2022 09:06:10 GMT, Per Minborg wrote: >> This PR suggests improving performance for read and write operations for the >> longer primitives in `RandomAccessFile`. >> >> These improvements would also propagate to other JDK classes relying on >> these improved `RandomAccessFile` op

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Damon Nguyen
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes Right, Naoto's comment is correct. This tim

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-16 Thread Weijun Wang
On Fri, 16 Dec 2022 03:41:09 GMT, Damon Nguyen wrote: >> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java >> line 75: >> >>> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"}, >>> //-genseckey >>> 74: {"key.algorithm.weak", "%1$s \u4F7F\u752

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Fri, 9 Dec 2022 20:38:26 GMT, Erik Joelsson wrote: >> make/autoconf/jdk-options.m4 line 450: >> >>> 448: >>> ### >>> 449: # >>> 450: # UndefinedBehaviorSanitizer >> >> I think this logic fits better in `flags.m4`, o

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v8]

2022-12-16 Thread Magnus Ihse Bursie
On Mon, 12 Dec 2022 10:42:22 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Integrated: Merge jdk20

2022-12-16 Thread Jesper Wilhelmsson
On Fri, 16 Dec 2022 13:25:55 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 3696711e Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/3696711efa566fb776d6923da86e17b0e1e22964 Stats: 250 lines

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Naoto Sato
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes There is another translation drop scheduled

RFR: Merge jdk20

2022-12-16 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge - 8298797: Specification of some restricted methods is incorrect - 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there. - 8297979: ZGC: En

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-16 Thread Sibabrata Sahoo
On Mon, 5 Dec 2022 19:52:18 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/se

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v5]

2022-12-16 Thread Alan Bateman
On Fri, 16 Dec 2022 09:06:10 GMT, Per Minborg wrote: >> This PR suggests improving performance for read and write operations for the >> longer primitives in `RandomAccessFile`. >> >> These improvements would also propagate to other JDK classes relying on >> these improved `RandomAccessFile` op

[jdk20] Integrated: 8298797: Specification of some restricted methods is incorrect

2022-12-16 Thread Maurizio Cimadamore
On Thu, 15 Dec 2022 10:43:35 GMT, Maurizio Cimadamore wrote: > This patch fixes some inconsistencies in the javadoc for restricted methods: > > * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its > `@throws` clause. This shorted text is now used everywhere. > * One overlo

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Alan Bateman
On Fri, 16 Dec 2022 03:55:29 GMT, Damon Nguyen wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert old translation. Fix lang codes > > @dfuch Could I get a review from you as well? I believe this translation >

Re: RFR: 8298638: Cleanup of unix java_md.c for better re-exec handling

2022-12-16 Thread Dmitry Samersoff
On Wed, 14 Dec 2022 09:51:20 GMT, Alan Bateman wrote: >> src/java.base/unix/native/libjli/java_md.c line 177: >> >>> 175: char clientPattern[] = "lib/client"; >>> 176: char serverPattern[] = "lib/server"; >>> 177: char minimalPattern[] = "lib/minimal"; >> >> I don't see any point in

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Daniel Fuchs
On Fri, 16 Dec 2022 09:20:07 GMT, Daniel Fuchs wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert old translation. Fix lang codes > > src/java.base/share/classes/sun/launcher/resources/launcher_de.properties >

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Daniel Fuchs
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes src/java.base/share/classes/sun/launcher/re

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v5]

2022-12-16 Thread Per Minborg
> This PR suggests improving performance for read and write operations for the > longer primitives in `RandomAccessFile`. > > These improvements would also propagate to other JDK classes relying on these > improved `RandomAccessFile` operations. Per Minborg has updated the pull request incremen

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v4]

2022-12-16 Thread Per Minborg
> This PR suggests improving performance for read and write operations for the > longer primitives in `RandomAccessFile`. > > These improvements would also propagate to other JDK classes relying on these > improved `RandomAccessFile` operations. Per Minborg has updated the pull request incremen