Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Thu, 15 Dec 2022 07:01:05 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Swapping deprecations in properties > > test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 153: > >> 151:

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Thu, 15 Dec 2022 06:56:09 GMT, Jaikiran Pai wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Swapping deprecations in properties > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line >

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate

Re: RFR: 8293667: Align jlink's --compress option with jmod's --compress option [v2]

2022-12-14 Thread Jaikiran Pai
On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves wrote: >> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate

Integrated: Merge jdk20

2022-12-14 Thread Jesper Wilhelmsson
On Wed, 14 Dec 2022 22:39:44 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 10bc86cc Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/10bc86cc260fac48bf10f67dd56aa73c6954f026 Stats: 132 lines

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-14 Thread Damon Nguyen
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Removed trailing whitespace - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
On Thu, 15 Dec 2022 01:04:12 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line > 26: > >> 24: # >> 25: >> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >> JMOD-Dateien auflisten

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote: >> Open l10n drop >> All tests passed > > src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties > line 188: > >> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >> 187: >> 188: main.plugin.category=\u7C7B\u522B > >

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26: > 24: # > 25: > 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener > JMOD-Dateien auflisten `jlink.de

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Justin Lu
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties line 188: > 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 > 187: > 188: main.plugin.category=\u7C7B\u522B As Naoto poin

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Alisen Chung
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote: > Open l10n drop > All tests passed looks good - Marked as reviewed by achung (Committer). PR: https://git.openjdk.org/jdk20/pull/35

[jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10

2022-12-14 Thread Damon Nguyen
Open l10n drop All tests passed - Commit messages: - open l10n drop Changes: https://git.openjdk.org/jdk20/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298133 Stats: 1177 lines in 110 files changed: 783

Re: RFR: 8298808: Check `script` code on detecting the base locales [v2]

2022-12-14 Thread Naoto Sato
> Fixing `CLDRConverter` build tool to not regard [new > locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) > introduced in CLDR 43 as one of the base locales. Otherwise they would > incorrectly go into `java.base`

RFR: 8298808: Check `script` code on detecting the base locales

2022-12-14 Thread Naoto Sato
Fixing `CLDRConverter` build tool to not regard [new locales](https://github.com/unicode-org/cldr/pull/2508/files#diff-94cbefde02914335da884f768063a06a84ad651ee4e56cdb1cb90625d7776731) introduced in CLDR 43 as one of the base locales. Otherwise they would incorrectly go into `java.base` module,

RFR: Merge jdk20

2022-12-14 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: `null' for expression `vm.opt.ExplicitGCInvokesConcurrent'" - 8298277: Replace "session" with "scope

[jdk20] Integrated: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Per Minborg
On Wed, 14 Dec 2022 09:30:21 GMT, Per Minborg wrote: > This PR proposes changing variable names from `session` to `scope`. The > proposed changes are only for the FFM API and not other parts like the Vector > API and test classes. This pull request has now been integrated. Changeset: ebc47104

Re: RFR: 8298416: Console should be declared `sealed` [v3]

2022-12-14 Thread Naoto Sato
On Wed, 14 Dec 2022 02:16:41 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moved echo() to ConsoleImpl, clean-ups > > src/java.base/share/classes/java/io/ConsoleImpl.java line 306: > >> 304:

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-14 Thread Naoto Sato
On Wed, 14 Dec 2022 08:46:58 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits s

Re: RFR: 8298416: Console should be declared `sealed` [v3]

2022-12-14 Thread Naoto Sato
> `Console` class now has a couple of internal subclasses within `java.io` > package. It should be `sealed` and subclasses be declared in the `permits` > clause. The implementation resided in `Console` class is separated into > `ConsoleImpl` class. Naoto Sato has updated the pull request increm

Re: Boilerplate to add a new module

2022-12-14 Thread Ethan McCue
Subtract one negative from that last clause On Wed, Dec 14, 2022 at 12:02 PM Ethan McCue wrote: > Thank you! > > And yeah - I'll send a separate email opining on the directions that can > go. > > The features that should be incorporated/designed for (value > classes/string templates/pattern matc

Re: Boilerplate to add a new module

2022-12-14 Thread Ethan McCue
Thank you! And yeah - I'll send a separate email opining on the directions that can go. The features that should be incorporated/designed for (value classes/string templates/pattern matching) are more clearly in view than they were three years ago when last it was brought up and certainly more re

Re: RFR: 8298590: Refactor LambdaForm constructors

2022-12-14 Thread Claes Redestad
On Fri, 9 Dec 2022 18:02:53 GMT, Jorn Vernee wrote: > Refactor LambdaForm constructors into static factories. > > In the new code, there's only 1 constructor, which simply initializes all > fields. Multiple factory methods are built on top of this, which add various > argument validation/pre-p

Re: [jdk20] RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Maurizio Cimadamore
On Wed, 14 Dec 2022 09:30:21 GMT, Per Minborg wrote: > This PR proposes changing variable names from `session` to `scope`. The > proposed changes are only for the FFM API and not other parts like the Vector > API and test classes. Looks good! - Marked as reviewed by mcimadamore (

Re: RFR: 8298638: Cleanup of unix java_md.c for better re-exec handling

2022-12-14 Thread Alan Bateman
On Wed, 14 Dec 2022 00:59:53 GMT, David Holmes wrote: >> Move "unix" java_md.c cleanup, which is the prerequisites for the fix for >> JDK-8293806 (PR https://github.com/openjdk/jdk/pull/11538), to a separate PR. >> >> @AlanBateman, @dholmes-ora please, take a look to the changes. > > src/java.b

[jdk20] RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Per Minborg
This PR proposes changing variable names from `session` to `scope`. The proposed changes are only for the FFM API and not other parts like the Vector API and test classes. - Commit messages: - Replace session with scope for FFM access Changes: https://git.openjdk.org/jdk20/pull/29

Re: RFR: 8298639: Perform I/O operations in bulk for RandomAccessFile [v2]

2022-12-14 Thread Sergey Tsypanov
On Tue, 13 Dec 2022 19:57:29 GMT, Alan Bateman wrote: > I think that PR was closed as it went inactive Yep, I think there I did everything I could, hope this one will be merged as the changes are helpful - PR: https://git.openjdk.org/jdk/pull/11644

Withdrawn: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Per Minborg
On Thu, 8 Dec 2022 14:11:29 GMT, Per Minborg wrote: > This PR proposes changing variable names and text from "session" to "scope". > The proposed changes are only for the FFM API and not other parts like the > Vector API and test classes. This pull request has been closed without being integra

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access [v2]

2022-12-14 Thread Per Minborg
On Thu, 8 Dec 2022 15:57:23 GMT, Per Minborg wrote: >> This PR proposes changing variable names and text from "session" to "scope". >> The proposed changes are only for the FFM API and not other parts like the >> Vector API and test classes. > > Per Minborg has updated the pull request incremen

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-14 Thread Alan Bateman
On Tue, 13 Dec 2022 18:29:31 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >> `ConsoleIm

Re: Boilerplate to add a new module

2022-12-14 Thread Alan Bateman
On 14/12/2022 03:36, Ethan McCue wrote: Hey all, I'm doodling on JEP-198, and I was wondering if anyone had a line on the boilerplate needed to add a new module to the build. Just adding src/   java.json/     share/       classes/         module-info.java         java/           json/