On Wed, 30 Nov 2022 18:07:07 GMT, Andrew John Hughes wrote:
> Update to the latest tzdata, 2022g.
>
> Primary changes:
> * `America/Ojinaga` (CST) is split, creating `America/Ciudad_Juarez` (MST/MDT)
> * `America/Pangnirtung` becomes a link to `America/Iqaluit`
> * `America/Ojinaga` gains DST (C
On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote:
>> This turned out to be much more complicated than anticipated. I am going to
>> close this PR (and bug), and instead I have split up this work in five
>> different bugs:
>>
>> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047) is
On Wed, 30 Nov 2022 18:35:47 GMT, Jorn Vernee wrote:
> A small clarification of the VaList spec to say that attempts to access
> elements through an incorrect memory layout result in undefined behavior.
This pull request has now been integrated.
Changeset: 562bc171
Author:Jorn Vernee
URL:
On Fri, 2 Dec 2022 15:21:40 GMT, Weijun Wang wrote:
>> Naoto has confirmed that the password prompt from keytool does not echo,
>> good!
>>
>> The intention is that Console be usable in jshell so I think the issue is
>> that readPassword is echo'ing when used in jshell. Maybe someone
>> exper
On Fri, 2 Dec 2022 20:34:30 GMT, Jorn Vernee wrote:
>> A small clarification of the VaList spec to say that attempts to access
>> elements through an incorrect memory layout result in undefined behavior.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit sin
> This is to allow Console to be used even when it is not attached to the
> platform provided terminal, such as the case when the standard input is
> redirected. `System.console()` now returns a Console implementation based on
> `jdk.internal.le` terminal by default, or jshell implementation if
On Fri, 2 Dec 2022 18:53:21 GMT, Sergey Tsypanov wrote:
>> I found out that this code
>>
>> public class Main {
>> public static void main(String[] args) {
>> String s = "Hello world!";
>> char[] chars = s.toCharArray();
>> int point = Character.codePointAt(chars, -1,
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX
On Fri, 2 Dec 2022 20:21:17 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/VaList.java line 55:
>>
>>> 53: * and any other type that fits into a {@code long}.
>>> 54: * Safety considerations
>>> 55: * Accessing a value through a variable argument list using
> A small clarification of the VaList spec to say that attempts to access
> elements through an incorrect memory layout result in undefined behavior.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
review
-
Changes:
-
On Thu, 1 Dec 2022 21:31:28 GMT, Chris Hennick wrote:
>> Chris Hennick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add parameter to enable/disable fixed PRNG seed
>
> @simonis @navyxliu @turbanoff @rgiulietti This is ready for review
On Fri, 2 Dec 2022 16:59:25 GMT, Jorn Vernee wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rewrite doc
>
> src/java.base/share/classes/java/lang/foreign/VaList.java line 55:
>
>> 53: * and any other type that fi
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
> }
> }
>
> throws `ArrayIndexOutOfBoundsException` ins
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
> A small clarification of the VaList spec to say that attempts to access
> elements through an incorrect memory layout result in undefined behavior.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Typos
-
Changes:
- a
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote:
> and instead I have split up this work in five different bugs
would you consider also adding a unit test to check whether the localized
resources also contain leading/trailing whitespace, and possibly special
characters (like {, }, ,
[JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
attempt to remove all trailing whitespace from properties files, and enable a
jcheck verification that they did not come back, similar to other source code.
It turned out that this was not so simple, however, since trai
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 2 Dec 2022 16:45:56 GMT, Jorn Vernee wrote:
>> This sentence still needs to be clarified IMHO. E.g. it is not clear when
>> reading what "using a memory layout other than the layout of the accessed
>> value" - since we are passing a layout to the access operation... it feels
>> like we
> A small clarification of the VaList spec to say that attempts to access
> elements through an incorrect memory layout result in undefined behavior.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
rewrite doc
-
Changes:
On Fri, 2 Dec 2022 16:59:25 GMT, Jorn Vernee wrote:
>> A small clarification of the VaList spec to say that attempts to access
>> elements through an incorrect memory layout result in undefined behavior.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit sin
On Thu, 1 Dec 2022 21:56:32 GMT, Maurizio Cimadamore
wrote:
>> Right.
>
> This sentence still needs to be clarified IMHO. E.g. it is not clear when
> reading what "using a memory layout other than the layout of the accessed
> value" - since we are passing a layout to the access operation... it
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
According to [the
specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
trailing whitespaces in the values of properties files are (somewhat
surprisingly) actually significant.
We have multiple files in the JDK with trailing
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Fri, 2 Dec 2022 15:32:20 GMT, Brett Okken wrote:
> As ArrayIndexOutOfBoundsException is an IndexOutOfBoundsException, it is not
> clear to me how this is not matching the javadoc/spec.
The check within `codePointAt()` doesn't match the spec.
`ArrayIndexOutOfBoundsException` is thrown from t
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
> }
> }
>
> throws `ArrayIndexOutOfBoundsException` ins
On Fri, 2 Dec 2022 12:44:18 GMT, Sergey Tsypanov wrote:
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
>
On Fri, 2 Dec 2022 12:44:18 GMT, Sergey Tsypanov wrote:
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
>
On Fri, 2 Dec 2022 08:18:35 GMT, Alan Bateman wrote:
>> If the console cannot be used anyway inside jshell, then this is good enough.
>
> Naoto has confirmed that the password prompt from keytool does not echo, good!
>
> The intention is that Console be usable in jshell so I think the issue is
On Fri, 2 Dec 2022 12:44:18 GMT, Sergey Tsypanov wrote:
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
>
On Fri, 2 Dec 2022 15:00:15 GMT, Sergey Tsypanov wrote:
> The reason why it was passing prior to these changes is that
> `ArrayIndexOutOfBoundsException` extends `IndexOutOfBoundsException` and the
> latter is caught in the test.
Perhaps then, tighten up the test. It seems odd to have a case
On Fri, 2 Dec 2022 14:47:24 GMT, Roger Riggs wrote:
>> I found out that this code
>>
>> public class Main {
>> public static void main(String[] args) {
>> String s = "Hello world!";
>> char[] chars = s.toCharArray();
>> int point = Character.codePointAt(chars, -1, 1);
On Fri, 2 Dec 2022 12:44:18 GMT, Sergey Tsypanov wrote:
> I found out that this code
>
> public class Main {
> public static void main(String[] args) {
> String s = "Hello world!";
> char[] chars = s.toCharArray();
> int point = Character.codePointAt(chars, -1, 1);
>
On Wed, 23 Nov 2022 15:38:29 GMT, Roger Riggs wrote:
> > /issue add JDK-8296302
>
> The BOT comment at the top says /issue cannot refer to a CSR. You'll need to
> /issue remove it before integration.
Roger is correct, please do not add CSR issues with `/issue add`. The bot
should auto discove
I found out that this code
public class Main {
public static void main(String[] args) {
String s = "Hello world!";
char[] chars = s.toCharArray();
int point = Character.codePointAt(chars, -1, 1);
}
}
throws `ArrayIndexOutOfBoundsException` instead of JavaDoc-specif
On Thu, 1 Dec 2022 19:36:16 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> lis
> **This pull request is not intended for immediate integration to JDK
> mainline.**
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming
On Fri, 2 Dec 2022 08:31:25 GMT, Daniel Jeliński wrote:
> Please review this patch that removes progress monitoring classes used by
> UrlConnection.
> Since Java 9 these classes are not used in the JDK, and are not exported from
> java.base. If anyone was still using them, reimplementing them i
Please review this patch that removes progress monitoring classes used by
UrlConnection.
Since Java 9 these classes are not used in the JDK, and are not exported from
java.base. If anyone was still using them, reimplementing them in user code
should be pretty straightforward.
This PR also fixes
On Thu, 1 Dec 2022 23:38:40 GMT, Weijun Wang wrote:
>> I confirmed that the standalone `keytool` did not echo the input, which
>> should be OK for this IMO.
>
> If the console cannot be used anyway inside jshell, then this is good enough.
Naoto has confirmed that the password prompt from keytoo
43 matches
Mail list logo