On Wed, 16 Nov 2022 14:02:01 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> 1) Removed the link for CSR.
> 2) Add a new method in SystemProps.java to check if the warning mes
On Thu, 17 Nov 2022 03:39:37 GMT, Stuart Marks wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review suggestion - simplify test
>
> test/jdk/java/util/Collections/DelegatingIteratorForEachRemaining.java line
> 23
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8292317?
>
> The `java.util.Iterator` has a `forEachRemaining(Consumer action)`
> method. As per its contract, the implementations are expected to throw a
> `NullPointerException` if the passe
On Tue, 15 Nov 2022 02:10:01 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8292317?
>
> The `java.util.Iterator` has a `forEachRemaining(Consumer action)`
> method. As per its contract, the implementations are ex
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incr
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall
On 11/16/2022 3:41 PM, John Rose wrote:
And yet, in the example given above, the list of fragments |List.of(" +
", " = ")| is one element /smaller/ than the list of values |List.of(10,
20, 30)|. The example is wrong. It’s worth a note in the doc that if an
interpolated expression begins and/or
On 16 Nov 2022, at 11:10, Alex Buckley wrote:
…
For example, the following code contains a template expression that
uses the template processor `RAW`, which simply yields the
`StringTemplate` passed to it:
int x = 10;
int y = 20;
StringTemplate st = RAW."\{x} + \{y} = \{x + y}";
List fragmen
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote:
> Adding a `@sealedGraph` tag to `ZoneId` class.
Get a nice graph!
-
Marked as reviewed by joehw (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11195
On Wed, 16 Nov 2022 20:33:50 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
The first line says StringTemplates, should say StringTemplate.
The paragraph about the `process(ValidatingProcessor)` method is
confusing -- it's not an alternative to using template expressions if
the example needs to show a template expression before invoking
`process`. I think you mean to
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote:
> Adding a `@sealedGraph` tag to `ZoneId` class.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11195
On Wed, 16 Nov 2022 20:25:30 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplateImplFactory.java
> line 202:
>
>>
On Mon, 14 Nov 2022 17:51:24 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Fri, 16 Sep 2022 07:35:03 GMT, Leslie Zhai wrote:
> Hi,
>
> @dumasun reported the issue:
>
> Configured with jfx-ls-modular-sdk:
>
>
> configure --with-import-modules=modular-sdk
>
>
> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"`
> failed:
>
>
> --S
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Wed, 16 Nov 2022 18:52:33 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 31:
>
>> 29: import java.
On Wed, 16 Nov 2022 19:16:26 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
> line 700:
>
>> 698:
On Wed, 16 Nov 2022 20:12:11 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
>> line 1716:
>>
>>> 1714: t = stringTemplate(t);
>>> 1715: typeArgs = null;
>>> 1716: // Uncomment to no
On Wed, 16 Nov 2022 16:07:51 GMT, Jan Lahoda wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ArgumentAttr.java
> line 77:
>
>> 75: im
CSR and available docs have been changed to reflect these changes.
https://cr.openjdk.java.net/~jlaskey/templates/docs/api/java.base/java/lang/template/StringTemplate.html
Cheers,
— Jim
On Nov 16, 2022, at 3:10 PM, Alex Buckley
mailto:alex.buck...@oracle.com>> wrote:
Below, a revised descrip
On Wed, 16 Nov 2022 19:08:48 GMT, Andrew Haley wrote:
>> There is a "bare" reference to `ScopedValue`. Should it be `{@code
>> ScopedValue}` or `{@link ScopedValue}` ?
>
> Ahh, OK.
We fixed those in the recent update.
-
PR: https://git.openjdk.org/jdk/pull/10952
On Mon, 14 Nov 2022 17:51:24 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
Adding a `@sealedGraph` tag to `ZoneId` class.
-
Commit messages:
- 8297152: Add a @sealedGraph tag to ZoneId
Changes: https://git.openjdk.org/jdk/pull/11195/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11195&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8297152
On Wed, 16 Nov 2022 18:26:15 GMT, Maurizio Cimadamore
wrote:
>> Sorry, I don't understand what you want.
>
> There is a "bare" reference to `ScopedValue`. Should it be `{@code
> ScopedValue}` or `{@link ScopedValue}` ?
Ahh, OK.
-
PR: https://git.openjdk.org/jdk/pull/10952
Below, a revised description for `StringTemplate`.
// High-level opener.
`StringTemplate` is the run-time representation of a string template or
text block template in a template expression.
[Sidebar. The JEP says "An instance of StringTemplate represents the
string template or text block t
On Wed, 16 Nov 2022 16:01:20 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> Compiler changes look good to me. I've left some comments on API javadoc, as
> well as
On Fri, 4 Nov 2022 09:50:10 GMT, Andrew Haley wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 481:
>>
>>> 479: }
>>> 480: */
>>> 481: return findBinding() != Snapshot.NIL;
>>
>> This should probably call `Cache.put(this, v
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Wed, 16 Nov 2022 15:56:25 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/util/FormatProcessor.java line 42:
>>
>>> 40: * the embedded expression that follows immediately after the
>>> 41: * format specifier.
>>> 42: * StringTemplate expressions without a preceeding sp
On Wed, 16 Nov 2022 15:55:27 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 38:
>
>> 36:
>> 37: /*
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by iris (Review
On Wed, 16 Nov 2022 15:58:49 GMT, Andrew Haley wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 460:
>>
>>> 458: * }
>>> 459: *
>>> 460: * @param key the ScopedValue key
>>
>> should use `@code` or `@link`
>
> Sorry, I don't
On Wed, 16 Nov 2022 15:54:49 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/ProcessorLinkage.java line 48:
>
>> 46:
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Wed, 16 Nov 2022 17:04:03 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes the
On Wed, 16 Nov 2022 15:44:55 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/TemplateProcessor.java line 31:
>
>> 29:
On Wed, 16 Nov 2022 15:43:42 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 302:
>
>> 300:
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by lancea (Revi
On Wed, 16 Nov 2022 15:41:49 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/template/StringTemplate.java line 273:
>>
>>> 271:
>>> 272: /**
>>> 273: * Combine one or more {@link StringTemplate StringTemplates} to
>>> produce a combined {@link StringTemplate
On Wed, 16 Nov 2022 15:37:10 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 208:
>
>> 206:
On Wed, 16 Nov 2022 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 198:
>
>> 196:
On Wed, 16 Nov 2022 15:32:40 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 120:
>
>> 118:
On Wed, 16 Nov 2022 15:27:47 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 38:
>
>> 36:
>
On Wed, 16 Nov 2022 16:10:45 GMT, Adam Sotona wrote:
> Alternate suggestions are welcome, or link to relevant documentation, or an
> example of another filtered option.
I think I would start in ParseArguments (libjli/java.c) to see the options that
are handled, translated, or passed through. I
On Wed, 16 Nov 2022 15:02:08 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the ConstantDesc class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
>
> Here is how it would look like:
>
> src="http
On Wed, 16 Nov 2022 16:52:50 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the `Reference` class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like:
>
> src="https://
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by naoto (Revie
On Wed, 16 Nov 2022 15:26:55 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 28:
>
>> 26: pa
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
`Reference` class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202243138-7f2a799a-dc67-4c4e-9322-c
On Wed, 16 Nov 2022 15:26:05 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
> line
On Wed, 16 Nov 2022 16:07:10 GMT, Jorn Vernee wrote:
>> Pull in linker implementation changes, that include non-trivial changes to
>> VM code, from the panama-foreign repo into the main JDK.
>>
>> This is split off from the main JEP integration to make reviewing easier.
>>
>> This includes the
On Tue, 15 Nov 2022 18:47:39 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Javadoc changes.
- ProblemList.txt cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jd
On Wed, 16 Nov 2022 16:41:45 GMT, Maurizio Cimadamore
wrote:
>> Most of the AutoCloseable in the platform are Closeables where close is
>> specified to have no effect when already closed. With a confined Arena it
>> would be benign for the owner to invoke close again. If it's been useful at
>
On Wed, 16 Nov 2022 15:22:43 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java
> line 125:
On Wed, 16 Nov 2022 16:13:16 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Arena.java line 132:
>>
>>> 130: * and all the memory segments associated with it can no longer be
>>> accessed. Furthermore, any off-heap region of memory backing the
>>> 131:
On Wed, 16 Nov 2022 16:17:01 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the CallSite class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like:
>
> src="https://use
On Wed, 16 Nov 2022 16:38:10 GMT, Alan Bateman wrote:
>> In our experience with using the API, having exceptions when something is
>> funny about close is very valuable info (as also stated in the javadoc).
>> Almost always there's a subtle temporal bug going on which the ISE catches.
>> I'm n
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
CallSite class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202234105-8029ade2-4feb-456c-a010-b801
On Wed, 16 Nov 2022 13:12:49 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/runtime/TemplateRuntime.java line 115:
>
>> 113:
On Tue, 15 Nov 2022 18:47:39 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 16 Nov 2022 16:01:52 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typo in SegmentScope javadoc
>
> src/java.base/share/classes/java/lang/foreign/Arena.java line 132:
>
>> 13
On Wed, 16 Nov 2022 14:38:18 GMT, Alan Bateman wrote:
> Are you sure this is right place to do this? There are other "launcher
> options" that aren't passed through to CreateJavaVM and I'm surprised this
> one is.
I've found this place as a single spot handling (or skipping) tons of options
a
> Pull in linker implementation changes, that include non-trivial changes to VM
> code, from the panama-foreign repo into the main JDK.
>
> This is split off from the main JEP integration to make reviewing easier.
>
> This includes the following patches:
>
> 1. https://github.com/openjdk/panama
On Tue, 15 Nov 2022 18:47:39 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 16 Nov 2022 15:41:06 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/StringTemplate.java line 273:
>
>> 271:
On Mon, 14 Nov 2022 17:51:24 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
On Tue, 15 Nov 2022 19:15:21 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Wed, 16 Nov 2022 11:38:10 GMT, Maurizio Cimadamore
wrote:
>> Mm, but this is the type of the value of the `ScopedValue` instance.
>> So, the type of the scoped value is `ScopedValue`, the type of the value
>> is `T`, is it not?
>
> Right - there's "scoped value" which is the holder, and "val
On Wed, 16 Nov 2022 14:02:32 GMT, Weibing Xiao wrote:
>> print warning message for java.io.tmpdir when it is set through the command
>> line and the value is not good for creating file folder.
>
> Weibing Xiao has updated the pull request incrementally with one additional
> commit since the las
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
ConstantDesc class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
https://user-images.githubusercontent.com/7457876/202216017-ec996722-2956-4b0a-adb5
On Wed, 16 Nov 2022 12:34:29 GMT, Adam Sotona wrote:
> Option --disable-@files is not recognised as valid JVM option, however it is
> already implemented in the launcher.
> Proposed patch skips --disable-@files option in
> src/hotspot/share/runtime/arguments.cpp processing, so it does not fall
On 16/11/2022 04:15, Jaikiran Pai wrote:
There's https://bugs.openjdk.org/browse/JDK-8225763. I plan to revive
that effort some time soon, it's been on my todo list for the past few
months.
Just to add to Jai's comment is that there is more to this that adding a
close method that calls end. T
On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incr
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Oops
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/222ddcbc..2a2b0cca
We
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Maurizio Cimadamore
<54672762+mcimadam...@use
On Tue, 15 Nov 2022 19:02:30 GMT, Weibing Xiao wrote:
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
1) Removed the link for CSR.
2) Add a new method in SystemProps.java to check if the warning message is
> print warning message for java.io.tmpdir when it is set through the command
> line and the value is not good for creating file folder.
Weibing Xiao has updated the pull request incrementally with one additional
commit since the last revision:
the change according to review comment
On Wed, 16 Nov 2022 00:44:50 GMT, Bo Zhang wrote:
>> As described in [JDK-8296329](https://bugs.openjdk.org/browse/JDK-8296329),
>> previously, the jar validator compare the "version" to validate a
>> multi-release jar. The "version" is a mix of the major and minor version
>> fused into a sing
On Wed, 16 Nov 2022 12:50:04 GMT, ExE Boss wrote:
> Note that `ScopedValue` can currently be bound to `null`, but by using
> `Optional`, there would be no way to differentiate an unbound `ScopedValue`
> from one bound to `null`.
That's right, an Optional view would have to deal with that.
---
On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incr
On Wed, 16 Nov 2022 03:54:31 GMT, Serguei Spitsyn wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 564:
>
>> 562:
>> 563: for (int i = 0; i
On Wed, 16 Nov 2022 12:11:45 GMT, Maurizio Cimadamore
wrote:
>> We expect isBound() will be used a lot and I think that is clearer (and
>> cheaper) than find().isEmpty().
>>
>> Time will tell on orElse/orElseThrow and whether they should be replaced
>> with an Optional view. That is, I think
Option --disable-@files is not recognised as valid JVM option, however it is
already implemented in the launcher.
Proposed patch skips --disable-@files option in
src/hotspot/share/runtime/arguments.cpp processing, so it does not fall into
the category of unknown options.
The patch also corrects
May I get a final (PR) review of JDK-8285932 Implementation of JEP-430 String
Templates (Preview) from core-libs and compiler.
PR: https://github.com/openjdk/jdk/pull/10889
JBS: https://bugs.openjdk.org/browse/JDK-8285932
CSR: https://bugs.openjdk.org/browse/JDK-8286021
JEP: https://openjdk.or
On Wed, 16 Nov 2022 12:01:58 GMT, Alan Bateman wrote:
>> IMHO there are ways to have the cake and eat it too. That is, we could have
>> a couple of overloads:
>>
>>
>> T get() { ... } // throws NSME if not found
>> Optional find() // returns empty optional if not found
>>
>>
>> Then, for sim
On Wed, 16 Nov 2022 11:41:49 GMT, Maurizio Cimadamore
wrote:
>> It certainly would look odd. This API is, by design, as lightweight as it
>> possibly can be, both from an implementation and a user's point of view.
>> It's also intended to be as close as possible to an "invisible" parameter
>>
On Wed, 16 Nov 2022 11:03:07 GMT, Andrew Haley wrote:
>> Yes, my comment was really on `get` - that said, I note that saying
>> get().get() would look odd (but maybe finding some other name for
>> `ScopedValue::get`, such as `find` might work)
>
> It certainly would look odd. This API is, by de
On Wed, 16 Nov 2022 10:57:49 GMT, Andrew Haley wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 185:
>>
>>> 183: * would have to be regenerated after a blocking operation.
>>> 184: *
>>> 185: * @param the type of the value
>>
>> Suggest
On Tue, 15 Nov 2022 21:28:29 GMT, Maurizio Cimadamore
wrote:
>> This comment is on orElse but I suspect you are suggesting that get() be
>> changed to return Optional. I think we'll need to get more feedback/usage of
>> this API before re-visiting that.
>
> Yes, my comment was really on `get`
On Tue, 15 Nov 2022 18:35:06 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Tue, 15 Nov 2022 20:11:36 GMT, Alan Bateman wrote:
> I'd prefer to keep this as is because it's too much to use "threads" or
> mention inheritance in the first paragraph.
I agree.
-
PR: https://git.openjdk.org/jdk/pull/10952
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
Co-authored-by: Maurizio Cimadamore
<54672762+mcimadam...@use
99 matches
Mail list logo
