RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-12 Thread Julian Waters
After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ code across the JDK can be replaced and simplified with cleaner language features that were previously not available due to required compatibility with

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v17]

2022-11-12 Thread Jim Laskey
On Sat, 12 Nov 2022 07:17:30 GMT, danieljarabek wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Requested changes #5 > > src/java.base/share/classes/java/util/FormatterBuilder.java line 52: > >> 50: /** >> 51: * Th

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-11-12 Thread Piotr Tarsa
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote: >> Continuing the work initiated by @luhenry to unroll and then intrinsify >> polynomial hash loops. >> >> I've rewired the library changes to route via a single `@IntrinsicCandidate` >> method. To make this work I've harmonized how they

Re: RFR: JDK-8262435: Clarify the behavior of a few inherited ZipInputStream methods [v3]

2022-11-12 Thread Alan Bateman
On Fri, 11 Nov 2022 18:56:36 GMT, Lance Andersen wrote: >> Please review the following PR which updates several of the ZipInputStream >> methods whose javadoc is inherited to clarify the methods are acting on >> the current ZIP Entry. >> >> There are no changes in behavior. The main descrip

Re: RFR: JDK-8262435: Clarify the behavior of a few inherited ZipInputStream methods [v2]

2022-11-12 Thread Alan Bateman
On Fri, 11 Nov 2022 18:51:49 GMT, Lance Andersen wrote: > Thanks for the suggestion. I made another pass to make the phrasing more > consistent Good, I think it looks much better now except for the "available" method which doesn't fully specify the cases for when it returns 0. -