On Wed, 2 Nov 2022 15:11:36 GMT, Aleksey Shipilev wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additional commits since
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request incrementally with one additional commit
since the last rev
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request incrementally with two additional commits
since the last re
On Wed, 5 Oct 2022 03:40:27 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
On Wed, 2 Nov 2022 19:44:00 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Wed, 2 Nov 2022 21:30:23 GMT, Jorn Vernee wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Internalize TemplateSupport
>
> src/java.base/share/classes/jdk/internal/template/TemplateSupport.java line
> 147:
>
>> 1
On Tue, 1 Nov 2022 00:09:21 GMT, David Schlosnagle wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 201:
>
>>
On Wed, 2 Nov 2022 19:44:00 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote:
> Hi
>
> Please review this update to the jar man page which removes the "=" for the
> non GNU style options
>
> Best
> Lance
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10947
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> This PR will update the javadoc to clarify the existing behavior of
>> InflaterInputStream::fill as it currently omits the possibility that a
>> EOFException may be thrown and that the protected `len` field is also
>> upd
On Wed, 2 Nov 2022 20:42:42 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> This PR will update the javadoc to clarify the existing behavior of
>> InflaterInputStream::fill as it currently omits the possibility that a
>> EOFException may be thrown and that the protected `len` field is also
>> upd
On Wed, 2 Nov 2022 20:12:04 GMT, Alan Bateman wrote:
> Thanks for the update, this wording looks okay, I'm just wondering if we
> should add implSpec as "This method will read ..." is really "Implementation
> Specification".
Sure thing added the tag
-
PR: https://git.openjdk.org/
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen has updated the pull reque
On Wed, 2 Nov 2022 19:11:32 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> This PR will update the javadoc to clarify the existing behavior of
>> InflaterInputStream::fill as it currently omits the possibility that a
>> EOFException may be thrown and that the protected `len` field is also
>> upd
On Wed, 2 Nov 2022 19:44:00 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Wed, 2 Nov 2022 20:00:55 GMT, Joe Wang wrote:
>> Fixed an issue where the condition check for limit=0 was missed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> source changes
Marked as reviewed by naoto (Reviewer).
-
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote:
> Hi
>
> Please review this update to the jar man page which removes the "=" for the
> non GNU style options
>
> Best
> Lance
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10947
On Wed, 2 Nov 2022 20:00:55 GMT, Joe Wang wrote:
>> Fixed an issue where the condition check for limit=0 was missed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> source changes
Looks fine as discussed
-
Marked
> Fixed an issue where the condition check for limit=0 was missed.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
source changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10958/files
- new: https://git.openjdk.
On Wed, 2 Nov 2022 19:32:47 GMT, Joe Wang wrote:
> Fixed an issue where the condition check for limit=0 was missed.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10958
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
Fixed an issue where the condition check for limit=0 was missed.
-
Commit messages:
- 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for
namespace names
Changes: https://git.openjdk.org/jdk/pull/10958/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1095
On Wed, 2 Nov 2022 17:49:58 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalua
On Wed, 2 Nov 2022 17:21:11 GMT, Jorn Vernee wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 184:
>
>> 182:
On Tue, 1 Nov 2022 00:09:21 GMT, David Schlosnagle wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 201:
>
>>
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of evalu
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen has updated the pull reque
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen has updated the pull reque
On Tue, 1 Nov 2022 17:33:30 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/util/FormatProcessor.java line 118:
>
>> 116:
On Wed, 2 Nov 2022 18:27:30 GMT, Jim Laskey wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java
>> line 429:
>>
>>> 427: }
>>> 428:
>>> 429: private JCClassDecl newStringTemplateClass() {
>>
>> I find it weird to have the compiler emit an imple
On Wed, 2 Nov 2022 17:17:40 GMT, Alan Bateman wrote:
> I don't think an apiNote will work here as it need to be normative text. I
> suspect this issue will require specifying fill to read up to buf.length
> bytes into buf starting at element 0 and setting len to the number of bytes.
Revised pe
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen has updated the pull reque
- Original Message -
> From: "Remi Forax"
> To: "Stuart Marks"
> Cc: "core-libs-dev"
> Sent: Wednesday, November 2, 2022 7:27:02 PM
> Subject: Re: [External] : Re: New candidate JEP: 431: Sequenced Collections
There is also the issue with equals/hashCode.
You can test the equality of t
On Tue, 1 Nov 2022 12:57:03 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java
> li
- Original Message -
> From: "Stuart Marks"
> To: "Remi Forax"
> Cc: "core-libs-dev"
> Sent: Saturday, October 29, 2022 2:16:06 AM
> Subject: Re: [External] : Re: New candidate JEP: 431: Sequenced Collections
[...]
>
> You seem to be talking about introduction of new types in oppositi
On Tue, 1 Nov 2022 12:50:52 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java
> li
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote:
> Hi
>
> Please review this update to the jar man page which removes the "=" for the
> non GNU style options
>
> Best
> Lance
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10947
On Wed, 5 Oct 2022 03:40:27 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
On Fri, 28 Oct 2022 18:47:54 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update TemplateRuntime::combine
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/Scanner.java line
On Tue, 1 Nov 2022 12:41:19 GMT, Maurizio Cimadamore
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java
> li
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluating that expression, possibly after further validation a
On Tue, 1 Nov 2022 18:22:07 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 119:
>>
>>> 117: Class tsClass = st.getClass();
>>> 118: if (tsClass.isSynthetic()) {
>>> 119: try {
>>
>> I do not know if this code is wor
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote:
> Issue: Duplication of methods between Basic*.java test classes, due to auto
> generation by genBasic.sh
>
> Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java.
> Toggled -nel flag for generation script (genBasic.sh)
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> b
On Wed, 2 Nov 2022 04:10:43 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR includes changes in the resource bundle
> sources to follow the time zone change observed in America/Chihuahua and
> America/Ojinaga.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> b
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull reques
Hi
Please review this update to the jar man page which removes the "=" for the non
GNU style options
Best
Lance
-
Commit messages:
- add space for -i option
- add space between option
- address typos in jar man page
Changes: https://git.openjdk.org/jdk/pull/10947/files
Webrev:
Hi all,
This PR will update the javadoc to clarify the existing behavior of
InflaterInputStream::fill as it currently omits the possibility that a
EOFException may be thrown and that the protected `len` field is also updated
by this method.
-
Commit messages:
- Clarify the javado
On Tue, 1 Nov 2022 16:14:20 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
On Mon, 31 Oct 2022 09:52:06 GMT, Alan Bateman wrote:
>> **TL;DR:** Your optimization is now contained in this PR and outperforms the
>> previous code. Nevertheless I plead for Alternative C (double buffering)
>> instead, which is even faster but much simpler.
>>
>> **Justification**
>>
>> I
53 matches
Mail list logo
