Re: RFR: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259

2022-10-15 Thread Alan Bateman
On Wed, 12 Oct 2022 16:30:07 GMT, Roger Riggs wrote: > Process.waitFor() throws IllegalThreadStateException when a process returns > an exit code of 259. > As described in the bug report, `waitFor()` should not be sensitive to the > exit value. > Previously, it erroneously threw IllegalStateExc

Re: [External] : Re: New candidate JEP: 431: Sequenced Collections

2022-10-15 Thread Stuart Marks
Hi Rémi, On 10/14/22 1:20 AM, Remi Forax wrote: People will again think that i'm the grumpy guy but i prefer to voice my concerns. - nobody cares, i'm back from Devoxx and nobody cares about Sequenced Collections, i've tried to ask several friends what they think about it and the answer was "

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set

2022-10-15 Thread Alan Bateman
On Mon, 3 Oct 2022 05:50:50 GMT, Alan Bateman wrote: >> I think the leak is actually not a problem. >> `ByteArrayInputStream::transferTo` does the same BTW, see >> https://github.com/openjdk/jdk/blob/68da02c7b536799ccca49e889c22f3e9a2691fb7/src/java.base/share/classes/java/io/ByteArrayInputStre

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

2022-10-15 Thread Markus KARG
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Checking explicitly -1 instead of < 0 So how to go on? - PR: https://git.o

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-15 Thread Alan Bateman
On Sat, 15 Oct 2022 09:47:52 GMT, Sean Coffey wrote: > Seems like there's a difference of opinion on when such a configuration issue > should be reported. Reporting at start up will cost cycles (esp since there's > an IO stat call) Maybe we can revert the patch to the original style which is >

Re: RFR: 8294696 - BufferedInputStream.transferTo should drain buffer when mark set [v2]

2022-10-15 Thread Markus KARG
On Mon, 3 Oct 2022 05:54:31 GMT, Markus KARG wrote: >> This PR implements JDK-8294696. > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Checking explicitly -1 instead of < 0 > > Isn't a test needed here which fails without b

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v4]

2022-10-15 Thread Sean Coffey
On Fri, 14 Oct 2022 19:25:54 GMT, Weibing Xiao wrote: >> 8290313: Produce warning when user specified java.io.tmpdir directory >> doesn't exist > > Weibing Xiao has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 11 commits: > > - Me

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v3]

2022-10-15 Thread Tagir F . Valeev
On Fri, 14 Oct 2022 02:20:43 GMT, jmehrens wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes according to review >> >> 1. Reduce duplication in tests >> 2. Use JumpableGenerator#copy() instead of crea