Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2022-10-13 Thread Jaikiran Pai
On Thu, 13 Oct 2022 21:15:16 GMT, Oliver Kopp wrote: > Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split u

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData [v2]

2022-10-13 Thread Vladimir Ivanov
On Fri, 14 Oct 2022 04:37:22 GMT, Ioi Lam wrote: >> Please review this small optimization. As shown in the JBS issue, most of >> the generated LambdaForm classes have a single ClassData, so we can get a >> small footprint/speed improvement. > > Ioi Lam has updated the pull request incrementally

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData [v2]

2022-10-13 Thread Ioi Lam
On Thu, 13 Oct 2022 22:29:03 GMT, Vladimir Ivanov wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iwanowww comments > > src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java > line 321: > >> 319:

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData [v2]

2022-10-13 Thread Ioi Lam
> Please review this small optimization. As shown in the JBS issue, most of the > generated LambdaForm classes have a single ClassData, so we can get a small > footprint/speed improvement. Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v3]

2022-10-13 Thread jmehrens
On Wed, 12 Oct 2022 13:26:29 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >> conven

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-13 Thread Brent Christian
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote: > Issue: java/util/Formatter/Basic regression test emits lots of warning > messages (~60). > > Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files > where the errors originate from are generated from the template. > >

Integrated: 8295017: Remove Windows specific workaround in JLI_Snprintf

2022-10-13 Thread Julian Waters
On Sun, 9 Oct 2022 08:03:36 GMT, Julian Waters wrote: > The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago

Re: RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData

2022-10-13 Thread Vladimir Ivanov
On Thu, 13 Oct 2022 21:53:47 GMT, Ioi Lam wrote: > Please review this small optimization. As shown in the JBS issue, most of the > generated LambdaForm classes have a single ClassData, so we can get a small > footprint/speed improvement. src/java.base/share/classes/java/lang/invoke/InvokerByte

RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-13 Thread Justin Lu
Issue: java/util/Formatter/Basic regression test emits lots of warning messages (~60). Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files where the errors originate from are generated from the template. Note: The reason why there is white space added (and already existi

RFR: 8295302: Do not use ArrayList when LambdaForm has a single ClassData

2022-10-13 Thread Ioi Lam
Please review this small optimization. As shown in the JBS issue, most of the generated LambdaForm classes have a single ClassData, so we can get a small footprint/speed improvement. - Commit messages: - 8295302: Do not use ArrayList when LambdaForm has a single ClassData Changes:

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder()

2022-10-13 Thread ExE Boss
On Sat, 20 Aug 2022 19:17:18 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/util/TreeMap.java line 3318: >> >>> 3316: // Adapt or create a key-based comparator >>> 3317: Comparator treeComparator = tree.comparator; >>> 3318: return Map.Entry.co

RFR: 8240567: MethodTooLargeException thrown while creating a jlink image

2022-10-13 Thread Oliver Kopp
Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): "MethodTooLargeException thrown while creating a jlink image". Java still has a 64kb limit: A method may not be longer than 64kb. The idea of the fix is to split up the generated methods in several smaller methods -

Integrated: 8295173: (tz) Update Timezone Data to 2022e

2022-10-13 Thread David Alvarez
On Wed, 12 Oct 2022 00:01:50 GMT, David Alvarez wrote: > Please, review this PR for an update of timezone data. No changes besides the > import were needed. This pull request has now been integrated. Changeset: 21407dec Author:David Alvarez Committer: Paul Hohensee URL: https://gi

Re: RFR: 8292177: InitialSecurityProperty JFR event [v6]

2022-10-13 Thread Sean Mullan
On Thu, 13 Oct 2022 19:53:27 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request incrementally with two additional

Re: RFR: 8292177: InitialSecurityProperty JFR event [v5]

2022-10-13 Thread Sean Coffey
On Thu, 13 Oct 2022 19:19:05 GMT, Sean Mullan wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 17 commits: >> >> - test update >> - Merge branch 'master' into secEvent-8292177 >> - Use stringPropertyNames()

Re: RFR: 8292177: InitialSecurityProperty JFR event [v6]

2022-10-13 Thread Sean Coffey
> New JFR event to record state of initial security properties. > > Debug output is also now added for these properties via > -Djava.security.debug=properties Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - remove previous edit -

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v4]

2022-10-13 Thread Aleksei Efimov
> ### Summary of the change > This change introduces new system and security properties for specifying > factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider > implementations. > > These new properties allow more granular control over the set of object > factories allowed to reconst

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Aleksei Efimov
On Thu, 13 Oct 2022 12:37:36 GMT, Jaikiran Pai wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change checkInput to be the global filter centric > > src/java.base/share/conf/security/java.security line 1423: > >

Re: RFR: 8292177: InitialSecurityProperty JFR event [v5]

2022-10-13 Thread Sean Mullan
On Thu, 13 Oct 2022 16:06:13 GMT, Sean Coffey wrote: >> New JFR event to record state of initial security properties. >> >> Debug output is also now added for these properties via >> -Djava.security.debug=properties > > Sean Coffey has updated the pull request with a new target base due to a

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Aleksei Efimov
On Thu, 13 Oct 2022 13:18:58 GMT, Jaikiran Pai wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change checkInput to be the global filter centric > > src/java.naming/share/classes/javax/naming/spi/NamingManager.ja

Re: RFR: 8295173: (tz) Update Timezone Data to 2022e [v2]

2022-10-13 Thread Naoto Sato
On Wed, 12 Oct 2022 04:35:08 GMT, David Alvarez wrote: >> Please, review this PR for an update of timezone data. No changes besides >> the import were needed. > > David Alvarez has updated the pull request incrementally with one additional > commit since the last revision: > > Update display

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v9]

2022-10-13 Thread Brian Burkhalter
On Fri, 26 Aug 2022 22:20:24 GMT, Brian Burkhalter wrote: >> Modify native multi-byte read-write code used by the `java.io` classes to >> limit the size of the allocated native buffer thereby decreasing off-heap >> memory footprint and increasing throughput. > > Brian Burkhalter has updated the

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Aleksei Efimov
On Thu, 13 Oct 2022 12:29:54 GMT, Jaikiran Pai wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change checkInput to be the global filter centric > > src/java.naming/share/classes/com/sun/naming/internal/ObjectFac

Re: JEP400 vs new Scanner(System.in)

2022-10-13 Thread Ron Pressler
Hi. The appropriate list is core-libs-dev, where this discussion should continue. System.in is the standard input, which may or may not be the keyboard. For keyboard input, take a look at the java.io.Console class [1], in particular its charset and reader methods. [1]: https://docs.oracle.com

Integrated: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-13 Thread Naoto Sato
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. This pull request has now been integrated. Changeset: 4224d

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily [v2]

2022-10-13 Thread Naoto Sato
> Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Remo

Re: RFR: 8292177: InitialSecurityProperty JFR event [v3]

2022-10-13 Thread Sean Coffey
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote: >> @seanjmullan - I looked at that approach. The >> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may >> trigger early initialization of the `java.security.Security` class - I'm not >> sure if we want that. Protection

Re: RFR: 8292177: InitialSecurityProperty JFR event [v5]

2022-10-13 Thread Sean Coffey
> New JFR event to record state of initial security properties. > > Debug output is also now added for these properties via > -Djava.security.debug=properties Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-13 Thread Naoto Sato
On Thu, 13 Oct 2022 10:33:32 GMT, Sean Coffey wrote: >> Fixed to utilize `StaticProperty` so that the system property value for >> `java.locale.useOldISOCodes` set on the command line is honored even with >> lazy `Locale` initialization. > > src/java.base/share/classes/sun/util/locale/BaseLocal

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v3]

2022-10-13 Thread Julian Waters
On Tue, 11 Oct 2022 02:01:12 GMT, David Holmes wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

2022-10-13 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Roger Riggs
On Thu, 13 Oct 2022 12:34:47 GMT, Jaikiran Pai wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change checkInput to be the global filter centric > > src/java.base/share/conf/security/java.security line 1408: > >

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation [v3]

2022-10-13 Thread Jaikiran Pai
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote: >> ### Summary of the change >> This change introduces new system and security properties for specifying >> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider >> implementations. >> >> These new properties allow more granula

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-13 Thread Sean Coffey
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Marked as reviewed by coffeys (Reviewer). src/java.base/sha

Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder()

2022-10-13 Thread Сергей Цыпанов
On Wed, 17 Aug 2022 11:23:57 GMT, Сергей Цыпанов wrote: > We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is > constructed without comparator. This allows to squash two branches in > `TreeMap.get()` into one. > > P.S. I think the comment of `TreeMap.getEntryUsingComp

Re: RFR: 8293409: [vectorapi] Intrinsify VectorSupport.indexVector

2022-10-13 Thread Xiaohong Gong
On Thu, 13 Oct 2022 07:18:24 GMT, Jatin Bhateja wrote: >> "`VectorSupport.indexVector()`" is used to compute a vector that contains >> the index values based on a given vector and a scale value (`i.e. index = >> vec + iota * scale`). This function is widely used in other APIs like >> "`VectorM

Re: RFR: 8293409: [vectorapi] Intrinsify VectorSupport.indexVector

2022-10-13 Thread Jatin Bhateja
On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote: > "`VectorSupport.indexVector()`" is used to compute a vector that contains the > index values based on a given vector and a scale value (`i.e. index = vec + > iota * scale`). This function is widely used in other APIs like > "`VectorMask.