Integrated: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Darragh Clarke
On Fri, 7 Oct 2022 14:14:13 GMT, Darragh Clarke wrote: > Added an int cast for the `timeoutLeft` assignment, looking through the code > and other uses of the variable it seems to show no issues with lossy > conversion. As part of this I removed the file to disable the conversion > warning > >

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v2]

2022-10-07 Thread Mahendra Chhipa
> Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: htt

Re: RFR: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Aleksei Efimov
On Fri, 7 Oct 2022 14:14:13 GMT, Darragh Clarke wrote: > Added an int cast for the `timeoutLeft` assignment, looking through the code > and other uses of the variable it seems to show no issues with lossy > conversion. As part of this I removed the file to disable the conversion > warning > >

Re: RFR: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Roger Riggs
On Fri, 7 Oct 2022 14:14:13 GMT, Darragh Clarke wrote: > Added an int cast for the `timeoutLeft` assignment, looking through the code > and other uses of the variable it seems to show no issues with lossy > conversion. As part of this I removed the file to disable the conversion > warning > >

RFR: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Darragh Clarke
Added an int cast for the `timeoutLeft` assignment, looking through the code and other uses of the variable it seems to show no issues with lossy conversion. As part of this I removed the file to disable the conversion warning I tested this build and it doesn't give any warnings on this file --

Re: RFR: 8291917: Windows - Improve error messages when the C Runtime Libraries or jvm.dll cannot be loaded [v4]

2022-10-07 Thread Julian Waters
On Sun, 7 Aug 2022 07:57:49 GMT, Thomas Stuefe wrote: >> Nothing I could find in the tests that suggest they use this message as >> input, and none of them have failed with this patch, so I guess that's a >> good thing? :P >> >> I am slightly concerned with going the route of 2 different calls

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-10-07 Thread Alan Bateman
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Integrated: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

2022-10-07 Thread Alan Bateman
On Tue, 4 Oct 2022 17:59:36 GMT, Alan Bateman wrote: > This is a test only change for two tests for virtual threads that > hang/timeout on single core systems. The two tests involve pinning and > require at least two carrier threads. The test lib used by these tests is > updated to define a ne