On Wed, 28 Sep 2022 20:39:03 GMT, Andrey Turbanov wrote:
> Found this redundant suppressions by IntelliJ IDEA inspection.
> It seems [JDK-8189330](https://bugs.openjdk.org/browse/JDK-8189330) made them
> redundant.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
LGTM
-
Marked as reviewed by coffeys (Reviewer).
PR: https://git.
Thanks for catching that Iris; I'll changes those to git URLs.
-Joe
On 9/29/2022 9:11 PM, Iris Clark wrote:
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
With the domain change from openjdk.java.net to openjdk.org, references to URLs
in the sources should be updated.
Updates were made
On Fri, 30 Sep 2022 04:17:54 GMT, Naoto Sato wrote:
>> Please review this PR. The change include some code changes in
>> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
>> TestZoneInfo310.java.
>
> test/jdk/java/util/TimeZone/TimeZoneData/displaynames.txt line 170:
>
>> 16
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
test/jdk/java/util/TimeZone/TimeZoneData/displaynames.txt line 170:
> 168: Euro
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated th
On Fri, 30 Sep 2022 00:25:24 GMT, Lance Andersen wrote:
> > > Understand, I guess I don't see the difference from moving the tags to
> > > the actual test but there could be a subtlety I am missing (wouldn't be
> > > the first time ;-) )
> >
> >
> > The runner has a @library/@build tag to bui
On Thu, 29 Sep 2022 18:34:41 GMT, Vladimir Kozlov wrote:
>> @vnkozlov I have addressed all review comments. Could you please run the
>> patch through your testing? Thanks a lot for all the help.
>
> @smita-kamath I have builds failures. Please, build and test yourself to
> verify changes.
>
>
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote:
> Switch to https where needed/applicable while at it?
Good idea; might as well do the update in a single changeset.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with one additional commit
sinc
While the floating-point == operation is *not* an equivalence relation, there
are useful equivalence relations that can be defined over floating-point
values. Text is added to java.lang.Double to discuss and name those relations.
-
Commit messages:
- JDK-8294539: Augment discussion
On Thu, 29 Sep 2022 22:14:24 GMT, Joe Darcy wrote:
> While the floating-point == operation is *not* an equivalence relation, there
> are useful equivalence relations that can be defined over floating-point
> values. Text is added to java.lang.Double to discuss and name those relations.
src/jav
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with one additional commit
sinc
On Fri, 30 Sep 2022 00:50:13 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated th
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with two additional
commits sin
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Switch to https where needed/app
On Wed, 28 Sep 2022 15:36:50 GMT, Viktor Klang wrote:
> This JavaDoc change attempts to shine some light on the `combiner`-function
> as it relates to the third variant of `Stream.reduce` since it according to
> the bug submission in JBS can be confusing that the `combiner` is not
> mentioned
With the domain change from openjdk.java.net to openjdk.org, references to URLs
in the sources should be updated.
Updates were made using a shell script. I"ll run a copyright updater before any
push.
-
Commit messages:
- JDK-8294618: Update openjdk.java.net => openjdk.org
Changes
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
Some minor comments
src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.
Please review this PR. The change include some code changes in
ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
TestZoneInfo310.java.
-
Commit messages:
- Added minor changes in comment lines
- reverting irrelvant change in pom.xml
- 1st commit for tz2022d
Ch
On Thu, 29 Sep 2022 22:29:10 GMT, Naoto Sato wrote:
> > Understand, I guess I don't see the difference from moving the tags to the
> > actual test but there could be a subtlety I am missing (wouldn't be the
> > first time ;-) )
>
> The runner has a @library/@build tag to build the test case as
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote:
> Problem: Amendment number outdated
>
> Fix: Update amendment number + date in properties file and test case data file
looks good to me
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10499
On Thu, 29 Sep 2022 18:34:41 GMT, Vladimir Kozlov wrote:
>> @vnkozlov I have addressed all review comments. Could you please run the
>> patch through your testing? Thanks a lot for all the help.
>
> @smita-kamath I have builds failures. Please, build and test yourself to
> verify changes.
>
>
On Thu, 29 Sep 2022 18:34:41 GMT, Vladimir Kozlov wrote:
>> @vnkozlov I have addressed all review comments. Could you please run the
>> patch through your testing? Thanks a lot for all the help.
>
> @smita-kamath I have builds failures. Please, build and test yourself to
> verify changes.
>
>
Problem: Amendment number outdated
Fix: Update amendment number + date in properties file and test case data file
-
Commit messages:
- Update amendment number in test case data file
- Update amendment number
Changes: https://git.openjdk.org/jdk/pull/10499/files
Webrev: https://we
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Tweak indentat
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
On Thu, 29 Sep 2022 22:19:26 GMT, Lance Andersen wrote:
> Understand, I guess I don't see the difference from moving the tags to the
> actual test but there could be a subtlety I am missing (wouldn't be the first
> time ;-) )
The runner has a @library/@build tag to build the test case as a lib
On Thu, 29 Sep 2022 22:07:48 GMT, Naoto Sato wrote:
> AFAICT, the reason is described in the test class description, i.e., tweak to
> be in `java.text` package so that it can test the internal `hashCode` method.
Understand, I guess I don't see the difference from moving the tags to the
actual
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust typo wi
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
AFAICT, the reason is described in the test class description, i.e., t
On Thu, 29 Sep 2022 21:49:05 GMT, Brent Christian wrote:
> > should we update
> > test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> > to include `@test, @bug, @run, @summary`?
>
> ```
> /*
> (this test doesn't have an at-test tag because it's run by
> Bug4
On Thu, 29 Sep 2022 21:34:24 GMT, Lance Andersen wrote:
> should we update
> test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> to include `@test, @bug, @run, @summary`?
Brent actually pointed that out to me as well. I believe since
Bug4170614Test.java is manag
On Thu, 29 Sep 2022 21:48:52 GMT, Justin Lu wrote:
> should we update
> test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> to include `@test, @bug, @run, @summary`?
/*
(this test doesn't have an at-test tag because it's run by
Bug4170614TestRun.java
i
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Looks good.
should we update
test/jdk/sun/text/IntHashtable/patch-sr
Problem: Unnecessary instances of StringBuffer within java.text (internal only)
Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
names
-
Commit messages:
- Update PatternEntry test case for StringBuilder
- Copyright update
- Replace buffer in both, adju
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to the preview page to add a list of preview
>> features and allow users to explore the preview APIs by feature.
>>
>> While the changes for the enhancement itself are not overly complex, the
>> work ent
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Wed, 10 Aug 2022 02:10:25 GMT, xpbob wrote:
>> Container configuration information is useful for troubleshooting
>> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
>> and other scenarios.
>> Results the following
>>  {
> case String s when s.isEmpty() -> {}
> case String s
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to the preview page to add a list of preview
>> features and allow users to explore the preview APIs by feature.
>>
>> While the changes for the enhancement itself are not overly complex, the
>> work ent
On Thu, 29 Sep 2022 18:17:18 GMT, Naoto Sato wrote:
>> I agree skipping the test is not the best solution. Leaving a hint in the
>> comments on how to fix the issue looks better alternative.
>
> Well, what concerns me with the current fix is that it is simply patching
> only the case for the Ja
On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov
wrote:
> Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic
> turned out to be profitable on RISC-V using the same fclass instruction as
> for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it
> ad
On Thu, 29 Sep 2022 16:05:44 GMT, Matthias Baesken wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>> com.sap.nw.performance.supa.client
On Thu, 22 Sep 2022 17:20:02 GMT, Joe Darcy wrote:
>> Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic
>> turned out to be profitable on RISC-V using the same fclass instruction as
>> for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it
>> added
On Thu, 29 Sep 2022 17:45:49 GMT, Smita Kamath wrote:
>> tier2 and 3 passed. I will wait update with test and JVMCI fix before doing
>> more testing.
>
> @vnkozlov I have addressed all review comments. Could you please run the
> patch through your testing? Thanks a lot for all the help.
@smita
On Thu, 29 Sep 2022 16:29:54 GMT, Paul Sandoz wrote:
>> This JavaDoc change attempts to shine some light on the `combiner`-function
>> as it relates to the third variant of `Stream.reduce` since it according to
>> the bug submission in JBS can be confusing that the `combiner` is not
>> mention
This is a test only change to split the execution of some of the larger tests
for virtual threads and reduce the execution time of a few others.
The tests StructuredTaskScopeTest, ThreadFockTest and ThreadPerTaskExecutorTest
contain a lot of tests and run with thread factories for both platform
On Thu, 29 Sep 2022 16:47:01 GMT, Alexey Semenyuk wrote:
>> I am sorry to misunderstand your comment.
>>
>> I don’t know whether "é"(0x00e9) exists only in "Cp1252", "UTF-8".
>> Will that be no problem that this test is skipped in other encordings? If
>> skipped, the pattern for its encording
On Wed, 28 Sep 2022 17:40:36 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed revi
On Wed, 21 Sep 2022 16:41:19 GMT, Vladimir Kozlov wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> tier2 and 3 passed. I will wait update with test and JVMCI fix before doing
> more te
Found this redundant suppressions by IntelliJ IDEA inspection.
It seems [JDK-8189330](https://bugs.openjdk.org/browse/JDK-8189330) made them
redundant.
-
Commit messages:
- [PATCH] Remove redundant unchecked suppression in FileDescriptor
Changes: https://git.openjdk.org/jdk/pull/10
On Thu, 29 Sep 2022 15:01:25 GMT, Roger Riggs wrote:
> Correct javadoc links and references.
>
> The links should refer to the method `()` instead of field.
>
> The apiNote in `getErrorStream` should refer to the error stream not the
> input stream and reader.
Marked as reviewed by iris (Revi
Correct javadoc links and references.
The links should refer to the method `()` instead of field.
The apiNote in `getErrorStream` should refer to the error stream not the input
stream and reader.
-
Commit messages:
- 8294533: Documentation mistake in Process::getErrorStream and ge
On Thu, 29 Sep 2022 08:04:07 GMT, KIRIYAMA Takuya wrote:
>> test/jdk/tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java line
>> 55:
>>
>>> 53: String encoding = System.getProperty("native.encoding");
>>> 54: switch (encoding) {
>>> 55: default:
>>
>> What I me
On Wed, 28 Sep 2022 15:36:50 GMT, Viktor Klang wrote:
> This JavaDoc change attempts to shine some light on the `combiner`-function
> as it relates to the third variant of `Stream.reduce` since it according to
> the bug submission in JBS can be confusing that the `combiner` is not
> mentioned
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client test.jar
>
> Inverse transitive dependences matching packages
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the pull
On Wed, 28 Sep 2022 17:40:36 GMT, Smita Kamath wrote:
>> 8289552: Make intrinsic conversions between bit representations of half
>> precision values and floats
>
> Smita Kamath has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed revi
On Thu, 29 Sep 2022 11:41:02 GMT, Erik Gahlin wrote:
>> As per yesterday's stack trace, JFR triggers loading of the Security class -
>> so your scenario won't arise with current state. We could include the new
>> Event with period of `endChunk `instead of `beingChunk `setting. That should
>> e
On Thu, 29 Sep 2022 13:44:40 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/native/libfdlibm/e_asin.c line 102:
>>
>>> 100: } else
>>> 101: t = x*x;
>>> 102: p = t*(pS0+t*(pS1+t*(pS2+t*(pS3+t*(pS4+t*pS5);
>>
>> should we add an opening brace
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Sure.
-
PR: https://git.openjdk.org/jdk/pull/10487
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
This looks okay, but let's wait for #10426 to integrate first?
-
PR: http
On Thu, 29 Sep 2022 13:40:37 GMT, Daniel Fuchs wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> src/java.base/share/native/libfdlibm/e_asin.c line 102:
>
>> 100: } else
>> 1
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
src/java.base/share/native/libfdlibm/e_asin.c line 102:
> 100: } else
> 10
This fixes misleading indentations, which allows enabling the (currently
disabled) `misleading-indentation` warning flag on two `.gmk` files.
-
Commit messages:
- 8294456: Fix misleading-indentation warnings in JDK
Changes: https://git.openjdk.org/jdk/pull/10487/files
Webrev: http
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
The misleading indentation might indicate the original intent of the author,
which mig
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
> the error reporting functions in libjava will look up. RUNTIME refers to
> errors passed through the runtime via errno, and SYSTEM is for native errors
> not visible to the runtime.
Julian Waters has updated the pull
> Similar issue to the hotspot change discussed in
> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation
> may get the resource limits wrong if there are additional cgroup fs mounts.
> Apparently that's more common than one might think. I've reproduced this with
> these
On Thu, 29 Sep 2022 10:02:05 GMT, Sean Coffey wrote:
>> How does it capture the event if JFR was started before the security
>> properties were read? I would think you still need some additional code in
>> Security.java to record the properties if the event is enabled.
>
> As per yesterday's st
On Wed, 28 Sep 2022 16:32:17 GMT, Sean Mullan wrote:
>> Correct - this type of event period (beginChunk) will fire once when the JFR
>> recording is begun. It should capture Security Properties (if
>> java.security.Security is loaded) for any recording, no matter when it might
>> begin or end.
> Similar issue to the hotspot change discussed in
> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation
> may get the resource limits wrong if there are additional cgroup fs mounts.
> Apparently that's more common than one might think. I've reproduced this with
> these
On Wed, 28 Sep 2022 05:45:14 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> 8293540: [Metrics] Potentially incorrectly detected resource limits with
>> additional cgroup
On Thu, 29 Sep 2022 06:55:30 GMT, Tagir F. Valeev wrote:
>> This JavaDoc change attempts to shine some light on the `combiner`-function
>> as it relates to the third variant of `Stream.reduce` since it according to
>> the bug submission in JBS can be confusing that the `combiner` is not
>> men
On Wed, 24 Aug 2022 15:48:38 GMT, Raffaello Giulietti
wrote:
> Add support for named groups to java.util.regex.MatchResult
This pull request has now been integrated.
Changeset: ce85cac9
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/ce85cac947158b4e1f554c55f726c
On Wed, 28 Sep 2022 18:00:09 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java
>> fails on Japanese Windows platform
>
> test/
79 matches
Mail list logo
