On Mon, 26 Sep 2022 17:03:40 GMT, Aleksey Shipilev wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> java.b
On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote:
> "`VectorSupport.indexVector()`" is used to compute a vector that contains the
> index values based on a given vector and a scale value (`i.e. index = vec +
> iota * scale`). This function is widely used in other APIs like
> "`VectorMask.
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Tue, 27 Sep 2022 00:15:17 GMT, Serguei Spitsyn wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into 8293592-JVM_StopThread
>> - Removal all special handling of
On Mon, 26 Sep 2022 15:47:51 GMT, Julian Waters wrote:
>> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
>> the error reporting functions in libjava will look up. RUNTIME refers to
>> errors passed through the runtime via errno, and SYSTEM is for native errors
>> no
On Thu, 22 Sep 2022 07:02:16 GMT, Hao Sun wrote:
> This warning seems to be a false positive, because 1) array "fq" with
> elements from index 0 to "jz" has already been initialized as "fw" at line
> 290 [1], and 2) variable "jz" should be non-negative from the comment at line
> 99 [2].
>
> N
> On Sep 20, 2022, at 5:50 PM, Michael Hall wrote:
>
> Still you could use post-processing to add whatever java binary executable
> commands you wanted. This again would mean changes to the embedded jdk that
> might have signing side effects. I haven’t tested.
Thinking about this I looked
On Fri, 23 Sep 2022 21:47:06 GMT, David Holmes wrote:
>> Now that Thread.stop has been degraded to throw
>> `UnsupportedOperationException` (JDK-8299610) the only direct source of
>> async exceptions is from JVMTI `StopThread`. We can remove the
>> `JVM_StopThread` code, remove the `stillborn`
On 9/26/22 11:31 AM, Ernie Rael wrote:
maybe "interface ListIteratorProvider { ListIterator listIterator(int
index); }"
Doh! I guess that should be "interface ListIterable"
On Fri, 16 Sep 2022 22:55:52 GMT, Alexander Matveev
wrote:
> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
> never set correct value in .jpackage.xml to mark image as signed.
> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
> to check
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99 [2].
>>
Problem: Unnecessary instances of StringBuffer + .toString()
Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
possible
Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
but removing that instance requires changing the RuleBasedCollationKey
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Sun, 25 Sep 2022 00:39:33 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - transformTo -> transferTo
> - wrapped long code lines
> - removed unused import
Mar
On Sat, 24 Sep 2022 12:14:49 GMT, Markus KARG wrote:
> @bplb Fixed the issues you pointed out.
@mkarg You are welcome.
-
PR: https://git.openjdk.org/jdk/pull/6935
On Mon, 26 Sep 2022 19:35:29 GMT, Alexander Matveev
wrote:
>> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
>> never set correct value in .jpackage.xml to mark image as signed.
>> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
>> to ch
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote:
> There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
> All of them create StringBuffer from single character and then concatenate
> with String. Instead of this, we can concatenate character directly.
The changes seem
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 19:28:38 GMT, Alexander Matveev
wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line
>> 64:
>>
>>> 62:
>>> 63: // These values will be loaded from AppImage xml file.
>>> 64: private final Path appImageDir;
>>
>> What this field is
> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
> never set correct value in .jpackage.xml to mark image as signed.
> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
> to check if we can add per-user and system wide configuration to packag
On Fri, 23 Sep 2022 20:40:29 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293462: [macos] app image signature invalid when creating DMG or PKG from
>> post processed signed image [v2]
On Mon, 26 Sep 2022 16:32:43 GMT, Naoto Sato wrote:
>> make/modules/java.base/gendata/GendataTZDB.gmk line 33:
>>
>>> 31: TZDATA_DIR := $(MODULE_SRC)/share/data/tzdata
>>> 32: TZDATA_TZFILE := africa antarctica asia australasia europe northamerica
>>> southamerica backward etcetera gmt jdk11_ba
On Mon, 26 Sep 2022 16:37:33 GMT, Naoto Sato wrote:
>> The current makefile for `tzdb.dat` won't recompile if some dependent files
>> (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to
>> the dependency will fix this issue.
>
> Naoto Sato has updated the pull request inc
On Mon, 26 Sep 2022 16:08:23 GMT, Andrey Turbanov wrote:
>> src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java
>> line 328:
>>
>>> 326: try {
>>> 327: int i;
>>> 328: while ((i = bufReader.read()) != -1) {
>>
>> Is the single character
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote:
> There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
> All of them create StringBuffer from single character and then concatenate
> with String. Instead of this, we can concatenate character directly.
Marked as reviewe
On Thu, 15 Sep 2022 08:55:41 GMT, Severin Gehwolf wrote:
>> Similar issue to the hotspot change discussed in
>> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation
>> may get the resource limits wrong if there are additional cgroup fs mounts.
>> Apparently that's more
A SequencedCollection listIterator() is missed; it's useful for
List.equals, or to implement a List in general. LinkedHashSet seems
incomplete without it. Even something like "ListIterator
Collections.forwardListIterator(int index, iterator)", if compatible
with equals() of the various list typ
If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options from
the JDK_JAVA_OPTIONS environment variable are picked up twice.
If an option cannot be accepted twice (e.g., -agentlib), the application fails
to start.
The same happens on operating systems that doesn't support $RPA
On Mon, 26 Sep 2022 17:03:40 GMT, Aleksey Shipilev wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> java.b
On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov
wrote:
> Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic
> turned out to be profitable on RISC-V using the same fclass instruction as
> for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it
> ad
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 15:31:53 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> java.bas
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
Michael Ernst has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains six commits:
- Reinstate typos in Apache code that is copied into the JDK
- Merge ../jdk-ope
> The current makefile for `tzdb.dat` won't recompile if some dependent files
> (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to
> the dependency will fix this issue.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 26 Sep 2022 12:53:49 GMT, Erik Joelsson wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use wildcard function
>
> make/modules/java.base/gendata/GendataTZDB.gmk line 33:
>
>> 31: TZDATA_DIR := $(MODULE_SRC)/
On Mon, 26 Sep 2022 15:31:53 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> java.bas
On Mon, 26 Sep 2022 08:07:50 GMT, KIRIYAMA Takuya wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is misma
On Thu, 25 Aug 2022 15:35:53 GMT, Michael Ernst wrote:
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
We have discussed several times in the past that we don't touch upstream (in
this case, Apache) code unless the change is essential. In general, if you fix
a bug
On Mon, 26 Sep 2022 14:53:24 GMT, Roger Riggs wrote:
>> There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
>> All of them create StringBuffer from single character and then concatenate
>> with String. Instead of this, we can concatenate character directly.
>
> src/java.sql.ro
On Wed, 21 Sep 2022 20:30:53 GMT, Roger Riggs wrote:
> Clear the signal mask of the child when launching with posix_spawn.
>
> SIGQUIT signals are handled on non-Java Threads by the VM.
> For Java threads the signal mask blocks SIGQUIT.
> The ProcessBuilder uses posix_spawn on all platforms to
> Clear the signal mask of the child when launching with posix_spawn.
>
> SIGQUIT signals are handled on non-Java Threads by the VM.
> For Java threads the signal mask blocks SIGQUIT.
> The ProcessBuilder uses posix_spawn on all platforms to create new processes.
> Without a specific request, th
On Mon, 19 Sep 2022 15:32:34 GMT, Raffaello Giulietti
wrote:
> 8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate
> the marker
This pull request has now been integrated.
Changeset: 968af74d
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/comm
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
possible to disable warnings for individual files instead for whole libraries.
I used this opportunity to go through all disabled warnings in java.base native
libraries.
Any warnings that were only triggered in a few fi
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote:
> There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
> All of them create StringBuffer from single character and then concatenate
> with String. Instead of this, we can concatenate character directly.
src/java.sql.rows
On Thu, 22 Sep 2022 12:56:49 GMT, Aleksei Voitylov
wrote:
> Unlike on x86 (see 8285868 and the discussion in review), isFinite intrinsic
> turned out to be profitable on RISC-V using the same fclass instruction as
> for 8293695 (isInfinite instrinsic). Therefore, I'm proposing to have it
> ad
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
I've been testing with this change for some time and it has worked well.
-
Marked as reviewed by alanb (Reviewer).
PR: h
On Mon, 19 Sep 2022 15:32:34 GMT, Raffaello Giulietti wrote:
> 8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate
> the marker
Marked as reviewed by jlaskey (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10345
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
Marked as reviewed by shade (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10198
On Mon, 26 Sep 2022 13:29:51 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842:
>>
>>> 1840: signalWork(); // propagate at most
>>> twice/run
>>> 1841: w.topLevelExec(t, q);
>>> 1842:
On Mon, 26 Sep 2022 13:21:23 GMT, Aleksey Shipilev wrote:
>> 8292969: This small change in signal propagation rules improves utilization
>> when entry queues are resized,
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842:
>
>> 1840: signalW
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842:
> 1840: signalWork();
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99 [2].
>>
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
Hello Doug, for the bots to trigger the review process, the title of this PR is
expected to be `: `, so in this case the title of this
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
scan's @return needs to be changed to indicate it also now returns a packed int
-
Changes requested by martin (Reviewer).
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote:
> 8292969: This small change in signal propagation rules improves utilization
> when entry queues are resized,
Thanks. replaced with:
* @return the next prevSrc value to use, or negative if none found
Thanks. I keep forgetting the required
8292969: This small change in signal propagation rules improves utilization
when entry queues are resized,
-
Commit messages:
- Merge remote-tracking branch 'refs/remotes/origin/JDK-8292969' into
JDK-8292969
- Merge branch 'openjdk:master' into JDK-8292969
- Update @preturn javad
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99 [2].
>>
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99 [2].
>>
On Fri, 23 Sep 2022 22:10:03 GMT, Naoto Sato wrote:
> The current makefile for `tzdb.dat` won't recompile if some dependent files
> (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to
> the dependency will fix this issue.
make/modules/java.base/gendata/GendataTZDB.gmk li
On Sat, 24 Sep 2022 06:50:45 GMT, Alan Bateman wrote:
>> Degrade Thread.suspend/resume to throw UOE unconditionally.
>>
>> Another step in the removal of this deadlock prone mis-feature from the
>> user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2
>> (1998) and terminal
There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
All of them create StringBuffer from single character and then concatenate with
String. Instead of this, we can concatenate character directly.
-
Commit messages:
- [PATCH] Cleanup usages of StringBuffer in SQLOu
On Mon, 26 Sep 2022 09:46:36 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options from
the JDK_JAVA_OPTIONS environment variable are picked up twice.
If an option cannot be accepted twice (e.g., -agentlib), the application fails
to start.
The same happens on operating systems that doesn't support $RPA
On Wed, 21 Sep 2022 16:49:23 GMT, Naoto Sato wrote:
>> KIRIYAMA Takuya has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows
>> environment
>
> test/jdk/tools/launcher/I18NArg
> I removed a section of via JDK_JAVA_OPTIONS because including main class is
> not allowed in the specification.
> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
> variable. At this time, this test is mismatch with the specification.
> I tried to test and get Passed on
On Fri, 23 Sep 2022 11:10:19 GMT, Alan Bateman wrote:
>> Now that Thread.stop has been degraded to throw
>> `UnsupportedOperationException` (JDK-8299610) the only direct source of
>> async exceptions is from JVMTI `StopThread`. We can remove the
>> `JVM_StopThread` code, remove the `stillborn`
On Fri, 23 Sep 2022 12:41:05 GMT, Coleen Phillimore wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix JniVersion test
>
> This seems good. I looked at the specification changes and they looked okay
> also.
Tha
73 matches
Mail list logo
