Re: RFR: 8289610: Degrade Thread.stop [v4]

On Tue, 20 Sep 2022 16:29:08 GMT, Stuart Marks wrote: >>> Good to see this finally become non-functional but as long as the >>> debugger/JVMTI can trigger throwing an async ThreadDeath then I have to >>> question the potential change in behaviour introduced by removing all the >>> `catch (Thre

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 20, 2022, at 6:04 PM, Michael Hall wrote: > > > >> On Sep 20, 2022, at 5:50 PM, Michael Hall > > wrote: >> >> Given that this does break that, one possibility might be to include >> parameter changes in the Info.plist file. Some time back Apple java >> a

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

On Tue, 20 Sep 2022 14:23:22 GMT, Kevin Rushforth wrote: >> Leslie Zhai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8293910: Try --upgrade-module-path and --patch-module but still failed > > How does the test fail? Does it actually f

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Tue, 20 Sep 2022 14:11:55 GMT, Kevin Rushforth wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug >> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` fa

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Tue, 20 Sep 2022 23:36:23 GMT, Sandhya Viswanathan wrote: >> Smita Kamath has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comments > > Yes, jmvci also seems to have feature list in > jdk/src/jdk.internal.vm.ci/share

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8294076: Improve ant detection in idea.sh

On Tue, 20 Sep 2022 21:45:05 GMT, Magnus Ihse Bursie wrote: > The ant detection in bin/idea.sh is very rudimentary. It fails at a modern > aarch64 macOS installation. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10364

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v8]

On Fri, 2 Sep 2022 00:52:49 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revie

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 20, 2022, at 5:50 PM, Michael Hall wrote: > > Given that this does break that, one possibility might be to include > parameter changes in the Info.plist file. Some time back Apple java > applications used to include a java dictionary in the plist that was more or > less equivalent t

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

> On Sep 20, 2022, at 5:01 PM, Michael Hall wrote: > > > >>> >>> Alexander, >>> >>> I think I figured out how to include PR’s in my build and this appears good. >>> >>> codesign -v --verbose=4 "/Volumes/BlackJack Blastoff_Unsigned/BlackJack >>> Blastoff_Unsigned.app" >>> /Volu

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

On Mon, 19 Sep 2022 20:41:50 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed typo in VirtualThread.c > > src/hotspot/share/runtime/javaThread.cpp line 1174: > >> 1172: #if INCLUDE_JVMTI

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

On Mon, 19 Sep 2022 20:22:54 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed typo in VirtualThread.c > > src/hotspot/share/prims/jvmtiExport.cpp line 1055: > >> 1053: if (JavaThread::

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

On Mon, 19 Sep 2022 20:19:10 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed typo in VirtualThread.c > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 713: > >> 711: if (!jt->is_in_tm

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

>>> >>> >> >> Alexander, >> >> I think I figured out how to include PR’s in my build and this appears good. >> >> codesign -v --verbose=4 "/Volumes/BlackJack Blastoff_Unsigned/BlackJack >> Blastoff_Unsigned.app" >> /Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app: valid

Re: RFR: 8293462: [macos] app image signature invalid when creating DMG or PKG from post processed signed image

Hi Michael, On Sep 16, 2022, at 6:19 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: On Sep 16, 2022, at 6:02 PM, Alexander Matveev mailto:almat...@openjdk.org>> wrote: Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) never set correct value in .jpackage.xml to

RFR: 8294076: Improve ant detection in idea.sh

The ant detection in bin/idea.sh is very rudimentary. It fails at a modern aarch64 macOS installation. - Commit messages: - 8294076: Improve ant detection in idea.sh Changes: https://git.openjdk.org/jdk/pull/10364/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10364&range=

Sequenced Collections

(There may be a better place to send this, let me know where) Suggesting an option to limit the size of the collection, e.g "setMaxSize(int)", default of zero means no limit. I put together "interface MRU extends Collection" some months ago, it has two implementations based on LinkedList and

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

On Tue, 20 Sep 2022 17:53:27 GMT, Sean Mullan wrote: > Now that this API has a section about signed JARs, I think it is very > important to include the following sentences which are copied from `JarFile`: > > "Please note that the verification process does not include validating the > signer's

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v12]

> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote: >> Please review this PR which updates the JarInputStream class description to >> clarify when the Manifest is accessible via JarInputStream::getManifest and >> JarInputStream::get[Jar]Entry. >> >> It is worth noting that with this updat

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

On Tue, 20 Sep 2022 17:37:50 GMT, Alan Bateman wrote: >>> > OK, will make another pass at this today >>> >>> I looked at the latest draft >>> ([2bafc00](https://github.com/openjdk/jdk/commit/2bafc00cc462b7af3f724371ac1bef5fd99c989c)). >>> I think it would help if the section "Verifying a JarIn

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v11]

> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Integrated: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

On Thu, 8 Sep 2022 06:19:10 GMT, Rahul Prabhu wrote: > Created two files for testing XPath Axes: XPathAncestors.java tests the > ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the > preceding and preceding-sibling axes. This pull request has now been integrated. Chang

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

On Tue, 20 Sep 2022 10:49:59 GMT, Lance Andersen wrote: >>> OK, will make another pass at this today >> >> I looked at the latest draft (2bafc00c). I think it would help if the >> section "Verifying a JarInputStream" were renamed to "Signed JAR files". >> The link to getManifest makes the rea

Integrated: 8294006: Avoid hardcoding object file suffixes in make

On Mon, 19 Sep 2022 12:55:47 GMT, Julian Waters wrote: > Replaces hardcoding of object file suffixes in make, to ensure they are > always reliably set from a single place in autoconf. This pull request has now been integrated. Changeset: cb5771dc Author:Julian Waters Committer: Magnus Ihs

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details [v2]

On Fri, 16 Sep 2022 07:27:44 GMT, Matthias Baesken wrote: >> When trying to load a x64 lib on macOS aarch64 one got previously this >> detailed message before >> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): >> >> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.

Re: RFR: 8294062: Improve parsing performance of j.l.c.MethodTypeDesc

On Tue, 20 Sep 2022 13:08:20 GMT, Adam Sotona wrote: > Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be > significantly improved and add performance boost to intensive users. > > Two main reasons have been identified and fixed in this patch: > > First glitch is late ins

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v10]

> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Integrated: 8294008: Grapheme implementation of setText() throws IndexOutOfBoundsException

On Mon, 19 Sep 2022 19:01:57 GMT, Naoto Sato wrote: > Fixing JCK failures caused by the new grapheme implementation. The length of > a CharSequence should return the `endIndex`, not `endIndex - beginIndex`. This pull request has now been integrated. Changeset: e3358e77 Author:Naoto Sato U

Re: RFR: 8289610: Degrade Thread.stop [v4]

On Tue, 20 Sep 2022 06:00:14 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/FilterOutputStream.java line 195: >> >>> 193:// evaluate possible precedence of flushException >>> over closeException >>> 194:if ((flushException instanceof Thre

Re: RFR: 8294008: Grapheme implementation of setText() throws IndexOutOfBoundsException [v3]

On Tue, 20 Sep 2022 01:09:29 GMT, Naoto Sato wrote: >> OK yeah this is really confusing. One might ask a similar question in >> `charAt` about why it doesn't call >> >> src.setIndex(index + src.getBeginIndex()); >> >> The answer is that this is a special-purpose `CharSequence` that represe

Re: RFR: 8294008: Grapheme implementation of setText() throws IndexOutOfBoundsException [v3]

On Tue, 20 Sep 2022 01:14:38 GMT, Naoto Sato wrote: >> Fixing JCK failures caused by the new grapheme implementation. The length of >> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`. > > Naoto Sato has updated the pull request incrementally with one additional > commit

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx [v2]

On Sat, 17 Sep 2022 04:03:35 GMT, Leslie Zhai wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >> >>

Re: RFR: 8294062: Improve parsing performance of j.l.c.MethodTypeDesc

On Tue, 20 Sep 2022 13:08:20 GMT, Adam Sotona wrote: > Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be > significantly improved and add performance boost to intensive users. > > Two main reasons have been identified and fixed in this patch: > > First glitch is late ins

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

RFR: 8294062: Improve parsing performance of j.l.c.MethodTypeDesc

Parsing performance of `j.l.c.MethodTypeDescriptor::ofDescriptor` can be significantly improved and add performance boost to intensive users. Two main reasons have been identified and fixed in this patch: First glitch is late insertion of return type to the first position of `j.u.ArrayList`, ca

Re: RFR: 8293595: tstrings::any() is missing an overload

On Mon, 19 Sep 2022 20:46:12 GMT, Julian Waters wrote: >> I'm the author of these comments and basically the entire source file. >> >> You are right, it will work without the additional overloads. However the >> null pointers will be ignored (tested with G++ 7.4.0), but this is minor, >> proba

Integrated: 8293595: tstrings::any() is missing an overload

On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote: > tstrings::any() has an overload for std::wstring (if required) but is missing > the corresponding operator overload for std::string, leaving only the > templated one as a fallback, which will expand into a std::wostringstream << > std::st

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Tue, 20 Sep 2022 12:27:39 GMT, Kevin Rushforth wrote: > I haven't built a JDK using the `--with-import-modules` to include the > `javafx.*` modules in quite a while, but my recollection is that yes, that > did cause the JavaFX modules to be loaded by the platform class loader. The > followi

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote: > Hi, > > @dumasun reported the issue: > > Configured with jfx-ls-modular-sdk: > > > configure --with-import-modules=modular-sdk > > > `make run-test CONF=fastdebug > TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed: > > > --

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

On Mon, 19 Sep 2022 20:30:48 GMT, Weijun Wang wrote: > Does this mean that the "Verifying a JarInputStream" should also avoid > mentioning "getManifest method returns the manifest"? I understand precisely > it should be "getManifest method is able to return the manifest if you call > it". See

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

On Tue, 20 Sep 2022 06:56:49 GMT, Alan Bateman wrote: >>> I realise you've had a few iterations with Max on this section but I'm >>> concerned that the text is telling the reader that they should use the >>> 2-arg constructor to verify the signatures when a JAR is signed. The >>> default is to

Re: RFR: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications [v4]

> This update is primarily about changes to the JNI Invocation API > specification, mainly in relation to `DestroyJavaVM`. The motivation for the > changes is to align with changes being made to the JLS, JVMS and > `java.lang.Runtime`, specifications in relation to VM termination - ref: > > JDK

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Tue, 20 Sep 2022 08:04:48 GMT, dumasun wrote: > I donot edit make/conf/module-loader-map.conf. @magicus @kevinrushforth In the distant past, the javafx.* modules were mapped to the platform class loader. Do you recall how that worked with configure --with-import-modules? If someone uses jl

Re: RFR: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications [v3]

> This update is primarily about changes to the JNI Invocation API > specification, mainly in relation to `DestroyJavaVM`. The motivation for the > changes is to align with changes being made to the JLS, JVMS and > `java.lang.Runtime`, specifications in relation to VM termination - ref: > > JDK

Re: RFR: 8293977: jdk/modules/etc/VerifyModuleDelegation.java fail with jfx

On Tue, 20 Sep 2022 06:12:06 GMT, Alan Bateman wrote: > > jtreg/bin/jtreg -dir:test/jdk > > -testjdk:./jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 > > -verbose:all jdk/modules/etc/VerifyModuleDelegation.java > > Is jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 your build or is it coming from > so

Integrated: 8278863: Add method ClassDesc::ofInternalName

On Fri, 17 Jun 2022 14:19:11 GMT, Adam Sotona wrote: > The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

On Mon, 22 Aug 2022 07:24:14 GMT, Adam Sotona wrote: >> test/jdk/java/lang/constant/ClassDescTest.java line 268: >> >>> 266: } >>> 267: >>> 268: List badInternalNames = List.of("I;", "[]", >> >> is `[]` a good test for arrays? Wouldn't something more realistic like >> `[Ljava/

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details [v2]

On Fri, 16 Sep 2022 07:27:44 GMT, Matthias Baesken wrote: >> When trying to load a x64 lib on macOS aarch64 one got previously this >> detailed message before >> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): >> >> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v7]

On Mon, 19 Sep 2022 10:21:30 GMT, Lance Andersen wrote: > OK, will make another pass at this today I looked at the latest draft (2bafc00c). I think it would help if the section "Verifying a JarInputStream" were renamed to "Signed JAR files". The link to getManifest makes the reader wonder if