On Mon, 19 Sep 2022 16:55:01 GMT, Sean Coffey wrote:
>> Plus one regarding "too much noise". This event is at the
>> Provider.getService() level and would reports all calls regardless the type
>> and algorithm. Crypto services which supports the delayed provider selection
>> may call Provider.
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update from review com
On Mon, 19 Sep 2022 11:53:19 GMT, dumasun wrote:
> jtreg/bin/jtreg -dir:test/jdk
> -testjdk:./jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 \
> -verbose:all jdk/modules/etc/VerifyModuleDelegation.java
Is jdk-fx-jdk-20+15-56-g4020ed53dd6-linux_x64 your build or is it coming from
somewhere else? Al
On Tue, 20 Sep 2022 04:21:39 GMT, David Holmes wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> commits s
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.
On Mon, 19 Sep 2022 18:51:30 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293462: [macos] app image signature invalid when creating DMG or PKG from
>> post processed signed image [v2]
> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
> never set correct value in .jpackage.xml to mark image as signed.
> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
> to check if we can add per-user and system wide configuration to packag
On Mon, 19 Sep 2022 23:04:12 GMT, Stuart Marks wrote:
>> Thanks, Joe. Added comment to the method.
>
> OK yeah this is really confusing. One might ask a similar question in
> `charAt` about why it doesn't call
>
> src.setIndex(index + src.getBeginIndex());
>
> The answer is that this is a
> Fixing JCK failures caused by the new grapheme implementation. The length of
> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Refine the comments by adding cl
> This update is primarily about changes to the JNI Invocation API
> specification, mainly in relation to `DestroyJavaVM`. The motivation for the
> changes is to align with changes being made to the JLS, JVMS and
> `java.lang.Runtime`, specifications in relation to VM termination - ref:
>
> JDK
On Mon, 19 Sep 2022 00:45:32 GMT, Leslie Zhai wrote:
> Hi,
>
> @dumasun reported the issue:
>
> Configured with jfx-ls-modular-sdk:
>
>
> configure --with-import-modules=modular-sdk
>
>
> `make run-test CONF=fastdebug
> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` failed:
>
>
> --
This update is primarily about changes to the JNI Invocation API specification,
mainly in relation to `DestroyJavaVM`. The motivation for the changes is to
align with changes being made to the JLS, JVMS and `java.lang.Runtime`,
specifications in relation to VM termination - ref:
JDK-8290196 12.
On Mon, 19 Sep 2022 22:18:42 GMT, Naoto Sato wrote:
>> Yeah, I saw there's a mismatch between the src and limit in this call that
>> led to the index check Exception:
>> 286 for (int b = ci.getBeginIndex(); b < end;) {
>> 287 boundaries.add(b);
>> 288
On Mon, 19 Sep 2022 22:07:13 GMT, Joe Wang wrote:
>> It's somewhat confusing as this class adapts `CharacterIterator` into
>> `CharSequence` which are similar to each other (thus the bug). Those
>> `beginIndex`/`endIndex` designate the range in the source
>> `CharacterIterator`, and this `leng
> Fixing JCK failures caused by the new grapheme implementation. The length of
> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added comments to length()
On Mon, 19 Sep 2022 21:02:38 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java
>> line 329:
>>
>>> 327: @Override
>>> 328: public int length() {
>>> 329: return src.getEndIndex();
>>
>> Could the issue be s
On Mon, 19 Sep 2022 19:01:57 GMT, Naoto Sato wrote:
> Fixing JCK failures caused by the new grapheme implementation. The length of
> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.org/jdk/
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote:
> tstrings::any() has an overload for std::wstring (if required) but is missing
> the corresponding operator overload for std::string, leaving only the
> templated one as a fallback, which will expand into a std::wostringstream <<
> std::st
On Mon, 19 Sep 2022 20:46:08 GMT, Joe Wang wrote:
>> Fixing JCK failures caused by the new grapheme implementation. The length of
>> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
>
> src/java.base/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java
>
On Mon, 19 Sep 2022 19:01:57 GMT, Naoto Sato wrote:
> Fixing JCK failures caused by the new grapheme implementation. The length of
> a CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
src/java.base/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java
lin
On Mon, 19 Sep 2022 19:17:06 GMT, Alexey Semenyuk wrote:
>> I deliberately left those 2 out since the comments accompanying them seem to
>> suggest that they're Windows specific overloads that are there for different
>> reasons (As opposed to the one this PR is aimed at, which takes in a regula
On Mon, 19 Sep 2022 19:18:57 GMT, Serguei Spitsyn wrote:
>> There are several places in VirtualThread class implementation where virtual
>> threads are being mounted or unmounted, so there is a transition of the
>> JavaThread identity from carrier thread to virtual thread and back. The
>> exec
On Mon, 19 Sep 2022 17:53:51 GMT, Lance Andersen wrote:
>>> I can remove, but I am not sure I agree we need to describe main vs
>>> attribute here given we are pointing to the Jar spec and if there is any
>>> discussion of Pre-entry attributes, it should be in JarEntry IMHO. I guess
>>> the cl
On Mon, 19 Sep 2022 19:26:53 GMT, Sean Mullan wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor clarification for verifying an JarInputStream
>
> src/java.base/share/classes/java/util/jar/JarInputStream.java
On Mon, 19 Sep 2022 20:04:18 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this updat
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that with this update, we are finally documenting
> behavior that dates back to w
On Mon, 19 Sep 2022 17:25:53 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this updat
On Mon, 19 Sep 2022 18:06:51 GMT, Julian Waters wrote:
>> src/jdk.jpackage/share/native/common/tstrings.h line 363:
>>
>>> 361: return *this;
>>> 362: }
>>> 363:
>>
>> I guess you also need
>>
>> any& operator << (LPSTR v) {
>> data << (v ? fromUtf8(v)
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote:
> tstrings::any() has an overload for std::wstring (if required) but is missing
> the corresponding operator overload for std::string, leaving only the
> templated one as a fallback, which will expand into a std::wostringstream <<
> std::st
Fixing JCK failures caused by the new grapheme implementation. The length of a
CharSequence should return the `endIndex`, not `endIndex - beginIndex`.
-
Commit messages:
- 8294008: Graphme implementation of setText() throws IndexOutOfBoundsException
Changes: https://git.openjdk.org
> There are several places in VirtualThread class implementation where virtual
> threads are being mounted or unmounted, so there is a transition of the
> JavaThread identity from carrier thread to virtual thread and back. The
> execution state in such transitions is inconsistent, and so, has to
On Fri, 16 Sep 2022 22:55:52 GMT, Alexander Matveev
wrote:
> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850)
> never set correct value in .jpackage.xml to mark image as signed.
> [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value
> to check
On Mon, 19 Sep 2022 17:27:29 GMT, Alexey Semenyuk wrote:
>> tstrings::any() has an overload for std::wstring (if required) but is
>> missing the corresponding operator overload for std::string, leaving only
>> the templated one as a fallback, which will expand into a
>> std::wostringstream <<
> There are several places in VirtualThread class implementation where virtual
> threads are being mounted or unmounted, so there is a transition of the
> JavaThread identity from carrier thread to virtual thread and back. The
> execution state in such transitions is inconsistent, and so, has to
On Mon, 19 Sep 2022 06:34:00 GMT, Alan Bateman wrote:
> > I can remove, but I am not sure I agree we need to describe main vs
> > attribute here given we are pointing to the Jar spec and if there is any
> > discussion of Pre-entry attributes, it should be in JarEntry IMHO. I guess
> > the clar
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
On Mon, 19 Sep 2022 16:12:18 GMT, Sean Coffey wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update from review com
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote:
> tstrings::any() has an overload for std::wstring (if required) but is missing
> the corresponding operator overload for std::string, leaving only the
> templated one as a fallback, which will expand into a std::wostringstream <<
> std::st
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that with this update, we are finally documenting
> behavior that dates back to w
On Mon, 19 Sep 2022 16:43:26 GMT, Valerie Peng wrote:
>> Yes, I think this would generate too much noise and detract from the main
>> motivation for these events, which is to help users analyze the security of
>> algorithms that are being used by their applications at the JCE layer.
>
> Plus on
On Mon, 19 Sep 2022 15:52:08 GMT, Sean Mullan wrote:
>> I had this as the original design actually. I'm not sure how interesting it
>> would be to record such "no-service" type events. It would probably add 2-4
>> times the number of events for this event type to a typical recording, given
>>
On Mon, 19 Sep 2022 15:46:46 GMT, Sean Coffey wrote:
> This new event is disabled by default just like the other crypto related
> events that were added some time back (e.g. `TLSHandshakeEvent`). My
> assumption is that these events will be enabled for audit mode when one is
> interested in fi
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
update from review comments
-
Changes:
- all: https://git.openjdk.org/jd
On Sat, 17 Sep 2022 06:41:55 GMT, Rahul Prabhu wrote:
>> Created two files for testing XPath Axes: XPathAncestors.java tests the
>> ancestor and ancestor-or-self axes, while XPathPrecedingTest.java tests the
>> preceding and preceding-sibling axes.
>
> Rahul Prabhu has updated the pull request
On Mon, 19 Sep 2022 15:25:43 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/java/security/Provider.java line 1293:
>>
>>> 1291: }
>>> 1292:
>>> 1293: if (s != null && SecurityProviderServiceEvent.isTurnedOn()) {
>>
>> Would it be useful to generate an event even for the
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
>
This new event is disabled by default just like the other crypto related events
that were added some time back (e.g. `TLSHandshakeEvent`).
On Mon, 19 Sep 2022 14:25:55 GMT, Jaikiran Pai wrote:
>> Add a JFR Event for `java.security.Provider.getService(String type, String
>> algorithm)` calls.
>
> src/java.base/share/classes/java/security/Provider.java line 1293:
>
>> 1291: }
>> 1292:
>> 1293: if (s != null && Secur
On Mon, 19 Sep 2022 15:27:05 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 32:
>>
>>> 30:
>>> 31: import jdk.jfr.Event;
>>> 32: import jdk.jfr.events.*;
>>
>> Hello Sean, rest of the changes look fine to me, except this one. Was this
>> a
On Mon, 19 Sep 2022 15:32:34 GMT, Raffaello Giulietti wrote:
> 8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate
> the marker
See the JBS issue for background info
-
PR: https://git.openjdk.org/jdk/pull/10345
8293567: AbstractSplittableWithBrineGenerator: salt has digits that duplicate
the marker
-
Commit messages:
- 8293567: AbstractSplittableWithBrineGenerator: salt has digits that
duplicate the marker
Changes: https://git.openjdk.org/jdk/pull/10345/files
Webrev: https://webrevs.ope
On Mon, 19 Sep 2022 12:55:47 GMT, Julian Waters wrote:
> Replaces hardcoding of object file suffixes in make, to ensure they are
> always reliably set from a single place in autoconf.
LGTM
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10341
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
src/java.base/share/classes/java/security/Provider.java line 1293:
> 1291: }
> 1292:
> 1293: if (s != null && SecurityProvider
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
I noticed that the event is disabled by default.
Is it because of concerns of too many events, or too much overhead? Or
something else?
I thi
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
The failures reported in the GitHub Actions job look related to this change -
`jdk.jfr.event.metadata.TestDefaultConfigurations` test appears t
On Mon, 19 Sep 2022 12:55:47 GMT, Julian Waters wrote:
> Replaces hardcoding of object file suffixes in make, to ensure they are
> always reliably set from a single place in autoconf.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10341
> The symbolic constants API (`java.lang.constant`) was designed, in part, to
> provide bytecode parsing and generation APIs with a validated, common,
> symbolic form for constants in Java class files.
>
> There is an easy way to create a `ClassDesc` from a binary name
> (`ClassDesc::of`) or a
Replaces hardcoding of object file suffixes in make, to ensure they are always
reliably set from a single place in autoconf.
-
Commit messages:
- Launcher.gmk
- JvmMapfile.gmk
- NativeCompilation.gmk
Changes: https://git.openjdk.org/jdk/pull/10341/files
Webrev: https://webrevs.o
On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey wrote:
> Add a JFR Event for `java.security.Provider.getService(String type, String
> algorithm)` calls.
Looks good.
-
Marked as reviewed by mullan (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9657
Reliably reproduces on x86-32 with FPU:
$ CONF=linux-x86-server-fastdebug make test
TEST=java/lang/Float/Binary16ConversionNaN.java TEST_VM_OPTS="-XX:UseAVX=0
-XX:UseSSE=0"
...
Roundtrip failure on NaN value 7de2 got back 7fe2
Roundtrip failure on NaN value fde2 got back ffe2
Since there are
On Mon, 19 Sep 2022 06:45:13 GMT, Alan Bateman wrote:
> I realise you've had a few iterations with Max on this section but I'm
> concerned that the text is telling the reader that they should use the 2-arg
> constructor to verify the signatures when a JAR is signed. The default is to
> verify
On Wed, 25 May 2022 09:40:42 GMT, Raffaello Giulietti wrote:
>> Add a family of "safe" cast methods.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279986: methods Math::asXExact for safely checked primitive casts
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
keep open, waiting for review
-
PR: https://git.openjdk.
"`VectorSupport.indexVector()`" is used to compute a vector that contains the
index values based on a given vector and a scale value (`i.e. index = vec +
iota * scale`). This function is widely used in other APIs like
"`VectorMask.indexInRange`" which is useful to the tail loop vectorization. An
On Mon, 19 Sep 2022 07:02:40 GMT, Leslie Zhai wrote:
> java.lang.Error: platform/javafx.swing can't delegate to find classes from
> app/jdk.unsupported.desktop
There must be configuration somewhere that is mapping the javafx.* modules to
the platform class loader So I think the test is doing i
On Mon, 19 Sep 2022 06:14:25 GMT, Alan Bateman wrote:
>> Hi,
>>
>> @dumasun reported the issue:
>>
>> Configured with jfx-ls-modular-sdk:
>>
>>
>> configure --with-import-modules=modular-sdk
>>
>>
>> `make run-test CONF=fastdebug
>> TEST="jdk/modules/etc/VerifyModuleDelegation.java"` faile
On Mon, 19 Sep 2022 06:51:36 GMT, Matthias Baesken wrote:
> > What is the cause of this issue? It expects the dependency can be found but
> > missing in this case. I wonder if it's due to a `requires static`
> > dependency?
>
> Hi Mandy, good question, so far I have just a zip with a coupple o
66 matches
Mail list logo
