Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-17 Thread Lance Andersen
On Sat, 17 Sep 2022 08:05:37 GMT, Alan Bateman wrote: > It's a bit better but I think we can make it clearer and also link the JAR > Manifest section of the JAR file spec. Can you try this: > > ``` > * The {@link #getManifest() getManifest} method is used to read the > * JAR Manifest > * fr

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v6]

2022-09-17 Thread Lance Andersen
> Please review this PR which updates the JarInputStream class description to > clarify when the Manifest is accessible via JarInputStream::getManifest and > JarInputStream::get[Jar]Entry. > > It is worth noting that with this update, we are finally documenting > behavior that dates back to w

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-17 Thread Alan Bateman
> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for > removal, and remove the remaining special handling of ThreadDeath from the > JDK. > > Thread.stop is inherently unsafe and has been deprecated since JDK 1.2 (1998) > with a link to a supplementary page that explains

Re: RFR: 8293910: tools/launcher/FXLauncherTest.java fail with jfx

2022-09-17 Thread Leslie Zhai
On Fri, 16 Sep 2022 13:02:16 GMT, Kevin Rushforth wrote: >> Hi, >> >> @dumasun reported the issue: >> >> Configured with jfx-ls-modular-sdk: >> >> >> configure --with-import-modules=modular-sdk >> >> >> `make run-test CONF=fastdebug TEST="tools/launcher/FXLauncherTest.java"` >> failed: >>

Re: RFR: 8215788: Clarify JarInputStream Manifest access [v4]

2022-09-17 Thread Alan Bateman
On Fri, 16 Sep 2022 18:33:46 GMT, Lance Andersen wrote: >> Okay, in which case what would you think about just saying that the >> getNextEntry/getNextJarEntry method do not return the Manifest when it's at >> the start of the stream, and it's unspecified whether they return the >> Manifest whe

Re: RFR: 8293595: tstrings::any() is missing an overload

2022-09-17 Thread Julian Waters
On Fri, 9 Sep 2022 13:38:14 GMT, Julian Waters wrote: > tstrings::any() has an overload for std::wstring (if required) but is missing > the corresponding operator overload for std::string, leaving only the > templated one as a fallback, which will expand into a std::wostringstream << > std::st

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-17 Thread Markus KARG
On Sun, 11 Sep 2022 07:44:44 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - corrected copyright >> - testing transferTo() after reset() > >> I do not quite understand what would be wrong with t

Re: RFR: JDK-8293659: Improve UnsatisfiedLinkError error message to include dlopen error details

2022-09-17 Thread Thomas Stuefe
On Thu, 15 Sep 2022 17:56:09 GMT, Mandy Chung wrote: >> When trying to load a x64 lib on macOS aarch64 one got previously this >> detailed message before >> [JDK-8275703](https://bugs.openjdk.org/browse/JDK-8275703): >> >> java.lang.UnsatisfiedLinkError: /testing/jco3/macOsx64/libsapjco3.dylib