Found during code review of
[JDK-8292695](https://bugs.openjdk.org/browse/JDK-8292695).
We have two bugs in libjsig when we install hotspot signal handlers. Relevant
code in libjsig:
int sigaction(int sig, const struct sigaction *act, struct sigaction *oact) {
sigused = sigismember(&jvmsig
On Thu, 11 Aug 2022 16:11:02 GMT, Alan Bateman wrote:
> Some blocking operations that pin a virtual thread to its carrier will
> compensate by activating a spare carrier (essentially managed blocker). This
> is done by wrapping the operation in a Blocker begin/end. This code is not
> correct f
On Fri, 9 Sep 2022 08:30:55 GMT, KIRIYAMA Takuya wrote:
> Could you please review the JDK-8293579 bug fixes?
>
> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
> the launcher the character which is encoded by Windows API
> WideCharToMultiByte()
> from UNICODE "é
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi
wrote:
> To support Windows command prompt's codepage, following charsets should be
> moved from jdk.charsets module to java.base module.
>
> - IBM860
> - IBM861
> - IBM863
> - IBM864
> - IBM865
> - IBM869
Considering those code page encoding
On Fri, 9 Sep 2022 15:48:41 GMT, Roger Riggs wrote:
>> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
>> multiple gc cycles to queue the expected refs.
>> Short the timeout on each cycle to 10 sec.
>
> Roger Riggs has updated the pull request incrementally with one add
On Fri, 9 Sep 2022 15:48:41 GMT, Roger Riggs wrote:
>> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
>> multiple gc cycles to queue the expected refs.
>> Short the timeout on each cycle to 10 sec.
>
> Roger Riggs has updated the pull request incrementally with one add
> We already have Ant+Ivy, Maven, Gradle and they have significantly
different philosophies such that agreeing on a single dependency management
tool may be too ambitious.
Maybe it would be useful to dig into what those different philosophies are?
> I suggest looking at what Gradle has done in th
On Tue, 23 Aug 2022 22:44:13 GMT, Naoto Sato wrote:
> This is to enhance the character break analysis in `java.text.BreakIterator`
> to conform to the extended grapheme cluster boundaries defined in
> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
> corresponding CSR has
On Thu, 8 Sep 2022 18:32:56 GMT, Naoto Sato wrote:
>> This is to enhance the character break analysis in `java.text.BreakIterator`
>> to conform to the extended grapheme cluster boundaries defined in
>> https://www.unicode.org/reports/tr29/#Grapheme_Cluster_Boundaries. A
>> corresponding CSR h
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote:
> Improve the implementation of `Double/Float.isInfinite` to reduce branching.
> Using `>` comparison with `MAX_VALUE` instead of `==` with
> `POSITIVE_INFINITY` improves code emission on x86 and produces similar code
> for arm. This is als
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote:
> Improve the implementation of `Double/Float.isInfinite` to reduce branching.
> Using `>` comparison with `MAX_VALUE` instead of `==` with
> `POSITIVE_INFINITY` improves code emission on x86 and produces similar code
> for arm. This is als
On Fri, 9 Sep 2022 15:29:22 GMT, Roger Riggs wrote:
> Is the case of -Dcom.sun.jndi.ldap.object.trustSerialData (w/o a value) well
> defined.
Deserialization and reconstruction of Java objects are only allowed when the
system property is set to "true". That's how its defined in `java.naming`
> ### Summary of the change
>
> The LDAP Naming Service Provider implementation's default settings are
> changed to disallow deserialization and reconstruction of Java objects from
> different LDAP attributes (RFC 2713). Currently, only the deserialization is
> controlled by the `com.sun.jndi.l
On Sun, 17 Jul 2022 10:58:45 GMT, Claes Redestad wrote:
>> @merykitty, the proposed change is functionally correct.
>>
>> @cl4es, what set of platforms do we usually consider for evaluating
>> performance changes like this?
>
>> @cl4es, what set of platforms do we usually consider for evaluatin
> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
> multiple gc cycles to queue the expected refs.
> Short the timeout on each cycle to 10 sec.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused Re
On Fri, 9 Sep 2022 11:03:14 GMT, Aleksei Efimov wrote:
> ### Summary of the change
>
> The LDAP Naming Service Provider implementation's default settings are
> changed to disallow deserialization and reconstruction of Java objects from
> different LDAP attributes (RFC 2713). Currently, only th
On Tue, 17 May 2022 04:40:50 GMT, liach wrote:
> Generic repositories, the implementation detail for generic information in
> core reflection, can be updated to use the `@Stable` annotation to replace
> their `volatile` access. Their existing accessor code is already safe,
> reading the cache
On Fri, 9 Sep 2022 14:42:20 GMT, Daniel Fuchs wrote:
> `javaReferenceAddress` is defined in RFC 2713, section 3.6 - but
> `javaRemoteLocation` is not - it's marked deprecated in our code base so
> maybe it came from some early draft of this representation.
Correct, and since these attributes a
> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
> multiple gc cycles to queue the expected refs.
> Short the timeout on each cycle to 10 sec.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Refactored to us
On Thu, 8 Sep 2022 20:26:41 GMT, Roger Riggs wrote:
> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
> multiple gc cycles to queue the expected refs.
> Short the timeout on each cycle to 10 sec.
Hi Jai, I don't think the memory size comes into play, the GC is invoked
On Thu, 8 Sep 2022 20:54:28 GMT, Mandy Chung wrote:
>> Modify the LoadLibraryUnload test to call gc() more a few times, allowing
>> multiple gc cycles to queue the expected refs.
>> Short the timeout on each cycle to 10 sec.
>
> test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
On Fri, 9 Sep 2022 14:13:09 GMT, Alan Bateman wrote:
>> ### Summary of the change
>>
>> The LDAP Naming Service Provider implementation's default settings are
>> changed to disallow deserialization and reconstruction of Java objects from
>> different LDAP attributes (RFC 2713). Currently, only
On Fri, 9 Sep 2022 11:03:14 GMT, Aleksei Efimov wrote:
> ### Summary of the change
>
> The LDAP Naming Service Provider implementation's default settings are
> changed to disallow deserialization and reconstruction of Java objects from
> different LDAP attributes (RFC 2713). Currently, only th
On Thu, 11 Aug 2022 16:11:02 GMT, Alan Bateman wrote:
> Some blocking operations that pin a virtual thread to its carrier will
> compensate by activating a spare carrier (essentially managed blocker). This
> is done by wrapping the operation in a Blocker begin/end. This code is not
> correct f
This email is mostly to test the waters, I expect some hostility.
Say, as a premise, that an API for resolving external dependencies was
something that the JDK concerned itself with providing.
I think the foundation for that is there - the POM v4 format is more or
less around forever, maven style
tstrings::any() has an overload for std::wstring (if required) but is missing
the corresponding operator overload for std::string, leaving only the templated
one as a fallback, which will expand into a std::wostringstream << std::string
operation. This isn't particularly safe on Windows, conside
On Wed, 22 Jun 2022 12:43:53 GMT, Quan Anh Mai wrote:
> Improve the implementation of `Double/Float.isInfinite` to reduce branching.
> Using `>` comparison with `MAX_VALUE` instead of `==` with
> `POSITIVE_INFINITY` improves code emission on x86 and produces similar code
> for arm. This is als
On Thu, 8 Sep 2022 07:57:36 GMT, Aleksey Shipilev wrote:
> I have been looking into `make clean-images images` performance, and realized
> jmod keeps compressing files with default compression level. Tuning that
> toward lighter compression levels improves build performance considerably,
> wit
Some blocking operations that pin a virtual thread to its carrier will
compensate by activating a spare carrier (essentially managed blocker). This is
done by wrapping the operation in a Blocker begin/end. This code is not correct
for the case that a spare cannot be activated (e.g. already at th
On Thu, 8 Sep 2022 12:18:35 GMT, Markus KARG wrote:
>>> Actually I wrote this code in 2021. What are the official rules here, do I
>>> have to use the original date or the latest change date?
>>
>> I remember reading it somewhere but I can't seem to locate the text right
>> now and it isn't m
On Fri, 9 Sep 2022 10:03:11 GMT, Markus KARG wrote:
>> Unless there's a bug and the new code path is triggered when there's a mark
>> ;-) . Maybe we can convince ourselves that this can't happen now (by reading
>> the code), but if someone modifies this code 2 years from now and introduces
>>
> Implementation of JDK-8279283
Markus KARG has updated the pull request incrementally with two additional
commits since the last revision:
- corrected copyright
- testing transferTo() after reset()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/6935/files
- new: https://
### Summary of the change
The LDAP Naming Service Provider implementation's default settings are changed
to disallow deserialization and reconstruction of Java objects from different
LDAP attributes (RFC 2713). Currently, only the deserialization is controlled
by the `com.sun.jndi.ldap.object.t
On Fri, 9 Sep 2022 08:49:07 GMT, Daniel Fuchs wrote:
>> I did not do that so far, as we agreed to check the *new* code path, which
>> is only executed when noting was marked (so reset plays no role). Certainly
>> I will be happy to add another test for the use case you describe (i. e. the
>> *
On Fri, 9 Sep 2022 06:45:04 GMT, Markus KARG wrote:
>> test/jdk/java/io/BufferedInputStream/TransferTo.java line 170:
>>
>>> 168: if (mark) {
>>> 169: in.mark(1);
>>> 170: }
>>
>> This just tests transferTo with a mark set, it doesn't appear to check that
Could you please review the JDK-8293579 bug fixes?
tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
the launcher the character which is encoded by Windows API
WideCharToMultiByte()
from UNICODE "é"(0x00e9) as an argument. However, this test fails because the
code p
37 matches
Mail list logo
