On Sun, 10 Jul 2022 10:20:31 GMT, Laurent Bourgès wrote:
>> iaroslavski has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)
>>
>> * Added JMH
>
> Here are JMH test results on m
On Mon, 8 Aug 2022 22:34:00 GMT, Stuart Marks wrote:
>> I would also suggest that the join() sentence simply be the last sentence of
>> the above paragraph:
>>
>>> The join method can be be used to wait for a thread to terminate.
>
> The whole paragraph is about thread termination, so I don't t
On Fri, 5 Aug 2022 09:02:44 GMT, ScientificWare wrote:
>> Hello @scientificware, what you propose here, I think looks fine.
>> Additionally can you also update the copyright years on this file from
>> `Copyright (c) 1998, 2020,` to `Copyright (c) 1998, 2022,`?
>>
>> I see that the changed file
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote:
>> This is tracked in JBS as
>>
>> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by
>> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070)
>>
>> Unused imports in DTDBuider.java.
>>
>>> **Remove unused i
On Tue, 9 Aug 2022 02:35:14 GMT, Leonid Mesnik wrote:
>> The test should use the same locales in all processes, the default language
>> should work fine.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
> I tried a fe
> The test should use the same locales in all processes, the default language
> should work fine.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9798/files
-
On Fri, 5 Aug 2022 18:30:05 GMT, Bill Huang wrote:
>> Improve test coverage for XPath functions:
>> [JDK-8290836](https://bugs.openjdk.org/browse/JDK-8290836),
>> [JDK-8290837](https://bugs.openjdk.org/browse/JDK-8290837),
>> [JDK-8290838](https://bugs.openjdk.org/browse/JDK-8290838).
>
> Bill
With the ACC_SUPER information now available from a private
getClassAccessFlagsRaw() method, the
Set accessFlags()
method can properly model that setting.
-
Commit messages:
- JDK-8291734: Return accurate ACC_SUPER access flag for classes
Changes: https://git.openjdk.org/jdk/pul
- Original Message -
> From: "Jan Lahoda"
> To: "core-libs-dev"
> Sent: Friday, August 5, 2022 11:03:06 PM
> Subject: Re: RFR: 8291966: SwitchBootstrap.typeSwitch could be faster
> On Fri, 5 Aug 2022 20:20:56 GMT, Remi Forax wrote:
>
>> You only need restart index at the beginning and
On Mon, 8 Aug 2022 02:06:18 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 55:
>
>> 53: * to one
> Initial edits to addShutdownHook from Alex.
>
> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036).
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Updates from Alan, David, and Alex.
-
Changes:
- all: h
On Mon, 8 Aug 2022 01:55:08 GMT, David Holmes wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/Runtime.java line 66:
>
>> 64: * {@linkp
On Mon, 8 Aug 2022 02:33:13 GMT, David Holmes wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 73:
>>
>>> 71: * or if its {@code run} method completes abruptly and the appropriate
>>> 72: * {@linkplain Thread.UncaughtExceptionHandler uncaught exception
>>> handler} completes
>
> From: "(11I10I24) 活 动 中 心" <1015770...@qq.com>
> To: "core-libs-dev"
> Sent: Saturday, August 6, 2022 11:49:18 AM
> Subject: More elegant multi-condition groupby. #9719
> Hi, team
> I have two suggestions
> Firstly:
> If we can provide a new API for grouping ( java.util.stream.Collectors )
>
On Mon, 8 Aug 2022 02:36:45 GMT, David Holmes wrote:
>> "initiated" is also used.
>
> I would suggest saying as little as possible here and simply deferring to the
> Runtime text ie.:
>
>> The shutdown sequence begins when all
>> started
> non-daemon threads have terminated.
>
> No need to e
On Sat, 6 Aug 2022 07:47:04 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More edits from Alex's suggestions.
>
> src/java.base/share/classes/java/lang/System.java line 1888:
>
>> 1886: *
On Mon, 8 Aug 2022 19:52:47 GMT, Leonid Mesnik wrote:
> The test should use the same locales in all processes, the default language
> should work fine.
I tried a few locales and could not reproduce the problem, I was expecting some
kind of mismatch would trigger it, but not sure what to set wh
On Mon, 8 Aug 2022 21:31:27 GMT, Chris Plummer wrote:
> Can you explain why setting the locale on the test but not the subprocess is
> causing the failure?
The jstatd process prints some numbers always using "en" locale and "." as
decimal separators. While reading process might have different
On Mon, 8 Aug 2022 19:52:47 GMT, Leonid Mesnik wrote:
> The test should use the same locales in all processes, the default language
> should work fine.
Can you explain why setting the locale on the test but not the subprocess is
causing the failure?
-
PR: https://git.openjdk.org/
On Mon, 8 Aug 2022 21:10:26 GMT, Alex Kasko wrote:
>> Good point. We have a discussion of how l10n files should be changed at
>> https://github.com/openjdk/jdk/pull/9753. Can you confirm that if some
>> property is missing in a resource bundle its value is picked from the
>> English resource b
On Mon, 8 Aug 2022 19:52:41 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Mon, 8 Aug 2022 21:04:49 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 37:
>>
>>> 35: resource.post-app-image-script=script to run after application image is
>>> populated
>>> 36: resource.post-msi-script=scri
On Mon, 8 Aug 2022 21:10:26 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementation is b
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based on [this
> comment](https://bugs.openjdk.org/browse
On Mon, 8 Aug 2022 20:39:33 GMT, Alexander Matveev wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>> Override implementati
On Mon, 8 Aug 2022 19:52:41 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based
The test should use the same locales in all processes, the default language
should work fine.
-
Commit messages:
- 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a
percentage\: 68.31\: expected true, was false"
Changes: https://git.openjdk.org/jdk/pull/9798/files
> This change adds `ContextMenuCommandLabel` l10n property for file association
> context menu label. It is a follow-up to [this PR
> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>
> Note, non-EN l10n values were filled using auto-translator and may need to be
> c
On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Mon, 8 Aug 2022 18:51:59 GMT, Alexey Semenyuk wrote:
>> Missing entries in localized files are automatically detected by the
>> translation process. So modifying only the English file should be fine.
>
> @naotoj , I suspect missing entries in l10n files will cause code depending
> on them to
On Sat, 6 Aug 2022 14:55:17 GMT, David Schlosnagle wrote:
>> I would like to contribute an optimized version of
>> `StackTraceElement#toString()` that uses a single StringBuilder throughout
>> creation to avoid intermediate `String` allocations.
>> `StackTraceElement#toString()` is used in a n
On Sat, 6 Aug 2022 13:48:28 GMT, Naoto Sato wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reg method access, drop l10n entries, label check enhancement
>
> Missing entries in localized files are automatically detec
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementation is based
On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>>
>> Note, non-EN l10n values
On Fri, 5 Aug 2022 23:58:49 GMT, Joe Darcy wrote:
>> @jddarcy Thanks for your comment. I am not sure if there is a way of using
>> Java library implementation here.
>
> I was under the impression that if a platform didn't have special support for
> the functionality in question it could not hav
On Fri, 5 Aug 2022 16:36:23 GMT, Smita Kamath wrote:
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
src/hotspot/cpu/x86/assembler_x86.cpp line 1927:
> 1925: assert(VM_Version::supports_evex(), "");
> 1926: InstructionAttr attributes(
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
On Mon, 8 Aug 2022 16:25:41 GMT, Julian Waters wrote:
>> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>>
>> - The windows variant prints message, then extra-info if available, but the
>> Unix variant prints first extra-info, then message on a newline. Standardize
>> both
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
On Mon, 8 Aug 2022 13:25:22 GMT, Julian Waters wrote:
>> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>>
>> - The windows variant prints message, then extra-info if available, but the
>> Unix variant prints first extra-info, then message on a newline. Standardize
>> both
On Mon, 8 Aug 2022 12:14:50 GMT, Julian Waters wrote:
>> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>>
>> - The windows variant prints message, then extra-info if available, but the
>> Unix variant prints first extra-info, then message on a newline. Standardize
>> both
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
On Mon, 8 Aug 2022 09:06:39 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> I feel stupid
>
> src/java.base/unix/native/libjli/java_md_common.c line 209:
>
>> 207: /*
>> 208: * TODO: it
On Mon, 8 Aug 2022 12:14:50 GMT, Julian Waters wrote:
>> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>>
>> - The windows variant prints message, then extra-info if available, but the
>> Unix variant prints first extra-info, then message on a newline. Standardize
>> both
On Thu, 4 Aug 2022 10:57:53 GMT, Peter Levart wrote:
> This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s)
> when used internally in JDK for per-carrier-thread caches of native
> ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such
> TerminatingThreadLo
On Mon, 8 Aug 2022 09:06:39 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> I feel stupid
>
> src/java.base/unix/native/libjli/java_md_common.c line 209:
>
>> 207: /*
>> 208: * TODO: it
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote:
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
> defined, but empty macro in libjli if it is not defined in the build system,
> which is incorrect
This pull request has now been integrated.
Changeset: 8a804f65
Aut
> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>
> - The windows variant prints message, then extra-info if available, but the
> Unix variant prints first extra-info, then message on a newline. Standardize
> both to print their system errors on newlines below the message.
>
On Mon, 8 Aug 2022 05:44:01 GMT, Julian Waters wrote:
>> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
>> defined, but empty macro in libjli if it is not defined in the build system,
>> which is incorrect
>
> Julian Waters has updated the pull request with a new target b
On Fri, 5 Aug 2022 16:12:08 GMT, Jan Lahoda wrote:
> The pattern matching switches are using a bootstrap method
> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch. Basically,
> for a switch like:
>
> switch (obj) {
> case String s when s.isEmpty() -> {}
> case String s
On Mon, 8 Aug 2022 00:19:57 GMT, Ichiroh Takiguchi
wrote:
> As you know `sun.nio.cs.ArrayDecoder` and `sun.nio.cs.ArrayEncoder`interface
> have performance advantage. And some other performance advantages are there
> on built-in charset decoder/encoder. Is it possible to create simple public
On Mon, 8 Aug 2022 05:22:28 GMT, Julian Waters wrote:
>> JLI_ReportErrorMessageSys has a number of issues, as listed below:
>>
>> - The windows variant prints message, then extra-info if available, but the
>> Unix variant prints first extra-info, then message on a newline. Standardize
>> both
On Fri, 5 Aug 2022 09:55:58 GMT, Jaikiran Pai wrote:
>> ScientificWare has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
On Fri, 5 Aug 2022 09:54:36 GMT, Peter Levart wrote:
>> This is an attempt to fix inconsistent behavior of TerminatingThreadLocal(s)
>> when used internally in JDK for per-carrier-thread caches of native
>> ByteBuffer(s) and NativeBuffer(s). If used from virtual thread, such
>> TerminatingThre
57 matches
Mail list logo
