On Wed, 27 Jul 2022 14:29:26 GMT, Jorn Vernee wrote:
> startThread and joinThread is not the functionality that the tests need.
But it is the functionality the tests are already using.
> now the context passed to CreateThread and pthread_create has to outlive the
> function
That's not an issu
On Thu, 28 Jul 2022 01:49:13 GMT, Bill Huang wrote:
>> Provided coverage for XPath node set functions. Functions include:
>> - id()
>> - last()
>> - position()
>> - count()
>> - local-name()
>> - namespace-uri()
>> - name()
>
> Bill Huang has updated the pull request incrementally with one additi
On Thu, 28 Jul 2022 00:58:59 GMT, Ichiroh Takiguchi
wrote:
>> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy
>> came from the mapping difference between MS and IBM.
>
> Hello @naotoj .
> I'm not reviewer, but I'd like to test this change.
> Could you wait for a mom
> Provided coverage for XPath node set functions. Functions include:
> - id()
> - last()
> - position()
> - count()
> - local-name()
> - namespace-uri()
> - name()
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Rename test name to XPat
On Thu, 28 Jul 2022 00:14:52 GMT, Joe Wang wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added documentation/comments and test cases using namespace.
>
> test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFnTest.java
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote:
> Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy
> came from the mapping difference between MS and IBM.
Hello @naotoj .
I'm not reviewer, but I'd like to test this change.
Could you wait for a moment ?
Thanks.
--
On Wed, 27 Jul 2022 20:04:54 GMT, Bill Huang wrote:
>> Provided coverage for XPath node set functions. Functions include:
>> - id()
>> - last()
>> - position()
>> - count()
>> - local-name()
>> - namespace-uri()
>> - name()
>
> Bill Huang has updated the pull request incrementally with one additi
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
This pull request has now been integrated.
Changeset: 348a0521
Author:Leonid Mesnik
URL:
https://git.open
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
Looks good to me.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.
On Wed, 27 Jul 2022 20:18:16 GMT, Gaurav Chaudhari wrote:
>> This is a REDO of the Fix that was incompletely implemented earlier:
>> [8285838: Fix for TZ environment variable DST
>> rules](https://github.com/openjdk/jdk/pull/8660)
>>
>> Offset calculation now accounts all the way upto year in o
On Thu, 21 Jul 2022 22:33:36 GMT, Leonid Mesnik wrote:
> Propagate test.vm.opts/test.java.opts to tested process. Also, accept the
> output of non-generation (ZGC) GC as valid.
Marked as reviewed by cjplummer (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9604
On Wed, 27 Jul 2022 21:39:47 GMT, Leonid Mesnik wrote:
>> I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
>> understand why this change is needed.
>
> Before my changes test just silently ignored any GC setting and always use G1.
Ah, ok. That makes sense now.
-
On Fri, 22 Jul 2022 19:27:29 GMT, Chris Plummer wrote:
>> No, test passes with ZGC.
>
> I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
> understand why this change is needed.
Before my changes test just silently ignored any GC setting and always use G1.
--
On Fri, 22 Jul 2022 03:10:11 GMT, Leonid Mesnik wrote:
>> So shouldn't we have ZGC test failures then?
>
> No, test passes with ZGC.
I meant shouldn't we see ZGC failures before your changes. Otherwise I don't
understand why this change is needed.
-
PR: https://git.openjdk.org/jdk
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
> This is a REDO of the Fix that was incompletely implemented earlier:
> [8285838: Fix for TZ environment variable DST
> rules](https://github.com/openjdk/jdk/pull/8660)
>
> Offset calculation now accounts all the way upto year in order to avoid
> cross-day miscalculations as well as to calculat
On Thu, 30 Jun 2022 20:05:05 GMT, Naoto Sato wrote:
>> Gaurav Chaudhari has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288377: Simplified TZ offset calc and consolidate MACOS impl.
>
> src/java.base/unix/native/libjava/TimeZone_md.c li
On Tue, 26 Jul 2022 19:44:51 GMT, Joe Wang wrote:
>> Bill Huang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit sin
> Provided coverage for XPath node set functions. Functions include:
> - id()
> - last()
> - position()
> - count()
> - local-name()
> - namespace-uri()
> - name()
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Added documentation/comm
On Tue, 26 Jul 2022 21:44:19 GMT, Roger Riggs wrote:
> The intermittent test failure was due to the WeakReferences being
> unreferenced too early.
> Adding a Reference.reachabilityFence to the test makes it robust.
>
> Remove from ProblemList-Xcomp.txt
This pull request has now been integrated
On Wed, 27 Jul 2022 06:43:45 GMT, David Holmes wrote:
> > Does run_in_new_thread seem good enough?
>
> No, sorry, the fact it both runs and joins is a critical aspect. `run_async`
> in `CompleteableFuture` just does the "run in new thread" part, whereas the
> `get()` on the returned `FutureTas
> This patch removes the use of std::thread from the `java.lang.foreign` tests,
> and switches to the OS specific thread APIs, in order to change things such
> as the stack size on some platforms where this is required in the future (see
> the JBS issue).
>
> This is done by adding a small head
Forward port JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455
- 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some
platforms
- 8290460: A
On Wed, 27 Jul 2022 12:59:36 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 92346246
Author:David Holmes
URL:
https://git.openjdk.org/jdk/commit/923462467e52eda359249a4fb61d654f56182603
Stats: 134 lines in 4 files c
On Tue, 26 Jul 2022 21:44:19 GMT, Roger Riggs wrote:
> The intermittent test failure was due to the WeakReferences being
> unreferenced too early.
> Adding a Reference.reachabilityFence to the test makes it robust.
>
> Remove from ProblemList-Xcomp.txt
Marked as reviewed by jpai (Reviewer).
T
On Tue, 26 Jul 2022 21:44:19 GMT, Roger Riggs wrote:
> The intermittent test failure was due to the WeakReferences being
> unreferenced too early.
> Adding a Reference.reachabilityFence to the test makes it robust.
>
> Remove from ProblemList-Xcomp.txt
Hi Jai,
The actions related to Reference
On Wed, 27 Jul 2022 05:29:09 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/9651
On Wed, 27 Jul 2022 05:29:09 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
Need to pull in a follow up test fix so closing this MR.
-
PR: https://git.openjdk.org/jdk/pull/9651
On Mon, 25 Jul 2022 16:41:04 GMT, Aleksey Shipilev wrote:
> > ...I can take this over, unless you want to do it, Aleksey?
>
> I find it dubious to try and guess what GCs would do with non-strong refs,
> but feel free. Don't reassign the bug yet, just see how messy that would be?
On the other h
On Mon, 9 May 2022 09:56:19 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream` spe
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave t
1. minLength < 0 means that there is an overflow in the preceding
addition, so the error's message is correct.
2. + 3. hugeLength() is only ever invoked by the newLength() method just
above. The javadoc spec of that method is quite clear about what
newLength(), and thus hugeLength(), are expec
On Tue, 26 Jul 2022 09:44:53 GMT, Maurizio Cimadamore
wrote:
> This patch removes java/foreign/TestUnsupportedPlatform, which has been
> superseded by TestUnsupportedLinker, and is no longer required.
> This old test relies on unspecified behavior and should be removed.
This pull request has n
33 matches
Mail list logo
