On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
> Initial implementation.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Adopt alternative implementaiton from review.
- Refactor equivalent() implementation.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9422/fi
On Mon, 25 Jul 2022 17:09:10 GMT, Roger Riggs wrote:
> ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
> The earlier fix is not sufficient for higher tier tests possibly related to
> -Xcomp.
Hello Roger, the change looks fine to me. There's a mention that this issue was
noticed once
> Provided coverage for XPath node set functions. Functions include:
> - id()
> - last()
> - position()
> - count()
> - local-name()
> - namespace-uri()
> - name()
Bill Huang has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show d
> Initial implementation.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Implement additional review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9422/files
- new: https://git.openjdk.org/jdk/pull/9422/
> Provided coverage for XPath node set functions. Functions include:
> - id()
> - last()
> - position()
> - count()
> - local-name()
> - namespace-uri()
> - name()
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Fixed attibute validatio
On Mon, 25 Jul 2022 16:10:02 GMT, Naoto Sato wrote:
>> This PR is to propose supporting the `T` extension to the BCP 47 to which
>> `java.util.Locale` class conforms. There are two extensions to the BCP 47,
>> one is `Unicode Locale Extension` which has been supported since JDK7, the
>> other
Provided coverage for XPath node set functions. Functions include:
- id()
- last()
- position()
- count()
- local-name()
- namespace-uri()
- name()
-
Commit messages:
- Removed unwanted whitespaces.
- Updated copyright header.
- Created XPathExpFnTest.java for XPath functions and i
On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote:
>> This patch removes the use of std::thread from the `java.lang.foreign`
>> tests, and switches to the OS specific thread APIs, in order to change
>> things such as the stack size on some platforms where this is required in
>> the future (s
On Fri, 22 Jul 2022 20:21:57 GMT, Alexey Semenyuk wrote:
> 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR:
> Failed: Check icon file"
This pull request has now been integrated.
Changeset: 7c3cfd13
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/co
On Thu, 21 Jul 2022 12:06:37 GMT, Maurizio Cimadamore
wrote:
> The javadoc for `Linker` states that some operations throw
> `UnsupportedOperationException` when called on an unsupported platform. These
> operations are:
>
> * `Linker::nativeLinker`
> * `VaList::empty`
> * `VaList::make`
> * `
> Initial implementation.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 23 additional commits since the
last revision:
- Implement review
> Adds fork and iterations controls. This reduces the runtime from 4h26m to
> about 21m and still seems stable enough for weekly testing.
Eric Caspole has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
On Sat, 23 Jul 2022 18:00:12 GMT, Raffaello Giulietti wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement review feedback.
>
> src/java.base/share/classes/java/lang/Float.java line 1112:
>
>> 1110: if (
On Fri, 8 Oct 2021 21:19:36 GMT, XenoAmess wrote:
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/5872
On Sat, 23 Jul 2022 16:38:34 GMT, Raffaello Giulietti wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement review feedback.
>
> src/java.base/share/classes/java/lang/Float.java line 980:
>
>> 978:
>> 979: /
On Mon, 25 Jul 2022 17:09:10 GMT, Roger Riggs wrote:
> ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
> The earlier fix is not sufficient for higher tier tests possibly related to
> -Xcomp.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote:
> open l10n msg drop
> All tests passed.
Why `MSG_Help_mac_launcher` in
[src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties](https://github.com/openjdk/jdk19/pull/154/files#diff-2e1b121e201e1040827d5b6
ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
The earlier fix is not sufficient for higher tier tests possibly related to
-Xcomp.
-
Commit messages:
- 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fails
Changes: https://git.openjdk.org/jdk/pull/9630/files
Web
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote:
> open l10n msg drop
> All tests passed.
Changes requested by naoto (Reviewer).
src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties line
63:
> 61: # written authorization of the copyright holder.
> 62:
> 63: ADP=ADP
On Mon, 25 Jul 2022 14:51:32 GMT, Peter Levart wrote:
> ...I can take this over, unless you want to do it, Aleksey?
I find it dubious to try and guess what GCs would do with non-strong refs, but
feel free. Don't reassign the bug yet, just see how messy that would be?
-
PR: https:/
Hi Andrey,
Not the original author of the code but I guess they are left over from
the old refactorings.
On 7/23/22 11:04 AM, Andrey Turbanov wrote:
Hello.
While I was browsing the source of java.util.TimeZone found a couple
of confusing things:
1. Static methods 'getAvailableIDs' and 'getAv
> This PR is to propose supporting the `T` extension to the BCP 47 to which
> `java.util.Locale` class conforms. There are two extensions to the BCP 47,
> one is `Unicode Locale Extension` which has been supported since JDK7, the
> other is this `Transformed Content` extension. A CSR has also be
On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Sun, 24 Jul 2022 15:45:17 GMT, Raffaello Giulietti wrote:
>> I didn't test this variant, will do tomorrow when also reviewing the tests
>> themselves.
>
> The correct variant below passes the tests.
>
>
> // For binary16 subnormals, beside forcing exp to -15,
> // retain the
On Mon, 25 Jul 2022 13:13:30 GMT, Aleksey Shipilev wrote:
> > Just a note that the failing test is not about checking that cache is
> > cleared after plain System.gc(), but about checking that cache is NOT
> > cleared after System.gc() when there was no real memory pressure. The cache
> > uses
On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Mon, 25 Jul 2022 13:04:46 GMT, Peter Levart wrote:
> Just a note that the failing test is not about checking that cache is cleared
> after plain System.gc(), but about checking that cache is NOT cleared after
> System.gc() when there was no real memory pressure. The cache uses
> SoftReferen
On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
Hi, I've noticed that in most of the code outside of JDK an InputStream taken from FileURLConnection is either read entirely e.g.in ASM's ClassLoader or passed into Properties where it's read with LineReader (which itself has an internal buffer). Apart from mark/reset activity we need buffering for
On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/9596
On Mon, 25 Jul 2022 06:40:49 GMT, Сергей Цыпанов wrote:
>> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8278461: Revert X509CertPath
I've m
34 matches
Mail list logo
