Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops [v2]

2022-07-24 Thread Сергей Цыпанов
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8278461: Revert X509CertPath - Changes: - all: https://git.openjdk.org/jdk/pull/9596/fil

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

2022-07-24 Thread Hans Boehm
I also have concerns about the use of fullFence here. I believe it should be the case that reachabilityFence guarantees visibility of memory operations program-ordered before the reachabilityFence(p) to the Cleaner associated with p. Mutator-collector synchronization should normally ensure that. On

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats [v6]

2022-07-24 Thread Raffaello Giulietti
On Sat, 23 Jul 2022 20:03:39 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/lang/Float.java line 1122: >> >>> 1120: // binary16 (when rounding is done, could still round up) >>> 1121: int exp = Math.getExponent(f); >>> 1122: assert -25 <=