Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats [v6]

2022-07-23 Thread Raffaello Giulietti
On Fri, 22 Jul 2022 01:29:57 GMT, Joe Darcy wrote: >> Initial implementation. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. src/java.base/share/classes/java/lang/Float.java line 980: > 978: > 97

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats [v6]

2022-07-23 Thread Raffaello Giulietti
On Sat, 23 Jul 2022 18:55:03 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implement review feedback. > > src/java.base/share/classes/java/lang/Float.java line 1122: > >> 1120:

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-23 Thread Сергей Цыпанов
On Sat, 23 Jul 2022 18:10:15 GMT, Andrey Turbanov wrote: >> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. > > Ow. I've created similar PR for `X509CertPath` recently #9263 @turbanoff I'll then remove the mentioned piece from this PR - PR: https://git

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

2022-07-23 Thread Andrey Turbanov
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote: > We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Ow. I've created similar PR for `X509CertPath` recently #9263 - PR: https://git.openjdk.org/jdk/pull/9596

TimeZone implementations questions

2022-07-23 Thread Andrey Turbanov
Hello. While I was browsing the source of java.util.TimeZone found a couple of confusing things: 1. Static methods 'getAvailableIDs' and 'getAvailableIDs' are marked as synchronized. But all they do - just delegate call to sun.util.calendar.ZoneInfoFile methods: public static synchronized String[