Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future (s

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats [v6]

On Fri, 22 Jul 2022 01:29:57 GMT, Joe Darcy wrote: >> Initial implementation. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. Looks good. - Marked as reviewed by jrose (Reviewer). PR:

[jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

open l10n msg drop All tests passed. - Commit messages: - open l10n drop Changes: https://git.openjdk.org/jdk19/pull/154/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=154&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290889 Stats: 3930 lines in 44 files change

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats [v6]

On Fri, 22 Jul 2022 01:29:57 GMT, Joe Darcy wrote: >> Initial implementation. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Implement review feedback. I don't claim to be an expert in IEEE formats... the methods generally l

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to a

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to a

Integrated: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java

On Mon, 4 Jul 2022 17:21:14 GMT, Shruthi wrote: > Modifying inaccurate initialization of keys in ErrorMsg.java and > XPATHErrorResources.java > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8289471 This pull request has now been integrated. Changeset: 987656d6 Author:Shr

Re: [External] : Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

> On Jun 22, 2022, at 10:28 PM, Alexander Matveev > wrote: > > Hi Michael, > > I filed it as https://bugs.openjdk.org/browse/JDK-8289030 > > > Thanks, > Alexander > Alexander, Checking on this it appears to be resolved but still doesn’t seem

RFR: 8289227: Support for BCP 47 Extension T - Transformed Content

This PR is to propose supporting the `T` extension to the BCP 47 to which `java.util.Locale` class conforms. There are two extensions to the BCP 47, one is `Unicode Locale Extension` which has been supported since JDK7, the other is this `Transformed Content` extension. A CSR has also been draft

Re: RFR: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

On Fri, 22 Jul 2022 20:21:57 GMT, Alexey Semenyuk wrote: > 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: > Failed: Check icon file" Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9618

RFR: 8290894: Reduce runtime of vm.lang microbenchmarks

Adds fork and iterations controls. This reduces the runtime from 4h26m to about 21m and still seems stable enough for weekly testing. - Commit messages: - 8290894: Reduce runtime of vm.lang microbenchmarks Changes: https://git.openjdk.org/jdk/pull/9619/files Webrev: https://webrev

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

> Please review this change to replace the finalizer in > `AbstractLdapNamingEnumeration` with a Cleaner. > > The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult > res`, and `LdapClient enumClnt`) are moved to a static inner class . From > there, the change is fairly mechan

RFR: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file" - Commit messages: - 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file" Changes: https://git.openjdk.org/jdk/pull/9618/files Webrev

Integrated: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload

On Fri, 22 Jul 2022 19:48:45 GMT, Roger Riggs wrote: > java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be > ProblemListed until the cause can be found. This pull request has now been integrated. Changeset: 2660a926 Author:Roger Riggs URL: https://git.openjdk.o

Re: RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload [v2]

On Fri, 22 Jul 2022 20:06:00 GMT, Roger Riggs wrote: >> java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be >> ProblemListed until the cause can be found. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload [v2]

> java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be > ProblemListed until the cause can be found. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Move to ProblemList-Xcomp.txt - Changes: - all: h

Re: RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload

On Fri, 22 Jul 2022 19:48:45 GMT, Roger Riggs wrote: > java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be > ProblemListed until the cause can be found. This test might only be failing with -Xcomp. Let me check... - PR: https://git.openjdk.org/jdk/pull/9617

RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload

java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be ProblemListed until the cause can be found. - Commit messages: - 8290894: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload Changes: https://git.openjdk.org/jdk/pull/9617/files Webrev: ht

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future (s

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

On Fri, 22 Jul 2022 16:41:24 GMT, Jorn Vernee wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the future (s

Re: RFR: 8290059: Do not use std::thread in panama tests

On Fri, 22 Jul 2022 15:09:13 GMT, Christoph Langer wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the futu

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

On Fri, 22 Jul 2022 14:56:16 GMT, Maurizio Cimadamore wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixes > > Looks good! @mcimadamore Thanks for the comments. I've cleaned up the comments on the compiler switc

Re: RFR: 8290059: Do not use std::thread in panama tests

On Fri, 22 Jul 2022 15:09:13 GMT, Christoph Langer wrote: >> This patch removes the use of std::thread from the `java.lang.foreign` >> tests, and switches to the OS specific thread APIs, in order to change >> things such as the stack size on some platforms where this is required in >> the futu

Re: RFR: 8290059: Do not use std::thread in panama tests

On Thu, 21 Jul 2022 18:48:14 GMT, Jorn Vernee wrote: > This patch removes the use of std::thread from the `java.lang.foreign` tests, > and switches to the OS specific thread APIs, in order to change things such > as the stack size on some platforms where this is required in the future (see > t

Re: RFR: 8290059: Do not use std::thread in panama tests [v2]

> This patch removes the use of std::thread from the `java.lang.foreign` tests, > and switches to the OS specific thread APIs, in order to change things such > as the stack size on some platforms where this is required in the future (see > the JBS issue). > > This is done by adding a small head

Re: RFR: 8290059: Do not use std::thread in panama tests

On Thu, 21 Jul 2022 18:48:14 GMT, Jorn Vernee wrote: > This patch removes the use of std::thread from the `java.lang.foreign` tests, > and switches to the OS specific thread APIs, in order to change things such > as the stack size on some platforms where this is required in the future (see > t

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

On Thu, 21 Jul 2022 02:10:27 GMT, Julian Waters wrote: >> A reimplementation of `BigDecimal.[double|float]Value()` to enhance >> performance, avoiding an intermediate string and its subsequent parsing on >> the slow path. > > Impressive performance improvements, I also like the PR title :P @Th

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v15]

On Thu, 21 Jul 2022 21:35:02 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to a

RFR: 8290059: Do not use std::thread in panama tests

This patch removes the use of std::thread from the `java.lang.foreign` tests, and switches to the OS specific thread APIs, in order to change things such as the stack size on some platforms where this is required in the future (see the JBS issue). This is done by adding a small header-only libr

Re: RFR: 8290531: Loom: Parallelize a few tests more deeply

On Tue, 19 Jul 2022 12:52:11 GMT, Aleksey Shipilev wrote: > Some of the newly added Loom tests are long-running, and thus they delay the > completion of otherwise very parallel tier1/jdk_loom. We can parallelize them > a bit better to avoid these testing stalls. > > Improvements on Linux x86_

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java >

[jdk19] Integrated: 8290460: Alpine: disable some panama tests that rely on std::thread

On Fri, 22 Jul 2022 07:04:29 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of > [JDK-8290460](https://bugs.openjdk.org/browse/JDK-8290460), commit > [d7f0de27](https://github.com/openjdk/jdk/commit/d7f0de272c85ee8d0890c9d61e10065b618b69d7) > from the [openjd

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Fri, 22 Jul 2022 10:46:57 GMT, Roman Kennke wrote: > TBH, not certain how GC policies play into that, and how well WB is supported > in each GC. Might be worth trying? > Other that that, how does removinch System.gc() help make the test more > reliable? When you call `System.gc()` on some c

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java >

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Fri, 22 Jul 2022 10:36:32 GMT, Roman Kennke wrote: > WhiteBox has a number of methods that allow better control over GC, e.g. > fullGC(), concurrentGCRunToIdle(), etc. Would that help? I think the test relies on assumption that `System.gc()` does the weak reference clearing. Which is not gi

Re: RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

On Mon, 18 Jul 2022 07:40:53 GMT, Aleksey Shipilev wrote: > Test appears to pass fine with G1. But it fails with other GCs, for example > Parallel, Shenandoah, etc, it fails: > > > $ CONF=linux-x86_64-server-fastdebug make test > TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java >

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote: > We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`. Could one advise how to execute smth like `jmod hash --module-path ~/openjdk-18.0.2/Contents/Home/jmods --hash-modules .*`? This command doesn't work for me.

Re: Unused static field AbstractWatchKey#OVERFLOW_EVENT

On 22/07/2022 5:42 pm, Andrey Turbanov wrote: Hello. I noticed unused field sun.nio.fs.AbstractWatchKey#OVERFLOW_EVENT https://github.com/openjdk/jdk/blob/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b/src/java.base/share/classes/sun/nio/fs/AbstractWatchKey.java#L45 As I can see, it was already unused

Unused static field AbstractWatchKey#OVERFLOW_EVENT

Hello. I noticed unused field sun.nio.fs.AbstractWatchKey#OVERFLOW_EVENT https://github.com/openjdk/jdk/blob/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b/src/java.base/share/classes/sun/nio/fs/AbstractWatchKey.java#L45 As I can see, it was already unused in the initial version of https://bugs.openjdk.

Re: [jdk19] RFR: 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms

On Thu, 21 Jul 2022 12:06:37 GMT, Maurizio Cimadamore wrote: > The javadoc for `Linker` states that some operations throw > `UnsupportedOperationException` when called on an unsupported platform. These > operations are: > > * `Linker::nativeLinker` > * `VaList::empty` > * `VaList::make` > * `

[jdk19] RFR: 8290460: Alpine: disable some panama tests that rely on std::thread

Hi all, This pull request contains a backport of [JDK-8290460](https://bugs.openjdk.org/browse/JDK-8290460), commit [d7f0de27](https://github.com/openjdk/jdk/commit/d7f0de272c85ee8d0890c9d61e10065b618b69d7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. It is a testfix, so sho

Re: RFR: 8290824: Use InputStream.readAllBytes() instead of explicit loops

On Thu, 21 Jul 2022 21:14:44 GMT, Mark Reinhold wrote: > Please revise the summary to say “... instead of explicit loops”. Done. > Please measure this (using, e.g., [JMH](https://github.com/openjdk/jmh)) > before making such a change. I'm aware of JMH, I was asking mostly about public API I s

Re: RFR: 8290531: Loom: Parallelize a few tests more deeply

On Tue, 19 Jul 2022 12:52:11 GMT, Aleksey Shipilev wrote: > Some of the newly added Loom tests are long-running, and thus they delay the > completion of otherwise very parallel tier1/jdk_loom. We can parallelize them > a bit better to avoid these testing stalls. > > Improvements on Linux x86_