Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign the certificate with the signer?s private >> >> Not a pro

[jdk19] Integrated: 8278274: Update nroff pages in JDK 19 before RC

2022-07-19 Thread David Holmes
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-19 Thread Jaikiran Pai
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote: > This commit ensures streams returned by ModuleReader::list are closed. Hello Ryan, the failures reported in the GitHub Actions jobs look related to this change. One such failure is in `CallerSensitiveAccess` test which throws an exception a

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

2022-07-19 Thread Jaikiran Pai
On Tue, 19 Jul 2022 14:06:52 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull req

Re: RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-19 Thread Mandy Chung
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote: > This commit ensures streams returned by ModuleReader::list are closed. LGTM - Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.org/jdk/pull/9557

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

2022-07-19 Thread Mark Reinhold
On Tue, 19 Jul 2022 14:06:52 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull req

Integrated: 8290398: jpackage exe installers are not installed in jtreg tests

2022-07-19 Thread Alexey Semenyuk
On Sat, 16 Jul 2022 21:22:46 GMT, Alexey Semenyuk wrote: > 8290398: jpackage exe installers are not installed in jtreg tests This pull request has now been integrated. Changeset: c2cbeb3e Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/c2cbeb3ee875936c98bb15ec32d692f7

Integrated: 8290400: Must run exe installers in jpackage jtreg tests without UI

2022-07-19 Thread Alexey Semenyuk
On Sat, 16 Jul 2022 21:32:07 GMT, Alexey Semenyuk wrote: > 8290400: Must run exe installers in jpackage jtreg tests without UI This pull request has now been integrated. Changeset: 1af7c33d Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/1af7c33df59cd043bdae3f681aeded

Integrated: 8283707: Support version format on Windows

2022-07-19 Thread Alexey Semenyuk
On Fri, 15 Jul 2022 04:37:58 GMT, Alexey Semenyuk wrote: > 8283707: Support version format on Windows This pull request has now been integrated. Changeset: 977e0948 Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/977e09489dd1f49d8f373ef7b8c5e47fedb82793 Stats: 13

Integrated: 8290402: jpackage exe uninstallers don't return correct exit code in case of failure

2022-07-19 Thread Alexey Semenyuk
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote: > 8290402: jpackage exe uninstallers don't return correct exit code in case of > failure This pull request has now been integrated. Changeset: d67e7ccd Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/d67e7ccda5

RFR: Merge jdk19

2022-07-19 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8290524: Typo in javadoc of MemorySegment/MemoryAddress - 8288482: JFR: Cannot resolve method - 8290417: CDS cannot archive lamda proxy with useImplMethodHandle The we

Integrated: 8290391: Reduce runtime of java.util package microbenchmarks

2022-07-19 Thread Eric Caspole
On Fri, 15 Jul 2022 18:41:09 GMT, Eric Caspole wrote: > Adds Warmup, Measurement and Fork annotations to reduce the run time from 1 > day 16 hours to 8 hours for this set. This pull request has now been integrated. Changeset: 2cb659e7 Author:Eric Caspole URL: https://git.openjdk.or

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

2022-07-19 Thread Mandy Chung
On Tue, 19 Jul 2022 14:06:52 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull req

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

2022-07-19 Thread Chris Hegarty
On Tue, 19 Jul 2022 14:06:52 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull req

[jdk19] Integrated: 8290524: Typo in javadoc of MemorySegment/MemoryAddress

2022-07-19 Thread Maurizio Cimadamore
On Tue, 19 Jul 2022 11:07:27 GMT, Maurizio Cimadamore wrote: > This patch fixes several `toRowLongValue` instead of `toRawLongValue` > scattered in the javadoc for accessor methods in `MemorySegment` and > `MemoryAddress`. This pull request has now been integrated. Changeset: e062dff1 Author

Re: [jdk19] RFR: 8290524: Typo in javadoc of MemorySegment/MemoryAddress

2022-07-19 Thread Jorn Vernee
On Tue, 19 Jul 2022 11:07:27 GMT, Maurizio Cimadamore wrote: > This patch fixes several `toRowLongValue` instead of `toRawLongValue` > scattered in the javadoc for accessor methods in `MemorySegment` and > `MemoryAddress`. Marked as reviewed by jvernee (Reviewer). - PR: https://

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-07-19 Thread Severin Gehwolf
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >> sub

Re: RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-19 Thread Ryan Ernst
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote: > This commit ensures streams returned by ModuleReader::list are closed. Note that ModulePatcher::list delegates to ModuleReader::list, but since the stream it builds closes the underlying stream, the use doesn't need to be closed within the

RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-19 Thread Ryan Ernst
This commit ensures streams returned by ModuleReader::list are closed. - Commit messages: - 8290504: Close streams returned by ModuleReader::list Changes: https://git.openjdk.org/jdk/pull/9557/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9557&range=00 Issue: https://bug

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

2022-07-19 Thread Ryan Ernst
> This commit adds additional clarification to the javadocs of > ModuleReader::list about needing to close the stream. The new wording is > similar to that used in Files::find and other similar methods. Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The

RFR: 8290531: Loom: Parallelize a few tests more deeply

2022-07-19 Thread Aleksey Shipilev
Some of the newly added Loom tests are long-running, and thus they delay the completion of otherwise very parallel tier1/jdk_loom. We can parallelize them a bit better to avoid these testing stalls. Improvements on Linux x86_64, TR 3970X, `jdk_loom hotspot_loom`: # release before real 4m41.42

Integrated: 8290397: LoadLibraryUnload.java failed with "Too few cleared WeakReferences"

2022-07-19 Thread Roger Riggs
On Mon, 18 Jul 2022 22:31:13 GMT, Roger Riggs wrote: > When running with -Xcomp it seems the wait time for GC to clear references > is insufficient. > Extend timeout waiting for GC. This pull request has now been integrated. Changeset: e02627ca Author:Roger Riggs URL: https://git.

[jdk19] RFR: 8290524: Typo in javadoc of MemorySegment/MemoryAddress

2022-07-19 Thread Maurizio Cimadamore
This patch fixes several `toRowLongValue` instead of `toRawLongValue` scattered in the javadoc for accessor methods in `MemorySegment` and `MemoryAddress`. - Commit messages: - Fix MemoryAddress typos - Initial push Changes: https://git.openjdk.org/jdk19/pull/148/files Webrev: ht

Re: RFR: 8290471: jpackage: allow to specify codepage on Windows

2022-07-19 Thread Alex Kasko
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote: > It is proposed to introduce support for `--win-codepage` argument, and > substitute the `Codepage` attribute with `--win-codepage` specified value in > primary l10n file when it is being copied to the config dir. > > Instead of copying all

Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-19 Thread Chris Hegarty
On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull req

Re: RFR: 8290353: Clarify the streams returned by ModuleReader::list [v2]

2022-07-19 Thread Chris Hegarty
On Mon, 18 Jul 2022 19:48:02 GMT, Mark Reinhold wrote: > It’s odd to mix adding some advice to the Javadoc with adopting that advice > in the code base. Consider opening a new issue and PR for the actual code > changes. [JDK-8290504][1] has been filed to track the implementation changes. @rjer

Re: [jdk19] RFR: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs

2022-07-19 Thread Aleksey Shipilev
On Mon, 18 Jul 2022 14:48:42 GMT, Roger Riggs wrote: > Committing to the mainline and then requesting a backport of the changeset > works too. Yes, that would be my plan. - PR: https://git.openjdk.org/jdk19/pull/27

Integrated: JDK-8290460: Alpine: disable some panama tests that rely on std::thread

2022-07-19 Thread Thomas Stuefe
On Mon, 18 Jul 2022 14:21:19 GMT, Thomas Stuefe wrote: > Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved, > I'd like to disable > > - java/foreign/TestUpcallAsync.java > - java/foreign/enablenativeaccess/TestEnableNativeAccess.java > > on muslc to take load from our

Re: RFR: JDK-8290460: Alpine: disable some panama tests that rely on std::thread

2022-07-19 Thread Thomas Stuefe
On Mon, 18 Jul 2022 22:21:44 GMT, Jorn Vernee wrote: >> Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved, >> I'd like to disable >> >> - java/foreign/TestUpcallAsync.java >> - java/foreign/enablenativeaccess/TestEnableNativeAccess.java >> >> on muslc to take load from

Re: RFR: 8290359: Ensure that all directory streams are closed in jdk.link [v2]

2022-07-19 Thread Chris Hegarty
On Mon, 18 Jul 2022 18:22:02 GMT, Ryan Ernst wrote: >> This commit adds try-with-resources for uses of Stream from Files >> methods that walk directories. > > Ryan Ernst has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate