Re: RFR: 8249834: java/util/ArrayList/Bug8146568.java and j/u/Vector/Bug8148174.java use @ignore w/o bug-id [v2]

2022-07-12 Thread Jaikiran Pai
On Fri, 8 Jul 2022 21:53:45 GMT, Bill Huang wrote: >> Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, >> over 17G. This is a task to re-enable these two tests by marking them as >> manual tests. > > Bill Huang has updated the pull request incrementally with one additi

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats

2022-07-12 Thread John R Rose
On Fri, 8 Jul 2022 06:11:22 GMT, Joe Darcy wrote: > Initial implementation. src/java.base/share/classes/java/lang/Float.java line 1003: > 1001: float abs_f = Math.abs(f); > 1002: int doppel = Float.floatToRawIntBits(f); > 1003: int f_sign = 0x8000_ & doppel; The cod

RFR: JDK-8289551: Conversions between bit representations of half precision values and floats

2022-07-12 Thread Joe Darcy
Initial implementation. - Commit messages: - Further refine spec. - Refine spec and tests. - Fix implementation thresholds; refine tests. - Initial implementation of float -> binary16 round-to-nearest with tests. - Implement review feedback from John Rose. - Merge branch 'master

Re: RFR: JDK-8289551: Conversions between bit representations of half precision values and floats

2022-07-12 Thread Joe Darcy
On Fri, 8 Jul 2022 06:11:22 GMT, Joe Darcy wrote: > Initial implementation. Some notes in the current implementation in the PR: the impetus for the change is to provide a minimal level of platform support for the binary16 floating-point format defined in IEEE 754. This is done by added two met

Re: RFR: 8290178: failure_handler: run netstat without name lookups

2022-07-12 Thread Jaikiran Pai
On Tue, 12 Jul 2022 13:16:12 GMT, Daniel Jeliński wrote: > `netstat -av` in Mac OS X failure handler is frequently running into the 20 > second timeout, leaving us with no socket information. This PR proposes > running `netstat -anv` along with the existing `netstat -av`, so that we have > at

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
On Wed, 13 Jul 2022 01:57:43 GMT, Naoto Sato wrote: >> Update dom.md, adding notice. > > src/java.xml/share/legal/dom.md line 4: > >> 2: >> 3: ### W3C Software Notice >> 4: > > Since this is a markdown, should this be three back-ticks "```" instead of > "pre" HTML tag? Iris can probably com

Re: RFR: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java

2022-07-12 Thread Shruthi
On Mon, 4 Jul 2022 17:21:14 GMT, Shruthi wrote: > Modifying inaccurate initialization of keys in ErrorMsg.java and > XPATHErrorResources.java > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8289471 Hi @JoeWang-Java, could we please review this PR - PR: https:/

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Iris Clark
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/138

Re: [jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Naoto Sato
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote: > Update dom.md, adding notice. src/java.xml/share/legal/dom.md line 4: > 2: > 3: ### W3C Software Notice > 4: Since this is a markdown, should this be three back-ticks "```" instead of "pre" HTML tag? - PR: https://git.openjdk

[jdk19] RFR: 8290207: Missing notice in dom.md

2022-07-12 Thread Joe Wang
Update dom.md, adding notice. - Commit messages: - 8290207: Missing notice in dom.md Changes: https://git.openjdk.org/jdk19/pull/138/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=138&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8290207 Stats: 15 lines in 1 fil

Re: RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v6]

2022-07-12 Thread Roger Riggs
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the > file descriptors it uses to create the pipeline of processes. > > The process calling `pipelineStart()` is creating the pipes between the > stages. > As each process is launched, the file descriptor is inherited by

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v3]

2022-07-12 Thread Phil Race
On Mon, 11 Jul 2022 11:46:21 GMT, Сергей Цыпанов wrote: >> We can skip bounds check and null check for Charset in case we use the array >> entirely and the Charset is either default one or proven to be non-null. >> >> Benchmark results: >> >> before >> >> Benchmark

Re: RFR: 8290079: Reduce interaction with volatile in static initializer of BigInteger

2022-07-12 Thread Сергей Цыпанов
On Tue, 12 Jul 2022 09:18:19 GMT, Raffaello Giulietti wrote: >> `BigInteger.powerCache` is volatile and should be assigned only once in >> static initializer. > > Usually yes, but since a static initializer is executed by at most one thread > by using a locking protocol before any other static

Integrated: 8289768: Clean up unused code

2022-07-12 Thread Daniel Jeliński
On Tue, 5 Jul 2022 20:19:10 GMT, Daniel Jeliński wrote: > This patch removes many unused variables and one unused label reported by the > compilers when relevant warnings are enabled. > > The unused code was found by compiling after removing `unused` from the list > of disabled warnings for

[jdk19] Integrated: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM

2022-07-12 Thread Jorn Vernee
On Wed, 29 Jun 2022 13:40:01 GMT, Jorn Vernee wrote: > This patch changes all VaList implementations to throw > `NoSuchElementException` when out of bounds reads occur on a VaList that is > created using the Java builder API. The docs are updated accordingly. > > For VaLists that are created f

Re: [jdk19] RFR: 8289930: Improve Thread description of inherited AccessControlContext [v2]

2022-07-12 Thread Jaikiran Pai
On Sun, 10 Jul 2022 07:49:50 GMT, Alan Bateman wrote: >> This is a javadoc only change. The "Inheritance when creating threads" >> section in the Thread description lists the things that are inherited when >> creating a Thread. This includes the somewhat obscure "inherited >> AccessControlCon

Re: RFR: 8290079: Reduce interaction with volatile in static initializer of BigInteger

2022-07-12 Thread Raffaello Giulietti
On Mon, 11 Jul 2022 12:41:48 GMT, Сергей Цыпанов wrote: > `BigInteger.powerCache` is volatile and should be assigned only once in > static initializer. Usually yes, but since a static initializer is executed by at most one thread by using a locking protocol before any other static code is ever

Re: RFR: 8290079: Reduce interaction with volatile in static initializer of BigInteger

2022-07-12 Thread Сергей Цыпанов
On Tue, 12 Jul 2022 08:35:50 GMT, Raffaello Giulietti wrote: >> `BigInteger.powerCache` is volatile and should be assigned only once in >> static initializer. > > (Not a reviewer) While the change doesn't hurt, I doubt that access to a > (static) volatile in a static initializer is ever contend

Re: RFR: 8290079: Reduce interaction with volatile in static initializer of BigInteger

2022-07-12 Thread Raffaello Giulietti
On Mon, 11 Jul 2022 12:41:48 GMT, Сергей Цыпанов wrote: > `BigInteger.powerCache` is volatile and should be assigned only once in > static initializer. (Not a reviewer) While the change doesn't hurt, I doubt that access to a (static) volatile in a static initializer is ever contended. ---

Re: RFR: 8289284: jdk.tracePinnedThreads output confusing when pinned due to native frame

2022-07-12 Thread Jaikiran Pai
On Tue, 28 Jun 2022 10:44:01 GMT, Alan Bateman wrote: > The system property jdk.tracePinnedThreads triggers a stack trace to be > printed when a virtual thread parks while pinned. If a virtual thread is > pinned due to a native frame there is a spurious " <== monitors:0" added to > line for th