On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote:
> Updated man pages from markdown sources.
Ok, I just hacked a patch file.
-
PR: https://git.openjdk.org/jdk19/pull/103
> Updated man pages from markdown sources.
Igor Veresov has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last revisi
On Sat, 2 Jul 2022 02:45:43 GMT, Igor Veresov wrote:
> There is also a question of which version is actually correct. Yeah, may be I
> should manually craft a patch just for the Xcomp part.
@veresov please see the closed issue
https://bugs.openjdk.org/browse/JDK-8287821
@vnkozlov when I did
On Sat, 2 Jul 2022 02:12:43 GMT, Vladimir Kozlov wrote:
> I am not sure some words changes are correct?
>
> May be we should cleanup and update all these man pages as separate issue.
> And apply only `-Xcomp` changes.
>
Then I'd have to manually craft a patch instead of actually generating th
On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote:
> Updated man pages from markdown sources.
There is also a question of which version is actually correct. Yeah, may be I
should manually craft a patch just for the Xcomp part.
-
PR: https://git.openjdk.org/jdk19/pull/103
On Sat, 2 Jul 2022 01:04:19 GMT, Igor Veresov wrote:
> Updated man pages from markdown sources.
I am not sure some words changes are correct?
May be we should cleanup and update all these man pages as separate issue. And
apply only `-Xcomp` changes.
@iklam
you recently pushed changes https:/
Updated man pages from markdown sources.
-
Commit messages:
- Update man pages
Changes: https://git.openjdk.org/jdk19/pull/103/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=103&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8245268
Stats: 495 lines in 8 files ch
On Fri, 1 Jul 2022 17:04:10 GMT, Joe Wang wrote:
> To improve efficiency, this patch moves the limit check to within the Lexer
> and reports any overlimit situation as soon as it happens.
>
> Note the change in XPathParser: diff (and also webrevs) showed the whole
> error-report block was chan
On Fri, 1 Jul 2022 17:04:10 GMT, Joe Wang wrote:
> To improve efficiency, this patch moves the limit check to within the Lexer
> and reports any overlimit situation as soon as it happens.
>
> Note the change in XPathParser: diff (and also webrevs) showed the whole
> error-report block was chan
On Fri, 1 Jul 2022 11:28:10 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes an issue where the API implementation for
> `SegmentAllocator::allocateUtf8String` does not conform to the javadoc
> implSpec.
This pull request has now been integrated.
Changeset: 8e01ffb3
Author:Mauri
On Fri, 1 Jul 2022 14:45:44 GMT, Alan Bateman wrote:
> Does this address JDK-8288286 and allow ReflectionCallerCacheTest.java to be
> removed from ProblemList-Xcomp.txt?
I think JDK-8288286 should be addressed, but I would like to have it further
evaluated via more Mach5 testing before remove
On Fri, 1 Jul 2022 18:32:18 GMT, Peter Levart wrote:
>> @plevart I've checked it with and without `@stable`, it's the same:
>>
>> with
>> BenchmarkMode Cnt Score Error Units
>> AccessParamsBenchmark.getParameter0 avgt 50 6,196 ± 0,142 ns/op
>> AccessParamsBe
On Fri, 1 Jul 2022 11:18:35 GMT, Maurizio Cimadamore
wrote:
>> This patch fixes few javadoc issues in the memory layout API.
>> The main issues are that `SequenceLayout::flatten` and
>> `SequenceLayout::reshape` still mention failures caused by a lack of size.
>> But that condition is no longe
This is a followup to simplify Shutdown.exit after the removal of
finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
on the approach has been reached in this PR, a CSR will be filed to
propose the spec change to Runtime.exit.
-
Commit messages:
- 8288984: Simpli
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so th
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so th
On Fri, 1 Jul 2022 15:28:36 GMT, Roger Riggs wrote:
> > Could someone in Oracle help me run Mach 5 testing?
>
> The CI Passed for Tiers 1-3.
Thanks a lot!
-
PR: https://git.openjdk.org/jdk/pull/8979
On Fri, 1 Jul 2022 12:26:04 GMT, Сергей Цыпанов wrote:
>> ... I can only see the array being cloned and not accessed directly. I don't
>> belive cloning a @stable array is any different in JIT-ed code as cloning
>> normal "mutable" array unless JIT "sees" through it and scalarizes the
>> value
To improve efficiency, this patch moves the limit check to within the Lexer and
reports any overlimit situation as soon as it happens.
Test: java.xml tests passed.
-
Commit messages:
- 8289486: Improve XSLT XPath operators count effiency
Changes: https://git.openjdk.org/jdk19/pull
On Fri, 1 Jul 2022 11:28:10 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes an issue where the API implementation for
> `SegmentAllocator::allocateUtf8String` does not conform to the javadoc
> implSpec.
Marked as reviewed by psandoz (Reviewer).
-
PR: https://git.openjd
On Thu, 30 Jun 2022 22:05:38 GMT, Naoto Sato wrote:
> Trivial fix to currency data files. The change was only made to its amendment
> number, as the new Sierra Leone currency has already been active with
> amendment 171.
This pull request has now been integrated.
Changeset: 604ea90d
Author:
On Fri, 1 Jul 2022 08:31:28 GMT, Xue-Lei Andrew Fan wrote:
> Could someone in Oracle help me run Mach 5 testing?
The CI Passed for Tiers 1-3.
-
PR: https://git.openjdk.org/jdk/pull/8979
On Fri, 1 Jul 2022 14:26:24 GMT, Roger Riggs wrote:
>> Thanks @XueleiFan, that's fine by me!
>
> When using Reference/ReferenceQueue there is no Cleaner, only normal
> reference processing (via GC).
I have tests that use Reference/ReferenceQueue to check that an object that
uses a Cleaner has
On Fri, 1 Jul 2022 08:35:37 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are i
On Fri, 1 Jul 2022 11:28:10 GMT, Maurizio Cimadamore
wrote:
> This simple patch fixes an issue where the API implementation for
> `SegmentAllocator::allocateUtf8String` does not conform to the javadoc
> implSpec.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote:
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
This
On Fri, 1 Jul 2022 12:28:35 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix copyright date
>
> src/hotspot/share/runtime/perfMemory.cpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2001, 2021,
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote:
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Than
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Harold Seigel has updated the pull request incrementally with
On Fri, 1 Jul 2022 08:40:06 GMT, Daniel Fuchs wrote:
>> @dfuch Taking a reference as parameter could simplify the use of ForceGC.
>> I though about this idea as well, when I had to check lambada expressions in
>> each call. I would like to do it in the future so that this PR could focus
>>
On Fri, 1 Jul 2022 09:10:07 GMT, Christoph Langer wrote:
> This pull request contains a backport of
> [JDK-8287672](https://bugs.openjdk.org/browse/JDK-8287672), commit
> [7e211d7d](https://github.com/openjdk/jdk/commit/7e211d7daac32dca8f26f408d1a3b2c7805b5a2e)
> from the [openjdk/jdk](https:/
On Mon, 27 Jun 2022 16:43:55 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Thu, 30 Jun 2022 18:39:58 GMT, Harold Seigel wrote:
> Please review this small fix to change range constrained JVM runtime options
> from 64 bits to 32 bits. This fix was tested with Mach5 tiers 1-2 on Linux,
> Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
The
On Fri, 1 Jul 2022 10:48:32 GMT, Peter Levart wrote:
>> But, ... is any code path accessing the elements of the @Stable array by
>> constant indexes? Only in that case would the annotation have any effect on
>> the JIT-ed code. Otherwise it's just a waste of space.
>
> ... I can only see the ar
This simple patch fixes an issue where the API implementation for
`SegmentAllocator::allocateUtf8String` does not conform to the javadoc implSpec.
-
Commit messages:
- Initial push
Changes: https://git.openjdk.org/jdk19/pull/99/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19
> This patch fixes few javadoc issues in the memory layout API.
> The main issues are that `SequenceLayout::flatten` and
> `SequenceLayout::reshape` still mention failures caused by a lack of size.
> But that condition is no longer possible in the new API.
>
> The javadoc of `ValueLayout::arrayE
On Fri, 1 Jul 2022 11:03:23 GMT, Maurizio Cimadamore
wrote:
> This patch fixes few javadoc issues in the memory layout API.
> The main issues are that `SequenceLayout::flatten` and
> `SequenceLayout::reshape` still mention failures caused by a lack of size.
> But that condition is no longer po
This patch fixes few javadoc issues in the memory layout API.
The main issues are that `SequenceLayout::flatten` and
`SequenceLayout::reshape` still mention failures caused by a lack of size. But
that condition is no longer possible in the new API.
The javadoc of `ValueLayout::arrayElementVarHan
On Fri, 1 Jul 2022 10:38:53 GMT, Peter Levart wrote:
>> Right, in that case, it should remain.
>
> But, ... is any code path accessing the elements of the @Stable array by
> constant indexes? Only in that case would the annotation have any effect on
> the JIT-ed code. Otherwise it's just a wast
On Fri, 1 Jul 2022 10:35:11 GMT, Peter Levart wrote:
>> @plevart so should I remove it or keep as is?
>
> Right, in that case, it should remain.
But, ... is any code path accessing the elements of the @Stable array by
constant indexes? Only in that case would the annotation have any effect on t
On Thu, 30 Jun 2022 12:08:19 GMT, Сергей Цыпанов wrote:
>> If there are two threads calling `Executable.hasRealParameterData()` under
>> race and the first one writes into volatile `Executable.parameters` field
>> (doing _releasing store_) and the second thread reads non-null value from
>> the
On Fri, 1 Jul 2022 07:27:59 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/lang/reflect/Executable.java line 457:
>>
>>> 455: private transient @Stable ParameterData parameterData;
>>> 456:
>>> 457: record ParameterData(@Stable Parameter[] parameters, boolean
>>> isReal
Hi Sergey,
On 01/07/2022 10:22, Сергей Цыпанов wrote:
And what about JavaDoc of Parameter.isNamePresent()? Should we keep it as is,
I mean pointing out to 'MethodParameters' attribute of a class file?
AFAIU that's accurate, but it would probably deserve at least a
link to the JLS?
best regar
Hi Daniel,
thanks, this is what I was looking for!
And what about JavaDoc of Parameter.isNamePresent()? Should we keep it as is,
I mean pointing out to 'MethodParameters' attribute of a class file?
Regards,
Sergey
> Hi Sergey,
>
> I believe you need to compile with `-parameters`
>
> https://d
This pull request contains a backport of
[JDK-8287672](https://bugs.openjdk.org/browse/JDK-8287672), commit
[7e211d7d](https://github.com/openjdk/jdk/commit/7e211d7daac32dca8f26f408d1a3b2c7805b5a2e)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was
Thanks!
> If you want more information about parameters, use javac with its
> "-parameters" option.
>
> -Joe
>
> On 6/28/2022 11:54 PM, Сергей Цыпанов wrote:
>
>> This question was asked originally here:
>> https://stackoverflow.com/questions/72787286/executable-hasrealparameterdata-and-parame
On Fri, 1 Jul 2022 08:26:30 GMT, Xue-Lei Andrew Fan wrote:
>> Maybe not for this PR - but it could be useful to have a version of ForceGC
>> that takes as parameter a `ReferenceQueue` and a `Reference`. That
>> would be more efficient than creating a new object and waiting for a
>> different c
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request with a
On Thu, 30 Jun 2022 18:44:30 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the closed
>> test cases are
On Fri, 1 Jul 2022 08:12:59 GMT, Daniel Fuchs wrote:
>> True, knowing when GC is 'done' is not deterministic except for a specify
>> Reference to a specific object.
>> System.gc is just a request, the checking for an object can more quickly
>> exit the loop.
>> The code is as is, and already co
On Thu, 30 Jun 2022 20:36:35 GMT, Roger Riggs wrote:
>> I'm not sure if all unused object will be collected in one GC call always.
>> The gc() specification says "When control returns from the method call, the
>> Java Virtual Machine has made a best effort to reclaim space from all unused
>>
On Fri, 1 Jul 2022 06:12:11 GMT, Peter Levart wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288327: Inline privateGetParameters()
>
> src/java.base/share/classes/java/lang/reflect/Executable.java line 457:
>
On Fri, 1 Jul 2022 06:12:11 GMT, Peter Levart wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288327: Inline privateGetParameters()
>
> src/java.base/share/classes/java/lang/reflect/Executable.java line 457:
>
53 matches
Mail list logo