Re: RFR: JDK-8288746: HttpClient resources could be reclaimed more eagerly

2022-06-25 Thread Jaikiran Pai
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a patch that should help the HttpClient's SelectorManager > thread to terminate more timely, allowing the resources consumed by the > client to be released earlier. > > The idea is to use a Cleaner registered wit

Integrated: JDK-8266670: Better modeling of access flags in core reflection

2022-06-25 Thread Joe Darcy
On Fri, 11 Feb 2022 18:31:57 GMT, Joe Darcy wrote: > This is an early review of changes to better model JVM access flags, that is > "modifiers" like public, protected, etc. but explicitly at a VM level. > > Language level modifiers and JVM level access flags are closely related, but > distinct

Re: RFR: JDK-8266670: Better modeling of access flags in core reflection [v35]

2022-06-25 Thread Joe Darcy
> This is an early review of changes to better model JVM access flags, that is > "modifiers" like public, protected, etc. but explicitly at a VM level. > > Language level modifiers and JVM level access flags are closely related, but > distinct. There are concepts that overlap in the two domains

Integrated: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-25 Thread Jaikiran Pai
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing [v2]

2022-06-25 Thread Jaikiran Pai
On Sat, 25 Jun 2022 02:45:54 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which fixes an issue in >> `jdk.internal.jimage.ImageReader`? >> >> The `ImageReader` maintains a map of `nodes` which it uses to keep track of >> directories/resources from within the image. Wh

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing [v2]

2022-06-25 Thread Jim Laskey
On Sat, 25 Jun 2022 02:45:54 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which fixes an issue in >> `jdk.internal.jimage.ImageReader`? >> >> The `ImageReader` maintains a map of `nodes` which it uses to keep track of >> directories/resources from within the image. Wh