Re: RFR: 8284493: Fix rounding error in computeNextExponential [v11]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v10]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v9]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v8]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v7]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8288667: Reduce runtime of java.text microbenchmarks

2022-06-18 Thread David Schlosnagle
On Fri, 17 Jun 2022 12:59:17 GMT, Claes Redestad wrote: > - Refactor micro using a range of parameters to a simpler benchmark that > tests different values in one pass > - Reduce iterations and their runtimes, but add forks (important to be able > to detect run-to-run variation anomalies) > >

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v6]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v5]

2022-06-18 Thread Chris Hennick
> This PR improves both the performance of `nextExponential` and `nextGaussian` > and the distribution of output at the tails. It fixes the following > imperfections: > > * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the d

Always true condition in ClassSpecializer constructor

2022-06-18 Thread Andrey Turbanov
Hello. I found suspicious null check in java.lang.invoke.ClassSpecializer constructor: S topSpecies = null; if (tsk != null && topSpecies == null) { // if there is a key, build the top species if needed: topSpecies = findSpecies(tsk); } 'null' is assigned to the 'topSpecies' variable and

Re: RFR: 8288628: Unnecessary Hashtable usage in ConditionalSpecialCasing

2022-06-18 Thread Jaikiran Pai
On Wed, 15 Jun 2022 19:49:52 GMT, Andrey Turbanov wrote: > If a thread-safe implementation is not needed, it is recommended to use > HashMap in place of Hashtable. > `ConditionalSpecialCasing.entryTable` is read-only Map which is modified only > in `static` block. It means we can safely replace