Re: RFR: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown [v3]

2022-01-30 Thread Tagir F . Valeev
> See the bug description for details. > > I propose a simple solution. Let's allow ArraySpliterator to be non-SIZED and > report artificial estimatedSize(), much bigger than the real one. This will > allow AbstractSpliterator and IteratorSpliterator to produce prefix whose > size is comparable

Re: RFR: 8280889: java/lang/instrument/GetObjectSizeIntrinsicsTest.java fails with -XX:-UseCompressedOops

2022-01-30 Thread Daniel D . Daugherty
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote: > Recent test regression after adding new cases in the test. Without compressed > oops, ~1G elements `Object[]` array takes >8G of memory, which fails the > test. The fix cuts it down to 512M when reference size is 8 bytes. > Additional

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread Alan Bateman
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh

Re: RFR: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown

2022-01-30 Thread Brian Goetz
Are you proposing dropping SIZED from the spliterator for arrays?  This would undermine all the array-based optimizations (e.g., toArray), which seems a bad trade.  I realize the splitting heuristics are frustrating for a number of use cases, but this seems like throwing the baby out with the b

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh

Re: RFR: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown

2022-01-30 Thread Tagir Valeev
Hello, Brian! On Mon, Jan 31, 2022 at 12:01 AM Brian Goetz wrote: > > Are you proposing dropping SIZED from the spliterator for arrays? This would > undermine all the array-based optimizations (e.g., toArray), which seems a > bad trade. I realize the splitting heuristics are frustrating for a

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread Alan Bateman
On Sun, 30 Jan 2022 22:06:20 GMT, David Holmes wrote: > There is no spec change here as you note, but the behavioural change also > makes this warrant a CSR request IMO. It's in draft: https://bugs.openjdk.java.net/browse/JDK-8280831, I assume Mandy will finalize shortly. - PR: h

Re: RFR: JDK-8221642: AccessibleObject::setAccessible throws NPE when invoked by JNI code with no java frame on stack

2022-01-30 Thread David Holmes
On Fri, 28 Jan 2022 17:50:19 GMT, Mandy Chung wrote: > `AccessibleObject::setAccessible` and `trySetAccessible` methods should only > allow access to public member of a public type that is unconditionally > exported consistent with the access check as described in the class > specification, wh