Re: Pull Request: 7013: AIX: InetAddress.getByName(addr) does not work as expected

2022-01-22 Thread Thomas Stüfe
Hi Micheal, welcome, and thank you for your contribution! I opened a bug id for you to track this: https://bugs.openjdk.java.net/browse/JDK-8280498 . I can sponsor this patch for you. You need one reviewer, I think. I don't have the cycles right now to think this through. I cc core-libs dev sinc

Re: Pull Request: 7013: AIX: InetAddress.getByName(addr) does not work as expected

2022-01-22 Thread Alan Bateman
On 22/01/2022 08:40, Thomas Stüfe wrote: Hi Micheal, welcome, and thank you for your contribution! I opened a bug id for you to track this: https://bugs.openjdk.java.net/browse/JDK-8280498 . I can sponsor this patch for you. You need one reviewer, I think. I don't have the cycles right now to

Re: RFR: 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapter_md

2022-01-22 Thread Alan Bateman
On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński wrote: > Reported by clang-tidy. Verified manually by running > > Calendar c = Calendar.getInstance(); > System.out.println (c.getDisplayNames(Calendar.MONTH, > Calendar.SHORT_STANDALONE, Locale.getDefault())); > > with `-Djava.

Re: RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags

2022-01-22 Thread Alan Bateman
On Fri, 21 Jan 2022 22:49:38 GMT, Mandy Chung wrote: > The MethodHandle of a default method should be made as a fixed arity method > handle because it is invoked via Proxy's invocation handle with a non-vararg > array of arguments. On the other hand, the `InvocationHandle::invokeDefault` > me

Re: RFR: JDK-8280168 Add Objects.toDefaultString [v6]

2022-01-22 Thread Joe Darcy
> While it is strongly recommend to not use the default toString for a class, > at times it is the least-bad alternative. When that alternative needs to be > used, it would be helpful to have the implementation already available, such > as in Objects.toDefaultString(). This method is analagous t

RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
Use presumed syntax that will be introduced by JDK-8280488. - Commit messages: - JDK-8280492: Address remaining doclint issues in JDK build Changes: https://git.openjdk.java.net/jdk/pull/7189/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7189&range=00 Issue: https:/

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Joe Darcy
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. This should be the (near) final step to fully enable all doclint checks during the javac portion of the build. The "reference" doclint check is currently disabled in the build comma

Re: RFR: 8280377: MethodHandleProxies does not correctly invoke default methods with varags

2022-01-22 Thread Johannes Kuhn
On Fri, 21 Jan 2022 22:49:38 GMT, Mandy Chung wrote: > The MethodHandle of a default method should be made as a fixed arity method > handle because it is invoked via Proxy's invocation handle with a non-vararg > array of arguments. On the other hand, the `InvocationHandle::invokeDefault` > me

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-22 Thread Iris Clark
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189