Re: [PATCH] Use first form of the test command

2020-08-16 Thread Issam E. Maghni
At the end of my message, it should be [4] https://github.com/emersion/mrsh/pull/160 [5] https://www.gnu.org/software/bash/manual/html_node/Special-Builtins.html

Re: [PATCH] Use first form of the test command

2020-08-16 Thread Issam E. Maghni
> Can you elaborate? Sure! These are my motivations behind the patch. 1) Consistency As Karl Berry stated [1], > it's common practice in the basic utility scripts to use test Also, using both '[' and 'test' in the same file is, as I see it, a bad practice. 2) No ambiguity with '[[' A lot of newc

Re: [PATCH] Use first form of the test command

2020-08-16 Thread Ben Elliston
On Mon, Aug 17, 2020 at 05:22:21AM +0200, Issam E. Maghni wrote: > I hope this is convincing enough :) Yes. :-) Thanks, Ben signature.asc Description: PGP signature

Re: [PATCH] Use first form of the test command

2020-08-16 Thread Ben Elliston
On Sun, Aug 16, 2020 at 07:42:57PM -0400, Issam E. Maghni wrote: > Following > https://lists.gnu.org/archive/html/automake-patches/2020-08/msg4.html > > The first form is easier to implement and directly available in BusyBox. > > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test

[PATCH] Use first form of the test command

2020-08-16 Thread Issam E. Maghni
Following https://lists.gnu.org/archive/html/automake-patches/2020-08/msg4.html > The first form is easier to implement and directly available in BusyBox. > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html > This change has also been done in make and cmake. > https://git.s