[I] Rebalancing table with no segments and "reassign instances" returns IN_PROGRESS but doesn't track the job_id or NullPointerException [pinot]

2024-01-24 Thread via GitHub
jadami10 opened a new issue, #12316: URL: https://github.com/apache/pinot/issues/12316 This is a very minor bug. It comes up in an environment where we automate rebalances somewhat independently of user asks/table config changes. Our table has: - 0 semgments - replica group conf

Re: [PR] Adding support for configuration through environment variables [pinot]

2024-01-24 Thread via GitHub
t0mpere commented on code in PR #12307: URL: https://github.com/apache/pinot/pull/12307#discussion_r1465220293 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -201,16 +200,16 @@ private static Configuration loadProperties(String configPath) {

Re: [PR] Adding support for configuration through environment variables [pinot]

2024-01-24 Thread via GitHub
t0mpere commented on code in PR #12307: URL: https://github.com/apache/pinot/pull/12307#discussion_r1465220293 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java: ## @@ -201,16 +200,16 @@ private static Configuration loadProperties(String configPath) {

[PR] Make segment download from Peer servers more robust by retrying both peer discovery and download. [pinot]

2024-01-24 Thread via GitHub
chenboat opened a new pull request, #12317: URL: https://github.com/apache/pinot/pull/12317 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

2024-01-24 Thread via GitHub
wirybeaver commented on PR #12238: URL: https://github.com/apache/pinot/pull/12238#issuecomment-1908900521 Deployed this change to the company's prod cluster with following config and the ERROR segments become ONLINE. ``` "fieldConfigList": [ { "name": "foo"

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

2024-01-24 Thread via GitHub
wirybeaver commented on code in PR #12238: URL: https://github.com/apache/pinot/pull/12238#discussion_r1460136520 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java: ## @@ -371,6 +372,40 @@ public void testGetValuesForKeyAndDocs(

[I] Pinot hitting stuck partitions while consuming transactionally [pinot]

2024-01-24 Thread via GitHub
dang-stripe opened a new issue, #12318: URL: https://github.com/apache/pinot/issues/12318 We have a Pinot cluster that consumes using isolation level READ_COMMITTED from an exactly-once Flink app upstream. This Flink app publishes using Kafka transactions. The app got into a state where it

[PR] Misc fixes for upsert metadata manager [pinot]

2024-01-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #12319: URL: https://github.com/apache/pinot/pull/12319 - Fix the race condition for `largestSeenComparisonValue` - Update primary key gauge when removing expired primary keys Other changes: - Add helper method to update primary key gauge

Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

2024-01-24 Thread via GitHub
walterddr commented on code in PR #12238: URL: https://github.com/apache/pinot/pull/12238#discussion_r1465669622 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java: ## @@ -371,6 +372,40 @@ public void testGetValuesForKeyAndDocs()

Re: [PR] Misc fixes for upsert metadata manager [pinot]

2024-01-24 Thread via GitHub
codecov-commenter commented on PR #12319: URL: https://github.com/apache/pinot/pull/12319#issuecomment-1909117465 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Misc fixes for upsert metadata manager [pinot]

2024-01-24 Thread via GitHub
Jackie-Jiang merged PR #12319: URL: https://github.com/apache/pinot/pull/12319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Misc fixes for upsert metadata manager (#12319)

2024-01-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 9c1bb02dec Misc fixes for upsert metadata manager

[PR] Remove segments with empty download url in minion-tasks [pinot]

2024-01-24 Thread via GitHub
tibrewalpratik17 opened a new pull request, #12320: URL: https://github.com/apache/pinot/pull/12320 `bugfix` During minion-task generation, if segments are missing `downloadUrl` in ZK, even those are processed and pushed to task-execution phase. While downloading the file from deep-s

Re: [PR] Remove segments with empty download url in minion-tasks [pinot]

2024-01-24 Thread via GitHub
codecov-commenter commented on PR #12320: URL: https://github.com/apache/pinot/pull/12320#issuecomment-1909555213 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R