[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11546: Fix AND and OR transform functions.

shenyu0127 commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319450751 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int l

[GitHub] [pinot] gortiz commented on a diff in pull request #11546: Fix AND and OR transform functions.

gortiz commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1319452061 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int left,

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare release release-1.0.0-rc1

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new cd14b46219 [maven-releas

[pinot] annotated tag release-1.0.0-rc1 updated (cd14b46219 -> 3975977c66)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag release-1.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.0.0-rc1 was modified! *** from cd14b46219 (commit) to 3975977c66 (t

[pinot] branch release-1.0.0-rc updated: [maven-release-plugin] prepare for next development iteration

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch release-1.0.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.0.0-rc by this push: new 642173f595 [maven-releas

[GitHub] [pinot] gortiz commented on a diff in pull request #11547: Add Boolean assertion transform functions.

gortiz commented on code in PR #11547: URL: https://github.com/apache/pinot/pull/11547#discussion_r1319461190 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsFalseTransformFunction.java: ## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Software

[pinot] annotated tag releaase-1.0.0-rc1 deleted (was 57dfaab344)

This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a change to annotated tag releaase-1.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag releaase-1.0.0-rc1 was deleted! *** tag was 57dfaab344 This change permanently di

[GitHub] [pinot] gortiz commented on a diff in pull request #11547: Add Boolean assertion transform functions.

gortiz commented on code in PR #11547: URL: https://github.com/apache/pinot/pull/11547#discussion_r1319462445 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsTrueTransformFunction.java: ## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] gortiz commented on a diff in pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

gortiz commented on code in PR #11545: URL: https://github.com/apache/pinot/pull/11545#discussion_r1319467041 ## pinot-query-planner/src/main/java/org/apache/calcite/rex/PinotRexBuilder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] gortiz commented on a diff in pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

gortiz commented on code in PR #11545: URL: https://github.com/apache/pinot/pull/11545#discussion_r1319467960 ## pinot-query-planner/src/main/java/org/apache/calcite/rex/PinotRexBuilder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11547: Add Boolean assertion transform functions.

xiangfu0 commented on code in PR #11547: URL: https://github.com/apache/pinot/pull/11547#discussion_r1319481999 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsFalseTransformFunction.java: ## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [pinot] gortiz commented on a diff in pull request #11496: [POC] close channel on direct oom

gortiz commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319597575 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

svn commit: r63854 - /dev/pinot/apache-pinot-1.0.0-rc1/

Author: saurabhd336 Date: Fri Sep 8 09:20:46 2023 New Revision: 63854 Log: Delete release-1.0.0-rc1 Removed: dev/pinot/apache-pinot-1.0.0-rc1/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional c

[GitHub] [pinot] gortiz commented on a diff in pull request #11496: [POC] close channel on direct oom

gortiz commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319597575 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] gortiz commented on a diff in pull request #11496: [POC] close channel on direct oom

gortiz commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319637595 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

svn commit: r63856 - /dev/pinot/apache-pinot-1.0.0-rc1/

Author: saurabhd336 Date: Fri Sep 8 09:51:43 2023 New Revision: 63856 Log: Update apache-pinot-1.0.0-rc1 Added: dev/pinot/apache-pinot-1.0.0-rc1/ dev/pinot/apache-pinot-1.0.0-rc1/apache-pinot-1.0.0-bin.tar.gz (with props) dev/pinot/apache-pinot-1.0.0-rc1/apache-pinot-1.0.0-bin.tar

[GitHub] [pinot] ege-st commented on a diff in pull request #11496: [POC] close channel on direct oom

ege-st commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1319899550 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] gortiz commented on a diff in pull request #11496: [POC] close channel on direct oom

gortiz commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320010451 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

zhtaoxiang commented on code in PR #11545: URL: https://github.com/apache/pinot/pull/11545#discussion_r1320014483 ## pinot-query-planner/src/main/java/org/apache/calcite/rex/PinotRexBuilder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

zhtaoxiang commented on code in PR #11545: URL: https://github.com/apache/pinot/pull/11545#discussion_r1320014483 ## pinot-query-planner/src/main/java/org/apache/calcite/rex/PinotRexBuilder.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] zhtaoxiang commented on pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

zhtaoxiang commented on PR #11545: URL: https://github.com/apache/pinot/pull/11545#issuecomment-1711849363 > Can we add some tests to verify the correct behavior? There are tests https://github.com/apache/pinot/blob/master/pinot-integration-tests/src/test/java/org/apache/pinot/integra

[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11546: Fix AND and OR transform functions.

shenyu0127 commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1320016706 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int l

[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11546: Fix AND and OR transform functions.

shenyu0127 commented on code in PR #11546: URL: https://github.com/apache/pinot/pull/11546#discussion_r1320016706 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AndOperatorTransformFunction.java: ## @@ -45,4 +48,37 @@ int getLogicalFuncResult(int l

[GitHub] [pinot] abhioncbr commented on issue #11548: ScalarTransformFunctionWrapper NULL support

abhioncbr commented on issue #11548: URL: https://github.com/apache/pinot/issues/11548#issuecomment-1711872767 Can I take a look into it? Please assign it to me. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pinot] shenyu0127 commented on issue #11548: ScalarTransformFunctionWrapper NULL support

shenyu0127 commented on issue #11548: URL: https://github.com/apache/pinot/issues/11548#issuecomment-1711875860 Feel free to take a stab. I don't have permission to assign the issue to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11547: Add Boolean assertion transform functions.

shenyu0127 commented on code in PR #11547: URL: https://github.com/apache/pinot/pull/11547#discussion_r1320044309 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/IsTrueTransformFunction.java: ## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pinot] deemoliu opened a new issue, #11549: Does Pinot hybrid table allowed to be created with different schema

deemoliu opened a new issue, #11549: URL: https://github.com/apache/pinot/issues/11549 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pinot] deemoliu commented on issue #11549: Does Pinot hybrid table allowed to be created with different schema

deemoliu commented on issue #11549: URL: https://github.com/apache/pinot/issues/11549#issuecomment-1711961851 Context We have created a hybrid table succesfully with different schema in realtime and offline part. ``` { "OFFLINE": { "tableName": "rta_fulfillment_events_

[GitHub] [pinot] Jackie-Jiang commented on issue #11477: [Feature Request] Alias column in schema (virtual column)

Jackie-Jiang commented on issue #11477: URL: https://github.com/apache/pinot/issues/11477#issuecomment-1711979518 Can you elaborate more on this: ``` In particular, this feature would allow for the support of a UNION like operation when combined with the notion of table aliasing. ``

[GitHub] [pinot] Jackie-Jiang commented on issue #10712: Add support for table alias for ease of replacing a table

Jackie-Jiang commented on issue #10712: URL: https://github.com/apache/pinot/issues/10712#issuecomment-1712028357 If we just want to add the alias support, it should be similar to the case insensitive feature, where we keep a mapping from lower-case name to the actual name. Similarly, we ca

[GitHub] [pinot] Jackie-Jiang commented on issue #11491: Rephrase the description of PinotFS lastModified OR even deprecate it

Jackie-Jiang commented on issue #11491: URL: https://github.com/apache/pinot/issues/11491#issuecomment-1712034040 How about adding an API with a second boolean flag controlling whether to throw exception or return 0 when encountering error? -- This is an automated message from the Apache

[GitHub] [pinot] JeffBolle commented on a diff in pull request #11542: [bugfix] Pulsar Stream metadata missing

JeffBolle commented on code in PR #11542: URL: https://github.com/apache/pinot/pull/11542#discussion_r1320178903 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java: ## @@ -83,9 +83,7 @@ public LegacyStreamMessage(byte[] value, StreamMessageMetadata metadat

[GitHub] [pinot] Jackie-Jiang commented on issue #11494: Leverage Json index in the group-by clause

Jackie-Jiang commented on issue #11494: URL: https://github.com/apache/pinot/issues/11494#issuecomment-1712039094 The current implementation of json index cannot be used within the group-by clause (or select clause) because it doesn't support extracting values from it, but only support chec

[GitHub] [pinot] Jackie-Jiang closed issue #11494: Leverage Json index in the group-by clause

Jackie-Jiang closed issue #11494: Leverage Json index in the group-by clause URL: https://github.com/apache/pinot/issues/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pinot] Jackie-Jiang commented on issue #11471: Pinot Server crash

Jackie-Jiang commented on issue #11471: URL: https://github.com/apache/pinot/issues/11471#issuecomment-1712043200 For your transactions, do you have an `id` field (ideally stored as LONG) associated with each transaction? Using hash string of length up to 70 can take a lot of heap memory in

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: [POC] close channel on direct oom

jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320188540 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, By

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11550: [Minor] Change an argument name in PlanMaker

Jackie-Jiang opened a new pull request, #11550: URL: https://github.com/apache/pinot/pull/11550 Missed it when modifying the interface in #11472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pinot] chenboat commented on issue #11494: Leverage Json index in the group-by clause

chenboat commented on issue #11494: URL: https://github.com/apache/pinot/issues/11494#issuecomment-1712057905 @Jackie-Jiang Today's json index stores the list of mapping from `json_path+value` to their corresponding posting lists. To make json index work for group-by, I think we can open th

[GitHub] [pinot] ege-st commented on a diff in pull request #11496: Close channel on direct oom

ege-st commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320217810 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DataTableHandler.java: ## @@ -83,5 +98,12 @@ protected void channelRead0(ChannelHandlerContext ctx, ByteBuf

[GitHub] [pinot] jugomezv commented on issue #11448: Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments

jugomezv commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-1712088501 The issue this tries to address is that we can't ensure there will not be updateIngestionDealy after the drop event. So the consequence of processing the drop and then getting and u

[GitHub] [pinot] codecov-commenter commented on pull request #11550: [Minor] Change an argument name in PlanMaker

codecov-commenter commented on PR #11550: URL: https://github.com/apache/pinot/pull/11550#issuecomment-1712097194 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11550?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jugomezv commented on pull request #11534: do not emit lag once tabledatamanager shutdown

jugomezv commented on PR #11534: URL: https://github.com/apache/pinot/pull/11534#issuecomment-1712098420 Also tagging @sajjad-moradi to take a look and make sure this may not cause other issues -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] ege-st commented on a diff in pull request #11496: Close channel on direct oom

ege-st commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320236084 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMHandler.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [pinot] ege-st commented on pull request #11496: Close channel on direct oom

ege-st commented on PR #11496: URL: https://github.com/apache/pinot/pull/11496#issuecomment-1712111812 Looks like we have some updates, I'll re-run my tests on the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pinot] jadami10 commented on issue #11448: Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments

jadami10 commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-1712133418 Hmmm, so if i'm understanding the issue, the events are: - segment goes from consuming -> online which happens every time it seals - at this point, several things might happen

[GitHub] [pinot] JeffBolle opened a new pull request, #11551: Fix stream config validator

JeffBolle opened a new pull request, #11551: URL: https://github.com/apache/pinot/pull/11551 Fixes https://github.com/apache/pinot/issues/11530 Appears to duplicate https://github.com/apache/pinot/pull/11544 however in testing @navina 's PR, I noticed that my code was still failing va

[GitHub] [pinot] JeffBolle commented on pull request #11544: Use streamType for parsing and validating protobuf decoder config

JeffBolle commented on PR #11544: URL: https://github.com/apache/pinot/pull/11544#issuecomment-1712167720 When calling `streamConfig.getDecoderProperties()`, you get back a map of just the decoder properties that, for the test data, looks like this: ``` {protoClassName=test, descriptor

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: Close channel on direct oom

jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320299982 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMHandler.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #11496: Close channel on direct oom

jasperjiaguo commented on code in PR #11496: URL: https://github.com/apache/pinot/pull/11496#discussion_r1320303194 ## pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMHandler.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] jugomezv commented on issue #11448: Realtime servers reporting lag for partitions they don't own after rebalancing w/o including consuming segments

jugomezv commented on issue #11448: URL: https://github.com/apache/pinot/issues/11448#issuecomment-1712182233 That's correct Johan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] codecov-commenter commented on pull request #11551: Fix stream config validator

codecov-commenter commented on PR #11551: URL: https://github.com/apache/pinot/pull/11551#issuecomment-1712204347 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11551?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] ege-st commented on pull request #11496: Close channel on direct oom

ege-st commented on PR #11496: URL: https://github.com/apache/pinot/pull/11496#issuecomment-1712213127 One thing that occurred to me about this approach. Can we have a situation where a query causes the Servers to send very big replies back in a sequence such that the channel restart proces

[GitHub] [pinot] Jackie-Jiang merged pull request #11550: [Minor] Change an argument name in PlanMaker

Jackie-Jiang merged PR #11550: URL: https://github.com/apache/pinot/pull/11550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: [Minor] Change an argument name in PlanMaker (#11550)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3c7cc4fa41 [Minor] Change an argument name in Pla

[GitHub] [pinot] snleee commented on a diff in pull request #11540: Keep header parsing logic the same in default CSVRecordReader and the line iterator

snleee commented on code in PR #11540: URL: https://github.com/apache/pinot/pull/11540#discussion_r1319099667 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -104,50 +103,42 @@ public void init(File

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11552: Remove the unnecessary placeholder scaler functions

Jackie-Jiang opened a new pull request, #11552: URL: https://github.com/apache/pinot/pull/11552 Remove the unnecessary placeholder scalar functions that are already configured in the `TransformFunctionType` -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pinot] codecov-commenter commented on pull request #11552: Remove the unnecessary placeholder scaler functions

codecov-commenter commented on PR #11552: URL: https://github.com/apache/pinot/pull/11552#issuecomment-1712308672 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320442196 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadToDe

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320442377 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadToDe

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320443028 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadToDe

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320443889 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentCompletionUtils.java: ## @@ -42,6 +43,19 @@ public static String getSegmentNamePrefix(St

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320444535 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -215,9 +215,14 @@ public static class ControllerPeriodicTasksConf { "

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320444625 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -215,9 +215,14 @@ public static class ControllerPeriodicTasksConf { "

[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

wirybeaver commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320445951 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadTo

[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

wirybeaver commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320446170 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadTo

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320446201 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -117,8 +117,18 @@ protected void processTable(Str

[GitHub] [pinot] chenboat commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

chenboat commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320446464 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -47,10 +47,10 @@ import org.apache.pinot.controll

[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

wirybeaver commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320446625 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,72 @@ public void uploadTo

[GitHub] [pinot] wirybeaver commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

wirybeaver commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1320447063 ## pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java: ## @@ -117,8 +117,18 @@ protected void processTable(S

[GitHub] [pinot] shenyu0127 opened a new pull request, #11553: Null support for protobuf ingestion.

shenyu0127 opened a new pull request, #11553: URL: https://github.com/apache/pinot/pull/11553 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [pinot] codecov-commenter commented on pull request #11553: Null support for protobuf ingestion.

codecov-commenter commented on PR #11553: URL: https://github.com/apache/pinot/pull/11553#issuecomment-1712412650 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R