codecov-commenter commented on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
xiangfu0 opened a new pull request #8197:
URL: https://github.com/apache/pinot/pull/8197
## Description
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **backward-incompat**, a
xiangfu0 commented on a change in pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#discussion_r805314378
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerServiceDiscoveryIntegrationTest.java
##
@@ -0,0 +1,93 @@
xiangfu0 commented on pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#issuecomment-1038001955
> High level question: does this affect startup time?
I think this more comes from each customized Feature implementation?
--
This is an automated message from the Apach
xiangfu0 merged pull request #7486:
URL: https://github.com/apache/pinot/pull/7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 22b17c3 adding scala profile for kafka 2.x build and remove root pom
scala dependencies (#8174)
add 37f27f5 a
codecov-commenter commented on pull request #8197:
URL: https://github.com/apache/pinot/pull/8197#issuecomment-1038031348
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
richardstartin commented on pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#issuecomment-1038188674
> > High level question: does this affect startup time?
>
> I think this more comes from each customized Feature implementation?
Is there a discovery cost?
-
xiangfu0 merged pull request #8197:
URL: https://github.com/apache/pinot/pull/8197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
kriti-sc commented on pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#issuecomment-1038451857
Just noting that I have taken note of the review comments and am working on
them. I have just gotten absurdly busy, hence the delay surrounding this and
this note.
--
This is
kriti-sc commented on pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#issuecomment-1038451857
Just noting that I have taken note of the review comments and am working on
them. I have just gotten absurdly busy, hence the delay surrounding this and
this note.
--
This is
mayankshriv commented on issue #8141:
URL: https://github.com/apache/pinot/issues/8141#issuecomment-1037272894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
richardstartin commented on pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#issuecomment-1038188674
> > High level question: does this affect startup time?
>
> I think this more comes from each customized Feature implementation?
Is there a discovery cost?
-
xiangfu0 merged pull request #7486:
URL: https://github.com/apache/pinot/pull/7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
walterddr commented on a change in pull request #8158:
URL: https://github.com/apache/pinot/pull/8158#discussion_r805174987
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -710,14 +711,18 @@ private static Expression
compileFu
codecov-commenter commented on pull request #8197:
URL: https://github.com/apache/pinot/pull/8197#issuecomment-1038031348
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
amrishlal commented on a change in pull request #8029:
URL: https://github.com/apache/pinot/pull/8029#discussion_r804423493
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextUtils.java
##
@@ -38,7 +39,11 @@ private QueryContex
xiangfu0 commented on a change in pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#discussion_r805314378
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerServiceDiscoveryIntegrationTest.java
##
@@ -0,0 +1,93 @@
xiangfu0 merged pull request #8197:
URL: https://github.com/apache/pinot/pull/8197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
codecov-commenter commented on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #7486:
URL: https://github.com/apache/pinot/pull/7486#issuecomment-1037969654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
kkrugler commented on issue #8141:
URL: https://github.com/apache/pinot/issues/8141#issuecomment-1037430769
Re segment download & metadata extraction, yes that's happening where the
push job is running. I've got a separate (in progress) PR that does a streaming
extract of just the two file
pjfanning commented on a change in pull request #8158:
URL: https://github.com/apache/pinot/pull/8158#discussion_r805175198
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -710,14 +711,18 @@ private static Expression
compileFu
xiangfu0 commented on pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#issuecomment-1038001955
> High level question: does this affect startup time?
I think this more comes from each customized Feature implementation?
--
This is an automated message from the Apach
xiangfu0 commented on a change in pull request #8158:
URL: https://github.com/apache/pinot/pull/8158#discussion_r805200267
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -710,14 +711,18 @@ private static Expression
compileFun
28 matches
Mail list logo
