xiangfu0 opened a new pull request #7333:
URL: https://github.com/apache/pinot/pull/7333
## Description
fixing code styling for pinot-broker
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (
codecov-commenter edited a comment on pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#issuecomment-882112478
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
xiangfu0 opened a new pull request #7334:
URL: https://github.com/apache/pinot/pull/7334
## Description
fixing code styling of pinot-server
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Pleas
codecov-commenter edited a comment on pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#issuecomment-882112478
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7333:
URL: https://github.com/apache/pinot/pull/7333#issuecomment-901699510
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7333?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7334:
URL: https://github.com/apache/pinot/pull/7334#issuecomment-901700685
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7334:
URL: https://github.com/apache/pinot/pull/7334#issuecomment-901700685
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
xiangfu0 opened a new pull request #7335:
URL: https://github.com/apache/pinot/pull/7335
## Description
- Fixing pinot-minion
- fixing pinot-perf
- fixing pinot-tools
- fixing pinot-integration-tests
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (A
codecov-commenter commented on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
Arpita030125 opened a new issue #7336:
URL: https://github.com/apache/pinot/issues/7336
Hi , I am trying the retention period in realtime table, with
"retentionTimeValue”: 1 and “retentionTimeUnit”: “HOURS”. But I can still see
the segments post 1 hour of creation although they should b
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7334:
URL: https://github.com/apache/pinot/pull/7334#issuecomment-901700685
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
aesteve opened a new issue #7337:
URL: https://github.com/apache/pinot/issues/7337
The documentation
[here](https://docs.pinot.apache.org/basics/data-import/complex-type#infer-the-pinot-schema-from-the-avro-schema-and-json-data)
mentions the following command:
```
bin/pinot-admin.sh
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
mcvsubbu commented on issue #7336:
URL: https://github.com/apache/pinot/issues/7336#issuecomment-901991656
The automatic deletion happens via a periodic job. Perhaps that job did not
run as yet. You can adjust the timing for the job to run more frequently. Also,
the retention policy retain
suddendust commented on issue #7264:
URL: https://github.com/apache/pinot/issues/7264#issuecomment-902063607
@Jackie-Jiang shall we start with adding a partial response flag here? What
do you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message,
suddendust edited a comment on issue #7264:
URL: https://github.com/apache/pinot/issues/7264#issuecomment-902063607
@Jackie-Jiang shall we start with adding a partial response flag here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aa5f318 add mode aggregation function (#7318)
aa
Jackie-Jiang merged pull request #7318:
URL: https://github.com/apache/pinot/pull/7318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter edited a comment on pull request #7282:
URL: https://github.com/apache/pinot/pull/7282#issuecomment-896455835
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
npawar commented on a change in pull request #7294:
URL: https://github.com/apache/pinot/pull/7294#discussion_r692373519
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java
##
@@ -169,7 +158,20 @@ pu
amrishlal commented on a change in pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#discussion_r692440213
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java
##
@@ -29,21 +33,31 @@
@ThreadSafe
public abstract clas
Jackie-Jiang opened a new issue #7338:
URL: https://github.com/apache/pinot/issues/7338
Currently when reloading the segments for a table, the segments are reloaded
sequentially (single threaded). This is intentional because segment reload
usually needs to generate new indexes on the fly,
Jackie-Jiang commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r692458669
##
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##
@@ -208,7 +205,9 @@ publi
mcvsubbu commented on issue #7338:
URL: https://github.com/apache/pinot/issues/7338#issuecomment-90529
Another reason this is reloaded one at a time is because the memory needed
is doubled per segment. Both segments are in memory while query from the old
segment is drained and new quer
mayankshriv opened a new pull request #7339:
URL: https://github.com/apache/pinot/pull/7339
## Description
Since Apache Pinot is out of incubation, replacing the title in the UI
to reflect the same.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgra
codecov-commenter commented on pull request #7339:
URL: https://github.com/apache/pinot/pull/7339#issuecomment-902258774
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7339:
URL: https://github.com/apache/pinot/pull/7339#issuecomment-902258774
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7329:
URL: https://github.com/apache/pinot/pull/7329#discussion_r692505742
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineageAccessHelper.java
##
@@ -79,4 +80,17 @@ public static boolean
Jackie-Jiang merged pull request #7294:
URL: https://github.com/apache/pinot/pull/7294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 94b9ca3 cleanup segment preprocessor a bit to ma
jackjlli commented on a change in pull request #7331:
URL: https://github.com/apache/pinot/pull/7331#discussion_r692512894
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java
##
@@ -38,20 +38,20 @@
private s
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7335:
URL: https://github.com/apache/pinot/pull/7335#issuecomment-901766948
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r692528928
##
File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml
##
@@ -58,6 +58,16 @@
1.6.0
+
Review comment:
It shouldn't
timsants closed pull request #7330:
URL: https://github.com/apache/pinot/pull/7330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
timsants commented on pull request #7330:
URL: https://github.com/apache/pinot/pull/7330#issuecomment-902295122
Closing PR as this version bump causes test failure in OSS. Will revisit
other approaches.
--
This is an automated message from the Apache Git Service.
To respond to the messag
klsince commented on a change in pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#discussion_r692531210
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
##
@@ -104,147 +104,62 @@ private Trans
Jackie-Jiang commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r692532818
##
File path: pinot-integration-tests/pom.xml
##
@@ -124,6 +128,74 @@
+
+
Jackie-Jiang commented on a change in pull request #7325:
URL: https://github.com/apache/pinot/pull/7325#discussion_r692545485
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java
##
@@ -134,7 +134,8 @@ void reloadAllSegments(Strin
mayankshriv merged pull request #7339:
URL: https://github.com/apache/pinot/pull/7339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 892a0c1 Cleanup: Replace `Incubator Pinot` refe
Jackie-Jiang commented on a change in pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#discussion_r692550023
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SingleFileIndexDirectory.java
##
@@ -387,4 +398,66 @@ pub
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-902316020
The argument should be `-dateTimeColumnName`. Updated the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Jackie-Jiang commented on issue #7264:
URL: https://github.com/apache/pinot/issues/7264#issuecomment-902318772
I'd suggest adding different errors for each scenario described above to the
`QueryException`, and users can decide on how to proceed based on the error
type (error code). We alre
xiangfu0 commented on a change in pull request #7325:
URL: https://github.com/apache/pinot/pull/7325#discussion_r692557904
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java
##
@@ -134,7 +134,8 @@ void reloadAllSegments(String ta
codecov-commenter edited a comment on pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#issuecomment-901313573
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
xiangfu0 commented on a change in pull request #7325:
URL: https://github.com/apache/pinot/pull/7325#discussion_r692557904
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java
##
@@ -134,7 +134,8 @@ void reloadAllSegments(String ta
codecov-commenter edited a comment on pull request #7317:
URL: https://github.com/apache/pinot/pull/7317#issuecomment-900984108
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
amrishlal opened a new pull request #7340:
URL: https://github.com/apache/pinot/pull/7340
## Description
When user invokes controller api with an unknown table name, following error
message is generated in
`PinotHelixResourceManager.getExistingTableNamesWithType()` function :
```
xiangfu0 commented on a change in pull request #7331:
URL: https://github.com/apache/pinot/pull/7331#discussion_r692559821
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableSegmentConfigs.java
##
@@ -49,30 +49,31 @@
private sta
Jackie-Jiang commented on a change in pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#discussion_r692560901
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java
##
@@ -54,14 +55,27 @@ pu
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7174:
URL: https://github.com/apache/pinot/pull/7174#discussion_r692568185
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java
##
@@ -29,21 +33,31 @@
@ThreadSafe
public abstract c
codecov-commenter edited a comment on pull request #7317:
URL: https://github.com/apache/pinot/pull/7317#issuecomment-900984108
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
chenboat opened a new pull request #7341:
URL: https://github.com/apache/pinot/pull/7341
## Description
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **backward-incompat**, a
Jackie-Jiang commented on issue #7338:
URL: https://github.com/apache/pinot/issues/7338#issuecomment-902333664
@mcvsubbu We have a `maxParallelRefreshThreads` configured within the
`SegmentMessageHandlerFactory` to guard on the issue you described, and that's
the reason why I mentioned we
xiangfu0 closed issue #7309:
URL: https://github.com/apache/pinot/issues/7309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
xiangfu0 merged pull request #7317:
URL: https://github.com/apache/pinot/pull/7317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7340:
URL: https://github.com/apache/pinot/pull/7340#issuecomment-902336225
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7331:
URL: https://github.com/apache/pinot/pull/7331#issuecomment-901560167
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7340:
URL: https://github.com/apache/pinot/pull/7340#issuecomment-902336225
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#discussion_r692576894
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java
##
@@ -104,147 +104,62 @@ private
codecov-commenter edited a comment on pull request #7340:
URL: https://github.com/apache/pinot/pull/7340#issuecomment-902336225
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7325:
URL: https://github.com/apache/pinot/pull/7325#discussion_r692578133
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java
##
@@ -134,7 +134,8 @@ void reloadAllSegments(Strin
codecov-commenter edited a comment on pull request #7340:
URL: https://github.com/apache/pinot/pull/7340#issuecomment-902336225
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7340:
URL: https://github.com/apache/pinot/pull/7340#discussion_r692582096
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -2596,7 +2596,7 @@ public boo
jackjlli commented on issue #7264:
URL: https://github.com/apache/pinot/issues/7264#issuecomment-902350507
Not all the partial response is useless or harmful. There is another
scenario that falls into partial response, which is that
`isNumGroupsLimitReached()` from brokerResponse returns t
codecov-commenter commented on pull request #7341:
URL: https://github.com/apache/pinot/pull/7341#issuecomment-902350795
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
kkrugler commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r692585833
##
File path: pinot-integration-tests/pom.xml
##
@@ -124,6 +128,74 @@
+
+
kkrugler commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r692586058
##
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskR
codecov-commenter edited a comment on pull request #7341:
URL: https://github.com/apache/pinot/pull/7341#issuecomment-902350795
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7341:
URL: https://github.com/apache/pinot/pull/7341#issuecomment-902350795
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#issuecomment-901571722
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#issuecomment-901313573
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#issuecomment-901571722
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
xiangfu0 opened a new pull request #7342:
URL: https://github.com/apache/pinot/pull/7342
## Description
- Reformat entire codebase to length <= 120
- Change checkstyle line length rule to 120
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade orde
snleee opened a new pull request #7343:
URL: https://github.com/apache/pinot/pull/7343
There has been a minor bug where we iterate the lineage entries
using `.keySet()` and we call `map.remove()` to delete the entry.
This addresses the issue.
--
This is an automated message from the
xiangfu0 commented on a change in pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#discussion_r692613502
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java
##
@@ -47,24 +52,43 @@
public
xiangfu0 commented on a change in pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#discussion_r692616921
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java
##
@@ -47,24 +52,43 @@
public
xiangfu0 commented on a change in pull request #7332:
URL: https://github.com/apache/pinot/pull/7332#discussion_r692616921
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java
##
@@ -47,24 +52,43 @@
public
codecov-commenter commented on pull request #7342:
URL: https://github.com/apache/pinot/pull/7342#issuecomment-902394157
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
mcvsubbu commented on issue #7338:
URL: https://github.com/apache/pinot/issues/7338#issuecomment-902396297
For some reason I thought there is a helix config that sets the number of
parallel threads in the server. I remember we configured something like that
for our internal cluster to supp
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7342:
URL: https://github.com/apache/pinot/pull/7342#issuecomment-902394157
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7342:
URL: https://github.com/apache/pinot/pull/7342#issuecomment-902394157
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7342:
URL: https://github.com/apache/pinot/pull/7342#issuecomment-902394157
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7342?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7301:
URL: https://github.com/apache/pinot/pull/7301#issuecomment-898780326
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kkrugler commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r692638012
##
File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml
##
@@ -58,6 +58,16 @@
1.6.0
+
Review comment:
OK, done
--
lakshmanan-v commented on a change in pull request #7226:
URL: https://github.com/apache/pinot/pull/7226#discussion_r692639060
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawTDigestAggregationFunction.java
##
@@ -0,0 +1,142
lakshmanan-v commented on a change in pull request #7226:
URL: https://github.com/apache/pinot/pull/7226#discussion_r692639497
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationMultiValueQueriesTest.java
##
@@ -519,6 +519,119 @@ public void
lakshmanan-v commented on a change in pull request #7226:
URL: https://github.com/apache/pinot/pull/7226#discussion_r692639552
##
File path:
pinot-core/src/test/java/org/apache/pinot/queries/ExpectedQueryResult.java
##
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software
lakshmanan-v commented on a change in pull request #7226:
URL: https://github.com/apache/pinot/pull/7226#discussion_r692639683
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileRawEstAggregationFunction.java
##
@@ -0,0 +1,141 @@
codecov-commenter commented on pull request #7343:
URL: https://github.com/apache/pinot/pull/7343#issuecomment-902408344
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
1 - 100 of 111 matches
Mail list logo
