Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

Jackie-Jiang commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2074166131 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nul

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

xiangfu0 commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2073422374 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nullabl

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

xiangfu0 commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2072930849 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nullabl

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

xiangfu0 commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2072930849 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nullabl

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

Jackie-Jiang commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2070558978 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nul

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

xiangfu0 commented on PR #15672: URL: https://github.com/apache/pinot/pull/15672#issuecomment-2843960969 > hey @xiangfu0 would it make sense to put this behind a config and disable it by default? so that this behavior change doesn't take anyone by surprise? I was also thinking about t

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

somandal commented on PR #15672: URL: https://github.com/apache/pinot/pull/15672#issuecomment-2842675339 hey @xiangfu0 would it make sense to put this behind a config and disable it by default? so that this behavior change doesn't take anyone by surprise? -- This is an automated message f

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

codecov-commenter commented on PR #15672: URL: https://github.com/apache/pinot/pull/15672#issuecomment-2839465326 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15672?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u