Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz closed pull request #11824: Add nullability to FieldSpec and use it in TypeFactory URL: https://github.com/apache/pinot/pull/11824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1878277106 The same issue was solved in https://github.com/apache/pinot/pull/11960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1381249416 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/nullvalue/NullValueIndexType.java: ## @@ -77,11 +81,24 @@ public String getPrettyName()

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1381249416 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/nullvalue/NullValueIndexType.java: ## @@ -77,11 +81,24 @@ public String getPrettyName()

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1381244838 ## pinot-query-planner/src/test/java/org/apache/pinot/query/testutils/MockRoutingManagerFactory.java: ## @@ -63,25 +66,28 @@ public MockRoutingManagerFactory(int... port

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

Jackie-Jiang commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1381222882 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java: ## @@ -52,13 +52,24 @@ public RelDataType createRelDataTypeFromSchema(Schema sc

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

Jackie-Jiang commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1381215533 ## pinot-query-planner/src/test/java/org/apache/pinot/query/testutils/MockRoutingManagerFactory.java: ## @@ -63,25 +66,28 @@ public MockRoutingManagerFactory(int..

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1790424446 > Column level can BE overridden by query-level config if configured I don't think we can do this without actually applying deep changes to the code. Column level config (defined in

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

walterddr commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1789144413 > Using your words, semantic in phase 1 is: > > * For write path (null value vector creation): > > * ON iff only enabled at table level > * For query path: >

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

walterddr commented on code in PR #11824: URL: https://github.com/apache/pinot/pull/11824#discussion_r1378937058 ## pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java: ## @@ -300,6 +303,27 @@ public void setTransformFunction(@Nullable String transformFunction) {

Re: [PR] Add nullability to FieldSpec and use it in TypeFactory [pinot]

gortiz commented on PR #11824: URL: https://github.com/apache/pinot/pull/11824#issuecomment-1787260287 I think the PR is ready to review. Some tests have been added (although more can be added in future or if they are requested by reviewers). -- This is an automated message from the Apach