Jackie-Jiang merged PR #13222:
URL: https://github.com/apache/pinot/pull/13222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
sullis commented on PR #13222:
URL: https://github.com/apache/pinot/pull/13222#issuecomment-2212529886
> Thanks for taking time to do this upgrade! Do we still need to keep
httpclient 4 related dependencies?
For now, I think we need to keep httpclient 4 in the project's root pom.xml
sullis commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726958
##
pinot-plugins/pinot-environment/pinot-azure/src/main/java/org/apache/pinot/plugin/provider/AzureHttpRequestRetryStrategy.java:
##
@@ -0,0 +1,30 @@
+/**
+ * Licensed t
sullis commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726933
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRunningQueryResource.java:
##
@@ -112,50 +116,46 @@ public String cancelQuery(
@A
sullis commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1667726855
##
pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java:
##
@@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable
String taskType, @Nulla
sullis commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1667711824
##
pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java:
##
@@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable
String taskType, @Nulla
Jackie-Jiang commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1663288580
##
pinot-common/src/main/java/org/apache/pinot/common/minion/MinionClient.java:
##
@@ -72,8 +72,8 @@ public Map scheduleMinionTasks(@Nullable
String taskType, @Nu
sullis commented on PR #13222:
URL: https://github.com/apache/pinot/pull/13222#issuecomment-2204517052
Rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Jackie-Jiang commented on code in PR #13222:
URL: https://github.com/apache/pinot/pull/13222#discussion_r1614852879
##
pinot-common/pom.xml:
##
@@ -161,6 +161,10 @@
org.apache.httpcomponents
httpmime
+
Review Comment:
Thanks for the great effort of th
