Re: [PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-18 Thread via GitHub
Jackie-Jiang merged PR #13793: URL: https://github.com/apache/pinot/pull/13793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-13 Thread via GitHub
gortiz commented on PR #13793: URL: https://github.com/apache/pinot/pull/13793#issuecomment-2285695077 > Just a minor question: does it make sense to add the dependency for warning suppression or better visibility? I am fine with it, just asking for understanding. Thanks The dependen

Re: [PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-12 Thread via GitHub
abhioncbr commented on PR #13793: URL: https://github.com/apache/pinot/pull/13793#issuecomment-2284121280 Thanks, @gortiz, for this. Yesterday, I was looking for the same warnings on IntelliJ and a solution. This overall helps the developer while working on the codebase. Just a mino

Re: [PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-12 Thread via GitHub
codecov-commenter commented on PR #13793: URL: https://github.com/apache/pinot/pull/13793#issuecomment-2283409503 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13793?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] intellij-language-annotation: add annotation on tests [pinot]

2024-08-12 Thread via GitHub
gortiz opened a new pull request, #13793: URL: https://github.com/apache/pinot/pull/13793 This is a simple PR that adds the `@Language("sql")` annotation on most test method arguments. When used, this annotation indicates Intellij that the caller string should be a string and therefo