Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang merged PR #14612: URL: https://github.com/apache/pinot/pull/14612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-11 Thread via GitHub
Jackie-Jiang commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1880779926 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1256,8 +1256,9 @@ private long validateSegmentSt

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-10 Thread via GitHub
jadami10 commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1879333029 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -1256,8 +1256,9 @@ private long validateSegmentStateF

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-10 Thread via GitHub
Jackie-Jiang commented on code in PR #14612: URL: https://github.com/apache/pinot/pull/14612#discussion_r1878946618 ## pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/TableSegmentValidationInfo.java: ## @@ -41,4 +44,8 @@ public boolean isValid() { public

Re: [PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-05 Thread via GitHub
codecov-commenter commented on PR #14612: URL: https://github.com/apache/pinot/pull/14612#issuecomment-2522028690 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14612?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] include reason why TableSegmentValidationInfo is invalid [pinot]

2024-12-05 Thread via GitHub
jadami10 opened a new pull request, #14612: URL: https://github.com/apache/pinot/pull/14612 This is an API enhancement so servers give a reason for why time boundary advance failing. We've found with tables wtih 10k+ segments, this API will repeatedly fail, but there's no way to debug what