Re: [PR] colocated-without-hints [pinot]

2024-10-16 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1803542898 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,64 @@ public class QueryEnvironment { private final Framew

Re: [PR] colocated-without-hints [pinot]

2024-10-16 Thread via GitHub
gortiz merged PR #13943: URL: https://github.com/apache/pinot/pull/13943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] colocated-without-hints [pinot]

2024-10-16 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1802916505 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,64 @@ public class QueryEnvironment { private final FrameworkCon

Re: [PR] colocated-without-hints [pinot]

2024-10-16 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1802902579 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/hint/PinotHintStrategyTable.java: ## @@ -108,4 +110,25 @@ public static String getHintOption(List hintL

Re: [PR] colocated-without-hints [pinot]

2024-10-16 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r180240 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -343,7 +343,9 @@ public static class Broker { public static final String CONFIG_

Re: [PR] colocated-without-hints [pinot]

2024-10-15 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801671644 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +447,44 @@ private static HepProgram getTraitProgram() { }

Re: [PR] colocated-without-hints [pinot]

2024-10-15 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801076744 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,64 @@ public class QueryEnvironment { private final FrameworkCon

Re: [PR] colocated-without-hints [pinot]

2024-10-15 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801073246 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-15 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1801059669 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1797478438 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Softw

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
Jackie-Jiang commented on PR #13943: URL: https://github.com/apache/pinot/pull/13943#issuecomment-2407950547 @gortiz Yes! I think we can enable it by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on PR #13943: URL: https://github.com/apache/pinot/pull/13943#issuecomment-2407330774 @Jackie-Jiang Question: Should we also set `pinot.broker.enable.partition.metadata.manager` to true by default? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796900105 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796851649 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796841573 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796836057 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java: ## @@ -484,79 +507,119 @@ private PartitionTableInfo getPartitionTableInfo(String

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796828117 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796827534 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796827534 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796825749 ## pom.xml: ## @@ -1444,8 +1444,10 @@ org.immutables -value-annotations +bom Review Comment: Probably not given the processo

Re: [PR] colocated-without-hints [pinot]

2024-10-11 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796556857 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java: ## @@ -484,79 +507,119 @@ private PartitionTableInfo getPartitionTableInfo(

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1796257745 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +442,44 @@ private static HepProgram getTraitProgram() { }

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795376195 ## pinot-query-planner/pom.xml: ## @@ -49,6 +49,11 @@ org.codehaus.janino commons-compiler + + org.immutables + value Review Comment:

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795374252 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -398,8 +442,44 @@ private static HepProgram getTraitProgram() { } //

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795372378 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -343,6 +343,8 @@ public static class Broker { public static final String CONFIG_OF

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795369685 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -100,26 +111,58 @@ public class QueryEnvironment { private final FrameworkCon

Re: [PR] colocated-without-hints [pinot]

2024-10-10 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1795331857 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-10-08 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1792150017 ## pinot-query-planner/pom.xml: ## @@ -49,6 +49,11 @@ org.codehaus.janino commons-compiler + + org.immutables + value Review Comment:

Re: [PR] colocated-without-hints [pinot]

2024-09-23 Thread via GitHub
gortiz commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1772688368 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] colocated-without-hints [pinot]

2024-09-23 Thread via GitHub
vrajat commented on code in PR #13943: URL: https://github.com/apache/pinot/pull/13943#discussion_r1772619586 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Fo