Jackie-Jiang merged PR #13094:
URL: https://github.com/apache/pinot/pull/13094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -78,7 +78,7 @@ public RealtimeL
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1593319012
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##
@@ -216,6 +217,7 @@ public boolean isMutableSe
Jackie-Jiang commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1593091288
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##
@@ -216,6 +217,7 @@ public boolean isMutableSe
chenboat commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1592881532
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java:
##
@@ -121,6 +121,7 @@ public enum TimeColumnType {
private boo
jackjlli commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1592855467
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java:
##
@@ -106,7 +106,7 @@ public static HashSet
codecov-commenter commented on PR #13094:
URL: https://github.com/apache/pinot/pull/13094#issuecomment-2097491584
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13094?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
itschrispeck commented on code in PR #13094:
URL: https://github.com/apache/pinot/pull/13094#discussion_r1591820799
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -151,9 +151,9 @@ public Mutable
11 matches
Mail list logo