Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-10 Thread via GitHub
Jackie-Jiang merged PR #13094: URL: https://github.com/apache/pinot/pull/13094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-10 Thread via GitHub
itschrispeck commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -78,7 +78,7 @@ public RealtimeL

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-10 Thread via GitHub
itschrispeck commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1597297983 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -78,7 +78,7 @@ public RealtimeL

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -78,7 +78,7 @@ public RealtimeL

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-10 Thread via GitHub
Jackie-Jiang commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1597287473 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -78,7 +78,7 @@ public RealtimeL

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-07 Thread via GitHub
itschrispeck commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1593319012 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -216,6 +217,7 @@ public boolean isMutableSe

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-07 Thread via GitHub
Jackie-Jiang commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1593091288 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -216,6 +217,7 @@ public boolean isMutableSe

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-07 Thread via GitHub
chenboat commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1592881532 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java: ## @@ -121,6 +121,7 @@ public enum TimeColumnType { private boo

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-07 Thread via GitHub
jackjlli commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1592855467 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/text/LuceneTextIndexCreator.java: ## @@ -106,7 +106,7 @@ public static HashSet

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-06 Thread via GitHub
codecov-commenter commented on PR #13094: URL: https://github.com/apache/pinot/pull/13094#issuecomment-2097491584 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13094?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] bugfix: use consumerDir during lucene realtime segment conversion [pinot]

2024-05-06 Thread via GitHub
itschrispeck commented on code in PR #13094: URL: https://github.com/apache/pinot/pull/13094#discussion_r1591820799 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java: ## @@ -151,9 +151,9 @@ public Mutable