Re: [PR] add null handling to sketch group-by [pinot]

2024-01-11 Thread via GitHub
walterddr merged PR #12259: URL: https://github.com/apache/pinot/pull/12259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] add null handling to sketch group-by [pinot]

2024-01-11 Thread via GitHub
walterddr commented on code in PR #12259: URL: https://github.com/apache/pinot/pull/12259#discussion_r1449327737 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java: ## @@ -964,6 +964,14 @@ public List ex

Re: [PR] add null handling to sketch group-by [pinot]

2024-01-11 Thread via GitHub
walterddr commented on code in PR #12259: URL: https://github.com/apache/pinot/pull/12259#discussion_r1449210569 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java: ## @@ -964,6 +964,14 @@ public List ex

Re: [PR] add null handling to sketch group-by [pinot]

2024-01-11 Thread via GitHub
codecov-commenter commented on PR #12259: URL: https://github.com/apache/pinot/pull/12259#issuecomment-1887614239 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12259?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] add null handling to sketch group-by [pinot]

2024-01-11 Thread via GitHub
walterddr opened a new pull request, #12259: URL: https://github.com/apache/pinot/pull/12259 for some reason this was hit when sketch loaded/used directly from binary e.g. ``` SELECT groupKey, distinctCountThetaSketch(rawSketchBinaryCol) -- this can cause group key i